fix permadiff on google_identity_platform_config.authorized_domains#8740
Merged
shuyama1 merged 2 commits intoAug 23, 2023
Merged
Conversation
Collaborator
5 tasks
Collaborator
Tests analyticsTotal tests:
|
Collaborator
1 similar comment
Collaborator
shuyama1
force-pushed
the
fix_authorized_domains_permadiff
branch
from
August 23, 2023 00:47
30e39a8 to
412b95f
Compare
Collaborator
Collaborator
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleServiceAccountAccessToken_basic |
Collaborator
|
Rerun these tests in REPLAYING mode to catch issues
|
Member
Author
|
run test on TC and confirm that it passes: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleBeta_MmUpstreamTesting_GOOGLEBETA_PACKAGE_IDENTITYPLATFORM/15852?buildTab=tests |
shuyama1
requested review from
a team and
zli82016
and removed request for
a team
August 23, 2023 16:14
This was referenced Aug 23, 2023
nevzheng
pushed a commit
to nevzheng/magic-modules
that referenced
this pull request
Aug 25, 2023
nevzheng
pushed a commit
to nevzheng/magic-modules
that referenced
this pull request
Aug 28, 2023
joelkattapuram
pushed a commit
to joelkattapuram/magic-modules
that referenced
this pull request
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes hashicorp/terraform-provider-google#15601
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)