Certificate manager update description for scope property certificate resource#8625
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
| served from non-core Google data centers. | ||
| Currently allowed only for managed certificates. | ||
|
|
||
| ALL_REGIONS: Certificates with ALL_REGIONS scope are served from all GCP regions (You can only use ALL_REGIONS with global certs). |
There was a problem hiding this comment.
ALL_REGIONS hasn't been added yet to the api docs. Though, It should be visible by the time this PR got merged.
Also, the scope is defined as an ENUM in the api page, but It's a sting in TF. is changing it from string to ENUM going to be a breaking a change?
There was a problem hiding this comment.
Yes, changing a string to an enum would be a breaking change.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 19 insertions(+), 16 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample|TestAccDataSourceGoogleServiceAccountJwt|TestAccFolderIamPolicy_basic |
|
Rerun these tests in REPLAYING mode to catch issues
|
… resource (GoogleCloudPlatform#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
… resource (GoogleCloudPlatform#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
… resource (GoogleCloudPlatform#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
… resource (GoogleCloudPlatform#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
scopefield incertificateresource to reflect that a new value, ALL_REGIONS, is now supported.scope=ALL_REGIONS.make testacc TEST=./google TESTARGS='-run=TestAccCertificateManagerCertificate'). Adding them to variables will make TF add a random suffix to the names when It creates the resources and hence avoid concurrency issues.If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)