Skip to content

Certificate manager update description for scope property certificate resource#8625

Merged
trodge merged 2 commits into
GoogleCloudPlatform:mainfrom
Hamzawy63:certificate-manager-update-description-for-scope-property-certificate-resource
Aug 14, 2023
Merged

Certificate manager update description for scope property certificate resource#8625
trodge merged 2 commits into
GoogleCloudPlatform:mainfrom
Hamzawy63:certificate-manager-update-description-for-scope-property-certificate-resource

Conversation

@Hamzawy63

Copy link
Copy Markdown
Contributor
  • Updated the description of the scope field in certificate resource to reflect that a new value, ALL_REGIONS, is now supported.
  • Modified an example to use scope=ALL_REGIONS.
  • Some of the resources names in the tests weren't identified using variables. That caused "resource already exists" error whenever I ran all acceptance tests for CCM at once(make testacc TEST=./google TESTARGS='-run=TestAccCertificateManagerCertificate'). Adding them to variables will make TF add a random suffix to the names when It creates the resources and hence avoid concurrency issues.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

certificatemanager: updated the description of the `scope` field in `certificate` resource to show that ALL_REGIONS is supported 

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 11, 2023
served from non-core Google data centers.
Currently allowed only for managed certificates.

ALL_REGIONS: Certificates with ALL_REGIONS scope are served from all GCP regions (You can only use ALL_REGIONS with global certs).

@Hamzawy63 Hamzawy63 Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL_REGIONS hasn't been added yet to the api docs. Though, It should be visible by the time this PR got merged.

Also, the scope is defined as an ENUM in the api page, but It's a sting in TF. is changing it from string to ENUM going to be a breaking a change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changing a string to an enum would be a breaking change.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 14, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 19 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 5 files changed, 19 insertions(+), 16 deletions(-))
TF OiCS: Diff ( 3 files changed, 7 insertions(+), 7 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2949
Passed tests 2638
Skipped tests: 302
Affected tests: 9

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample|TestAccDataSourceGoogleServiceAccountJwt|TestAccFolderIamPolicy_basic

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigQueryDataTable_bigtable[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample[Debug log]
TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample[Debug log]
TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample[Debug log]
TestAccDataSourceGoogleServiceAccountJwt[Debug log]
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge
trodge merged commit 07211a4 into GoogleCloudPlatform:main Aug 14, 2023
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
… resource (GoogleCloudPlatform#8625)

* Add a new supported value to the scope field in certificate resource

* Improve the naming of the examples to avoid concurrency errors while running acceptance tests

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
… resource (GoogleCloudPlatform#8625)

* Add a new supported value to the scope field in certificate resource

* Improve the naming of the examples to avoid concurrency errors while running acceptance tests

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
… resource (GoogleCloudPlatform#8625)

* Add a new supported value to the scope field in certificate resource

* Improve the naming of the examples to avoid concurrency errors while running acceptance tests

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
… resource (GoogleCloudPlatform#8625)

* Add a new supported value to the scope field in certificate resource

* Improve the naming of the examples to avoid concurrency errors while running acceptance tests

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants