Move gcp_sweeper_test.go to the sweeper package#8217
Conversation
|
go test ./google/sweeper -v -sweep="us-central1" -sweep-run="CloudRunV2Job" |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules |
|
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
melinath
left a comment
There was a problem hiding this comment.
Could you elaborate on why this change is necessary?
Currently, the file |
SarahFrench
left a comment
There was a problem hiding this comment.
Just a reminder that this PR requires a change on this line to be added to it : https://github.com/hashicorp/terraform-provider-google/blob/479845fb810c865bf0f58f5d7605039023df1684/.teamcity/components/generated/packages.kt#L61
f7cb2dd to
87b4604
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests:
|
|
I am going to merge this PR as the old Teamcity projects are read only now and no tests will be run in the old projects. |
…8217) * Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
…8217) * Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
…8217) * Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
…8217) * Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
The file gcp_sweeper_test.go.erb is moved from the google package to the sweeper_test package in the folder sweeper.
With this change, the command to run the sweepers in the teamcity settings need to change, too.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)