Skip to content

Generate DCL tests to service packages#8574

Merged
zli82016 merged 1 commit into
mainfrom
move-dcl-tests
Aug 11, 2023
Merged

Generate DCL tests to service packages#8574
zli82016 merged 1 commit into
mainfrom
move-dcl-tests

Conversation

@zli82016

@zli82016 zli82016 commented Aug 7, 2023

Copy link
Copy Markdown
Member

This reverts commit 63eca84.

The commit was reverted a couple of weeks ago. We are going to merge it again.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 30 files changed, 225 insertions(+), 225 deletions(-))
Terraform Beta: Diff ( 30 files changed, 249 insertions(+), 249 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2931
Passed tests 2629
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@zli82016
zli82016 requested a review from hao-nan-li August 8, 2023 16:57

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016
zli82016 merged commit 4e8d36c into main Aug 11, 2023
@zli82016
zli82016 deleted the move-dcl-tests branch August 11, 2023 21:35
SamGerber pushed a commit to SamGerber/magic-modules that referenced this pull request Aug 14, 2023
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants