Skip to content

Update .copywrite.hcl to ignore all test-fixtures regardless of package location#8645

Merged
SarahFrench merged 1 commit into
mainfrom
propagate-copyright-diff-upstream-1
Aug 15, 2023
Merged

Update .copywrite.hcl to ignore all test-fixtures regardless of package location#8645
SarahFrench merged 1 commit into
mainfrom
propagate-copyright-diff-upstream-1

Conversation

@SarahFrench

Copy link
Copy Markdown
Contributor

Addresses hashicorp/terraform-provider-google-beta#6059

Now test-fixtures are found in service packages the path to ignore them when adding copyright headers needs to be updated

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@SarahFrench
SarahFrench requested a review from zli82016 August 14, 2023 20:57
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@SarahFrench
SarahFrench merged commit 8c2a3e1 into main Aug 15, 2023
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
@SarahFrench
SarahFrench deleted the propagate-copyright-diff-upstream-1 branch August 17, 2023 12:32
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants