Adding backupdr product with managementServer resource#8612
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-)) |
Fixing lint issue
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBackupDRManagementServer_backupDrManagementServerExample |
|
|
hao-nan-li
left a comment
There was a problem hiding this comment.
Could you take a look at the error? Looks like there's a field missing in the URL.
Fixing Variable name
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBackupDRManagementServer_backupDrManagementServerExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
FIxing values of type and peering mode
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-)) |
Fixing description and example
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 988 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_backup_dr_management_server" "primary" {
networks {
peering_mode = # value needed
}
type = # value needed
}
|
Tests analyticsTotal tests:
|
Adding type and Peering_mode to coverage
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
Changing release version of provider to only beta
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 157 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBackupDRManagementServer_backupDrManagementServerExample |
|
|
Changing variable name
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 157 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBackupDRManagementServer_backupDrManagementServerExample |
|
|
Fixing Acceptance test and trademark
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 160 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
…atform#8612) * Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)