Skip to content

Adding backupdr product with managementServer resource#8612

Merged
hao-nan-li merged 18 commits into
GoogleCloudPlatform:mainfrom
niharika-98:main
Aug 11, 2023
Merged

Adding backupdr product with managementServer resource#8612
hao-nan-li merged 18 commits into
GoogleCloudPlatform:mainfrom
niharika-98:main

Conversation

@niharika-98

@niharika-98 niharika-98 commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_backup_dr_management_server`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBackupDRManagementServer_backupDrManagementServerExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBackupDRManagementServer_backupDrManagementServerExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you take a look at the error? Looks like there's a field missing in the URL.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBackupDRManagementServer_backupDrManagementServerExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBackupDRManagementServer_backupDrManagementServerExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@pradeepreddyk8 pradeepreddyk8 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the GCBDR team

FIxing values of type and peering mode
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 988 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 988 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_management_server (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_management_server" "primary" {
  networks {
    peering_mode = # value needed
  }
  type = # value needed
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2638
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 13 files changed, 992 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 157 insertions(+))
Terraform Beta: Diff ( 13 files changed, 996 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBackupDRManagementServer_backupDrManagementServerExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBackupDRManagementServer_backupDrManagementServerExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@niharika-98 niharika-98 reopened this Aug 11, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 157 insertions(+))
Terraform Beta: Diff ( 13 files changed, 996 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2940
Passed tests 2637
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBackupDRManagementServer_backupDrManagementServerExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBackupDRManagementServer_backupDrManagementServerExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

Comment thread mmv1/products/backupdr/product.yaml Outdated
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 160 insertions(+))
Terraform Beta: Diff ( 13 files changed, 1002 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 121 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2941
Passed tests 2638
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@hao-nan-li
hao-nan-li merged commit ef6b681 into GoogleCloudPlatform:main Aug 11, 2023
SamGerber pushed a commit to SamGerber/magic-modules that referenced this pull request Aug 14, 2023
…atform#8612)

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
DanielRieske pushed a commit to DanielRieske/magic-modules that referenced this pull request Aug 15, 2023
…atform#8612)

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 16, 2023
…atform#8612)

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
…atform#8612)

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…atform#8612)

* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants