Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/05-uifix
branch
from
October 29, 2026 09:21
ab129cb to
c11e0e6
Compare
yohamta0
force-pushed
the
stack/06-ui01
branch
2 times, most recently
from
October 29, 2026 12:58
a95bb89 to
37146c5
Compare
yohamta0
force-pushed
the
stack/05-uifix
branch
from
October 29, 2026 12:58
c11e0e6 to
34fd54f
Compare
yohamta0
force-pushed
the
stack/06-ui01
branch
from
October 30, 2026 06:44
37146c5 to
efdfb06
Compare
yohamta0
force-pushed
the
stack/05-uifix
branch
from
October 30, 2026 08:43
259ccb7 to
d8428df
Compare
yohamta0
force-pushed
the
stack/06-ui01
branch
2 times, most recently
from
October 31, 2026 04:50
2dac4e2 to
243f728
Compare
yohamta0
force-pushed
the
stack/05-uifix
branch
from
October 31, 2026 04:50
d8428df to
1d8d7de
Compare
yohamta0
force-pushed
the
stack/06-ui01
branch
from
October 31, 2026 09:21
243f728 to
b984532
Compare
yohamta0
force-pushed
the
stack/05-uifix
branch
from
October 31, 2026 10:36
9bc3108 to
a61cb7f
Compare
Run links now name a run on the workflow page with ?run. That page shows runs only later in this stack, so until then it sends such a link to the run page, as it already does for ?dagRunId. A link whose DAG name has no file of that name names the DAG of the run.
Run links now name the run on the workflow page, and absolute times drop the UTC offset. Update the tests that pinned the old forms.
A sub-run copy link opens the root run, so its label says so; a root run link uses its workflow file. A modified click on the definition link opens a new tab. Retry and compact counts expose their names to assistive technology, and the copy button test compares the classes.
The modal step drawer focuses itself on open. Shift+Tab from there left the dialog for the page behind it; it now wraps to the last control. The modal drawer also took the narrow-page cap of the panels beside the page, so at 1024 px it was 461 px wide and dragging it changed nothing; it now keeps its stored width. CopyButton left an unhandled rejection when its text function failed. That case now counts as a failed copy, and the button stays idle. Add the missing "Show in workflow" label to the static catalogs.
The braille spinner of a running or retrying step kept changing its frame every 80 ms when the user asked for reduced motion, while the glow of the running label already stayed still. Both now read one shared reduced-motion hook, and the spinner stays on its first frame. continuousRunCount read the count of the first continuous step, even when that step had stopped and a later one kept the run healthy. It now reads the running continuous step and falls back to the first one when none runs.
"View workflow definition" and "Show in workflow" were plain anchors whose href lacked the router basename. A Ctrl or Cmd click followed that href, so with a base path such as /dagu it opened /dags/... and left the mounted app. Router links put the base path in the href and still leave modified clicks to the browser.
yohamta0
force-pushed
the
stack/06-ui01
branch
from
October 31, 2026 10:36
b984532 to
f59d705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds the base pieces that the workspace pages use: small UI components, status and time helpers, layout contexts, and a shell for right-side step panels. It also reworks the run header and the step drawer onto these pieces.
Why
Later PRs build the canvas, the Activity panel and the step view. They all need the same status colours, one shared clock, one right panel at a time, and one panel shell. PR 7 and PR 9 build on this PR.
Changes
components/ui): newstatus-icon,icon-button,copy-button,kbd,spinner,retry-count,compact-count, andrepeat-summary.ts(one repeat policy shape for YAML and API). Changed:badge,dialog(raised layers),tooltip,status-chip,relative-time,matrix-text,ticker,refresh-button.statusPalette,runDisplayStatus,formatStepSpan,formatCompactCount,hatchPattern,shortRunId,pageVisibility(pauses CSS animation in a hidden tab),monaco-yaml,syntax-colors. Changed:dagRunTiming,clipboard,utils,styles/global.css.useClock(one timer for each period, paused when the tab is hidden),RightPanelContext(one right panel at a time),LayoutChromeContext(full bleed, hidden breadcrumb).PanelShellandStepSideDrawer;StepDetailsDraweris slimmed down to use them; small changes inStepDetailsand the foreach views.RunMetaLineandDAGRunHeaderare reworked;dagRunUrls.tsgainsbuildDAGPageURL,legacyRunPageRedirectURL,buildRunningTaskURL.testing/importGraph.tsandtesting/jsxLiterals.ts.useExactDAGRuns.test.tsxis deleted.How to review
lib/statusPalette.tsandlib/runDisplayStatus.ts.hooks/useClock.tsandcontexts/RightPanelContext.tsx.PanelShell.tsxandStepSideDrawer.tsx.RunMetaLine.tsxandDAGRunHeader.tsx.Most attention:
useClock(timer start and stop, hidden-tab catch-up), theRightPanelContextclaim rules, and theRunMetaLinerewrite, which is the largest change to existing code.Tests
badge,copy-button,icon-button,kbd,status-icon,repeat-summary,RightPanelContext,useClock,formatCompactCount,formatStepSpan,pageVisibility,runDisplayStatus,statusPalette, andtesting/__tests__/importGraph.status-chip,RunMetaLine,DAGRunHeader,dagRunUrls,dagRunTiming,PushBackHistory,RunProgressModal.realSchema.ts,leafStubs.tsx, and a few lines intest/setup.ts.Screenshots
The kit is used in all workspace views. The run header appears in this close-up of the final UI.