Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 29, 2026 09:21
6d5bdfe to
efb9eb0
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 29, 2026 10:28
2e69548 to
bbd170d
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 29, 2026 10:28
2994eff to
a2eb60e
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 29, 2026 10:50
bbd170d to
aaa8d29
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
2 times, most recently
from
October 29, 2026 12:58
8701cf2 to
eb4308f
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 29, 2026 12:58
aaa8d29 to
d1f192b
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 29, 2026 13:21
eb4308f to
a760b6c
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 30, 2026 06:44
180c2e5 to
49baa7a
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
2 times, most recently
from
October 30, 2026 08:43
3c5ed9a to
e7bdd66
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
3 times, most recently
from
October 31, 2026 04:50
91deb14 to
c598965
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 31, 2026 05:37
76af8b9 to
e0426b1
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 31, 2026 06:28
512010f to
7eefa4d
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
2 times, most recently
from
October 31, 2026 09:21
aba5363 to
5a1b420
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 31, 2026 09:21
7eefa4d to
36b5b89
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 31, 2026 10:42
5a1b420 to
5b1a63f
Compare
… links (dagucloud#3398) * UI: dags/components, dag-runs, components * Expect run list rows to open the run page * Fix review findings in the run list and workspace
Translate the run status messages of RunStatusMessage, which other locales showed in English. Lock the incident routing editor while a save or a reset is pending. Both replace the draft when they end, so an edit made in between was dropped and the tab reported a clean state. Stop polling the run history after a test run start once a grace window has passed. The start flag never expired, so a tab that started one test run polled every 5 s for its whole life. Show a month or a year label only when the tick gap is longer than the longest month or year. Shorter gaps put two ticks in one period and repeated its label. Render a worker's running task as a link, so it can take focus and open in a new tab natively. Use the compact icon size for the rename and delete buttons, and reuse waitsFor for the dependencies of an executed step row.
SWR restarts its poll timer whenever refreshInterval changes. The history passed a new function on each render, so a caller that renders more often than every 5 s, such as the run timeline while a run updates, held the test-run poll off and the list went stale. The function now changes only with the start time, the fallback interval, and whether the list holds a test run, which still restarts a poll that stopped. The step scope reads the handler events from HANDLER_EVENTS instead of a second list of the same names that could drift from it.
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 31, 2026 10:42
36b5b89 to
ea3b10a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds the data contracts and hooks of the workflow workspace (run history, sub runs, permissions, test runs, run spec), the run facts and edit buttons of the bar, the Workflow panel and the runtime profile section. It also moves the run summary blocks out of
DAGStatusOverviewand adds ghost rows to the run timeline items.Why
Every workspace component reads the same run and workflow data through typed hooks. This PR gives those types and hooks before any component needs them. It builds on the URL state of PR 18. PR 20 adds run selection and start controls, and PR 21 adds
WorkspaceDataProvider, which wires the hooks together.Changes
Counts: 10 existing files modified, 52 new files (about half are tests).
workflow-workspace/data):types.ts,context.ts(WorkspaceDataContext),useRunHistory,useSubRuns,useWorkspacePermissions,handlerMapping(lifecycle handler nodes),runFacts(isNeverRun, run creation time),testRun(10 minute TTL of a test run).contracts.tsre-exports the public types.WorkspaceEditorContext(editor handle and state),canvasRunPolicy(which run the canvas shows),useTestRunNotice,useStepViewHost,useEscClearsStep.RunFacts(inline and stacked layouts),WorkflowEditButtons(rename, delete),useFactTiers.DAGEditButtonsis rebuilt on a newuseDAGEditActionshook.dockTabs(which tabs a run shows),runExtents(lanes of run bars),FreezeWhenHidden,tabs/AgentRunSummary,tabs/stepScope.panel/WorkflowTabsPanel;profile/RuntimeProfileSection,DotenvBlock,dotenv.ts,runtimeProfile.ts(layered environment of a run).executions/useRunSpec,step/StepOutputRows.RunSummaryBlocks(progress, status message, error, conditions);DAGStatusOverviewuses it.DAGSettingsTabandIncidentsTabreport unsaved changes.timelineItems.ts: ghost rows for steps that a run reused, time-axis ticks with date-aware labels.WorkerList,WorkerMetrics,pages/workersget small edits.How to review
data/types.ts,context.ts,contracts.ts.data/useRunHistory.ts,useSubRuns.ts,runFacts.ts.dock/dockTabs.tsandcanvas/canvasRunPolicy.ts.timelineItems.ts(ghost rows).RunSummaryBlocks.tsxagainst the removed code inDAGStatusOverview.tsx.profile/files.Most attention: the ghost-row and axis logic in
timelineItems.ts, and the equivalence ofDAGStatusOverviewbefore and after the extraction.Tests
handlerMapping,testRun,dockTabs,runExtents,canvasRunPolicy,useTestRunNotice,WorkspaceEditorContext,useRunSpec,RunFacts,WorkflowEditButtons,AgentRunSummary,stepScope,RuntimeProfileSection,DotenvBlock,dotenv,runtimeProfile,RunSummaryBlocks,DAGRunOutputs,DAGSettingsTab,IncidentsTab,DAGEditButtons; shareddata/__tests__/fixtures.ts.timelineItems(large),DAGStatusOverview.Screenshots
These components are used by PR 21 and later; the screenshot shows the bar with run facts in the final UI.