Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 29, 2026 09:21
a52a9b6 to
8bb60aa
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
4 times, most recently
from
October 29, 2026 12:58
e7c0757 to
a1f4947
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 29, 2026 13:21
1eace44 to
1d479a2
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
3 times, most recently
from
October 30, 2026 08:07
ed94b5a to
1138d42
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 30, 2026 08:43
a1c5268 to
88dcc73
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 30, 2026 08:43
1138d42 to
17fc754
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 30, 2026 11:03
88dcc73 to
704df12
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
2 times, most recently
from
October 31, 2026 04:50
29a591b to
cc6206c
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 31, 2026 05:37
05a5188 to
e2867d5
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 31, 2026 05:37
cc6206c to
2f8063f
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 31, 2026 06:28
e2867d5 to
2c8b875
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
2 times, most recently
from
October 31, 2026 09:21
a77738e to
b67869c
Compare
yohamta0
force-pushed
the
stack/21-ui17
branch
from
October 31, 2026 10:43
3600a9f to
9faa391
Compare
…step list (dagucloud#3401) * UI: workflow-workspace/continuous, workflow-workspace/bar, workflow-workspace/data * Bound the samples cache and fix chart input * Test that run history polls under re-renders * Sync the webhook chip and fix bar and chart input * Read a continuous step again when its run ends
Without a variant the note was a success toast, which shows nothing.
Stop all reported success when the server returned 200 with a list of runs that did not stop. The error modal now lists those runs, and the view still refreshes. The run that an edited retry creates opened on the page named after the DAG, which finds no file when the DAG name differs from the file name. It now opens on the page of the source file. The line count of the run log was a live region, so screen readers announced it on every poll of a live run. It is now plain text for screen readers. Activity lines were keyed by their row, so open details moved to another line when a new line shifted the rows. They are now keyed by line number. Copy to editor checked only the editor handle when the user confirmed the replace. The editor can freeze or become read-only while the question is open, so the confirm now checks the same conditions as the button.
A toast without a variant is a success and shows nothing, so "Stop signal sent to all running instances" never appeared. It is now a note, like the toast of a single stop.
The Details chevron of an activity line had no handler of its own. Its click reached the row, which ignores a click while text is selected so that a drag-select does not toggle. Tab keeps a selection, so Enter on the chevron did nothing. The chevron now toggles on its own press. A log without the Page View switch shows only its tail, but Jump to line still opened a page. The run log then had no way back to the tail. The jump controls now follow the switch.
A pause while another stream loaded froze the previous stream: after a switch to stderr, a focus on Search or a scroll before the response kept stdout under the stderr label. A pause now freezes only loaded content, and freezes the new stream once it comes. A reschedule with a DAG name override makes a run of another DAG, which this workflow page does not list. The page now stays on its run instead of selecting the new one and reporting it as not found. The run ID link of the log pop-out named the workflow by its DAG name. It now names the file, whose name can differ.
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 31, 2026 10:44
b67869c to
60f1640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds the run actions cluster of the bar, a "Copy to editor" hook, the cached logs of reused steps, and the popout page for a log. It reworks the shared log viewers (
ExecutionLog,StepLog) to support cached lines and a log order toggle, and adds a canvas preview to the retry dialog.Why
A run of one step reuses earlier outputs, so its log must show the lines of the source runs too. A user also needs the stop, retry and reschedule actions on the bar, and a log in its own window. This PR follows PR 21 (step list, data provider). Later PRs mount the cluster, cached logs and popout in the page.
Changes
Counts: 10 existing files modified, 10 new files (4 tests new, 3 updated).
RunActionsCluster(stop, cancel auto-retry, reject, retry, reschedule, dequeue, then Copy to editor; each group keeps a fixed slot),useCopyRunSpecToEditor(confirms when the editor has unsaved changes).CachedLogs(reads the last 500 lines of each source run log, inactivityorrawmode).LogPopoutPageandPopoutBar(step log or run scheduler log, with links back to the workspace).LogOrderToggleanduseLogOrder;ExecutionLogandStepLogtakecachedLinesandpageView, and keep search and scroll per log identity;LogViewModeSwitch,ActivityLine(24 px rows with details),ForeachBodyStepLogfollow.DAGRunActions:stopAll(stop all running instances),markActions,onRescheduled,onDequeued, and apreviewEnginechoice (mermaidorcanvas) for the retry preview. A reused step shows as Skipped in the preview.DAGSpecReadOnly: reworked, with the canvas loaded lazily.How to review
dock/CachedLogs.tsx.ExecutionLog.tsxandStepLog.tsx(cached lines, tail and page view).bar/RunActionsCluster.tsxandDAGRunActions.tsx.popout/LogPopoutPage.tsx,PopoutBar.tsx.DAGSpecReadOnly.tsx.Most attention: the follow and pause logic of the live log end in
StepLogandExecutionLog, and the retry preview inDAGRunActions.Tests
RunActionsCluster,CachedLogs,LogPopoutPage,StepLog.ExecutionLog,DAGRunActions,DAGSpecReadOnly(each grows by several hundred lines).Screenshots
These components are used by later PRs. The screenshot shows the Log tab with the "cached" lines of reused steps in the final UI.