Repository navigation
Conversation
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 29, 2026 09:21
04535e9 to
a1580cf
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
from
October 29, 2026 09:21
d691645 to
184d54e
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 29, 2026 10:28
2e69548 to
bbd170d
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
2 times, most recently
from
October 29, 2026 10:50
3c73f4b to
fbe65aa
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 29, 2026 12:58
aaa8d29 to
d1f192b
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
2 times, most recently
from
October 29, 2026 13:21
70fe84b to
1a4f72a
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 29, 2026 13:21
d1f192b to
180c2e5
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
from
October 30, 2026 06:44
1a4f72a to
ae6b48f
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 30, 2026 08:43
49baa7a to
04b25b5
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
2 times, most recently
from
October 30, 2026 11:03
9073f96 to
c56eb67
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 31, 2026 04:50
91deb14 to
c598965
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
from
October 31, 2026 04:50
c56eb67 to
a617ade
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
from
October 31, 2026 05:37
c598965 to
512010f
Compare
yohamta0
force-pushed
the
stack/20-ui16
branch
3 times, most recently
from
October 31, 2026 09:21
ff7b92e to
3b82e5b
Compare
yohamta0
force-pushed
the
stack/19-ui15
branch
2 times, most recently
from
October 31, 2026 10:42
36b5b89 to
ea3b10a
Compare
…dagucloud#3399) * UI: dags/components, workflow-workspace/data, workflow-workspace/dock * Fix status i18n, save race and test-run polling * Keep the test-run poll alive across renders
The run check of a cache entry read the response of
GET /dag-runs/{name}/{dagRunId} as the run itself, while the server
wraps it in dagRunDetails. Every entry whose run was outside the
history then counted as gone. The test mock returned the details
unwrapped and hid this; it now matches the API.
Each answer of a run check re-ran the effect, which cancelled the
requests in flight and sent them again, and a running selected run
kept loading from settling. Each run is now asked once, and an answer
is never dropped.
A stored cache choice with no fresh entry left the step with no
source. It now gives way to the automatic choice, as a gone run does.
"Open last run" now targets the latest run instead of the selected
one. It falls back to the run of the host when the latest run is not
known.
Also keep the Start modal latch in state instead of a ref written in
render, hoist the run view store subscription to module scope, and
assert the history deltas of the leave guard on browser Back.
A preset time range ends now, but its clock ticks once a minute, so a run that started after the last tick fell outside the range and had no bar for up to a minute. The run filter of a preset now has no upper end; the axis keeps the range and a custom range keeps its end. The leave guard listened for links and Back only while the editor was dirty, so leaving the workflow dropped a notifications, incidents or profile draft without asking. It now listens while a settings draft is at risk too. With the cache chosen, the reuse source still reported the active run that the automatic choice waits for, which disabled Step only although the cache gives the reads. It reports no wait while the cache is chosen.
The run links host now passes the remote node and workflow name as the scope of the step cache, so captures and hashes of one workflow never answer for another one with the same step names.
The history lists the newest runs only. A chosen run that newer runs pushed out of it gave way to the automatic choice, as if it were gone, and the step reused another run. The chosen run is now read on its own, like a run of the cache, and gives way only when it is gone or cannot be a source. The server reuses the outputs of a finished run only. A cache entry of a run that was still active covered its step, and the step run that sent it was refused. Such an entry now covers nothing until its run ends. A custom time range stopped the clock of the run filter, so a running run ended at the time the clock last ticked, and a range after that time left the run out. The clock now ticks in every range mode.
yohamta0
force-pushed
the
stack/20-ui16
branch
from
October 31, 2026 10:43
3b82e5b to
4d90fad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds the run split button and start context, label chips, the visible-runs hook, the run timeline model, and
useReuseSource, which picks the earlier run that a step run takes its outputs from. It also moves the Start dialog andDAGActionsonto a lazy, profile-aware form.Why
The bar must start a whole run or one step, and the timeline must pick which runs to show. Step runs that reuse earlier outputs need a clear rule for the source run. This PR builds on the data layer of PR 19. PR 21 wires the data provider and adds the Activity step list. PR 22 adds the run actions.
Changes
Counts: 4 existing files modified, 28 new files (13 tests).
RunSplitButton,RunStartContext(one owner of the Start dialog, withrequestStart),LabelChipswithuseWorkflowLabels(each label opens the filtered list).useWorkspaceRun(selected run, pinned patches),useVisibleRuns(count or range, test runs, cached time, stored in localStorage),useWorkspaceRefresh(settleAll),sameContent(content equality for SWR copies).dock/runTimelineModel.ts(bars, lanes, axis scale, counts 5 to 30).step/useReuseSource(picks the source run and checks cached runs, with request limits),visual-editor/run/runSourceChoice.ts(auto,cacheor a named run),StepDeclared,StepFactsLine.RunLinksHost,EditorLeaveGuard(unload, link click, Back and Forward),useLegacyHistoryRedirect(old History index to a run id),canvas/useOpenStepDetails.StartDAGModalandDAGActionsare reworked: lazy form load,useProfileshook,only,markActions,startIconOnlyprops.How to review
step/useReuseSource.tswithrunSourceChoice.ts.data/useWorkspaceRun.tsanduseVisibleRuns.ts.dock/runTimelineModel.ts.bar/RunStartContext.tsxandRunSplitButton.tsx.DAGActions.tsxandStartDAGModal.tsx.Most attention:
useReuseSource(the rule for the source run and its request limits), anduseWorkspaceRun(pinned run and local patches against server data).Tests
RunStartContext,LabelChips,useVisibleRuns,runTimelineModel(large),useReuseSource,StepDeclared,WorkflowTabsPanel,EditorLeaveGuard,useLegacyHistoryRedirect,runSourceChoice,useProfiles.DAGActions,StartDAGModal.Screenshots
These components are used by PR 21 and later. The screenshots show the Start dialog and a step run that reuses earlier outputs.