Repository navigation
Conversation
This was referenced Oct 28, 2026
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 29, 2026 09:21
6d5bdfe to
efb9eb0
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 29, 2026 09:21
31dce0d to
e4a95d5
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 29, 2026 10:28
2994eff to
a2eb60e
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 29, 2026 10:28
ac19f1f to
4e46f86
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
3 times, most recently
from
October 29, 2026 13:21
eb4308f to
a760b6c
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
2 times, most recently
from
October 30, 2026 06:44
313d9f6 to
e9ee0d6
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
3 times, most recently
from
October 30, 2026 11:03
e7bdd66 to
8a5ff7f
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
2 times, most recently
from
October 31, 2026 04:50
a7196bf to
cdb61f0
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
2 times, most recently
from
October 31, 2026 05:37
76af8b9 to
e0426b1
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 31, 2026 05:37
cdb61f0 to
be6cdc3
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 31, 2026 06:28
e0426b1 to
aba5363
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
2 times, most recently
from
October 31, 2026 09:21
2e27f0c to
9f79233
Compare
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 31, 2026 09:21
aba5363 to
5a1b420
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 31, 2026 10:41
9f79233 to
a71c77e
Compare
…rs (dagucloud#3397) * UI: pages, dags/components, cockpit * Expect the run page from a run progress card * Load client issues before the node frame tests * Trust the server next run and tighten UI tests * Cover minimap and key-value fixes in tests * Test that a nested object block stays open * Test cancelled connect drags and expanded links * Test the notice of a YAML the editor cannot read * Ignore inherited keys in schedule descriptors * Test key-value rows that share a key * Test the exponent form of a number value
Run list rows and Activity lanes now open the run instead of the side panel.
Running rows read their run details every 10 s to decide "Healthy". Only a run with a continuous step can be Healthy, so other runs now read their details once, and a page of running runs no longer sends a request per row every 10 s. Enter on a portaled popup item, such as a Status option, also reached the run list and opened the highlighted run. The list now ignores keys that a popup handled and keys on options and menu items. The artifacts control navigates, so it is now a link: middle click and "Open in new tab" work, as on the name link. Registered palette commands shared ids with workflows of the same file name and with a second registration, which broke the active option. Their ids now carry the registration. A guard() prompt stayed open when its section became clean while the editor draft was dirty, since it closed only when no risk was left. It now closes when the risk it asks about goes. Other fixes: - A legacy sub-run link no longer applies the sub-run's step to the root run it opens. - Step retry disables Retry without the runDags permission, matching the guard. - The subscription event actions wrap in a narrow column. - useEscInStepYaml updates its callback ref in an effect, not during render. - The pollWhileEmpty doc states the real 2 s interval.
yohamta0
force-pushed
the
stack/18-ui14
branch
from
October 31, 2026 10:42
5a1b420 to
5b1a63f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds the URL model of the workflow workspace (
workspaceUrl.ts) and the redirects from old run and tab URLs. It removes the run modal and the split view from the run list page, and adds a command-palette registry, a step retry dialog and the dock tab strip.Why
One page per workflow needs one URL scheme (
?run,?step,?dock,?panel) and old bookmarks must still work. PR 17 addsLegacyRunRedirectand the list helpers. PR 19 builds the data layer on this URL state. PR 20 and later put the bar, step view and Activity panel on it.Changes
Counts: 31 existing files modified, 1 deleted, 38 new (about half are tests).
workflow-workspace/state):workspaceUrl.ts(useWorkspaceUrl, workspace mode, dock tab, open panel),legacyLinks.ts(old section routes to panels and run pages),useLegacyRedirect.ts.DockTabStrip,RunTabsPane,DockHeaderTools,propsEqual,layout/paneActive.ts,zLayers.ts(stack order of layers).escFree,useEscInStepYaml,useRightPanelClearance(measures the right panel over the canvas).bar/useShowRun,continuous/continuousNode,settings/useSettingsLeaveGuard,step/RepeatRule,executions/RunStatusDotanduseRunReferenceScope,visual-editor/references/stepReferences.ts.CommandPaletteProvidergetsusePaletteCommandsso a page can add a "workflow" group;CommandPaletteDialogshows it.pages/dag-runs/index.tsxdrops the modal and selection state;DAGRunTable,DAGRunGroupedViewopen the run page;DAGRunCard.tsxis deleted.ActivityLanesusesuseOpenPage.StepRetryDialog;ApprovalTab,ChatHistoryTab,HumanTasksTab,NotificationsTab,StepReviewModal,StatusUpdateModal,ParallelExecutionModal,DAGRunOutputsget edits for the new host.Layout.tsxcollapses the sidebar below 900 px and addsLayoutChromeProvider;ContentNavigationnames workflow sections.How to review
state/workspaceUrl.ts, thenlegacyLinks.tsanduseLegacyRedirect.ts.pages/dag-runs/index.tsxandDAGRunTable.tsx(what is removed).CommandPaletteProvider.tsxand its test.StepRetryDialog.tsx.Layout.tsx,useRightPanelClearance.ts,useSettingsLeaveGuard.ts.Most attention: the redirect table in
legacyLinks.ts(every old URL must land on the right place), and the deletion of the run modal path inpages/dag-runs/index.tsx.Tests
workspaceUrl,legacyLinks,useLegacyRedirect,useSettingsLeaveGuard,useRightPanelClearance,escFree,useShowRun,DockTabStrip,RunStatusDot,continuousNode,stepReferences,wordingJa,StepRetryDialog,CommandPaletteProvider,ContentNavigation,RunStatusChip,ApprovalTab,ChatHistoryTab.Layout,CommandPalette,DAGRunTable,DAGRunGroupedView,ActivityLanes,NotificationsTab,HumanTasksTab,MonitoringOffer,pages/dag-runs.Screenshots
These components are used by PR 19 and later; the screenshot shows the dock tab strip and the Activity panel in the final UI.