Repository navigation
Conversation
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/16-ui12
branch
from
October 29, 2026 10:28
8892d53 to
6b170c6
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 29, 2026 10:50
4e46f86 to
20b2c7a
Compare
yohamta0
force-pushed
the
stack/16-ui12
branch
from
October 29, 2026 10:50
6b170c6 to
1a36fbe
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 29, 2026 12:58
20b2c7a to
56e5943
Compare
yohamta0
force-pushed
the
stack/16-ui12
branch
from
October 29, 2026 12:58
1a36fbe to
401f3d1
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
3 times, most recently
from
October 30, 2026 08:43
e9ee0d6 to
c6aeecb
Compare
yohamta0
force-pushed
the
stack/16-ui12
branch
from
October 30, 2026 11:03
87ebd67 to
b2766fd
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
3 times, most recently
from
October 31, 2026 05:37
cdb61f0 to
be6cdc3
Compare
yohamta0
force-pushed
the
stack/16-ui12
branch
2 times, most recently
from
October 31, 2026 06:28
c629d49 to
b9a5966
Compare
yohamta0
force-pushed
the
stack/17-ui13
branch
2 times, most recently
from
October 31, 2026 09:21
2e27f0c to
9f79233
Compare
yohamta0
force-pushed
the
stack/16-ui12
branch
from
October 31, 2026 10:41
0afb674 to
a74a8bf
Compare
…gucloud#3396) * UI: visual-editor/inspector, dags/components, visual-editor/references * Update spec editor E2E tests for the new editor * Show the already-formatted note as info * Ask before restoring a draft of an older version * Keep save checks and editor state across updates * Show the server steps when the YAML does not parse * Log a failed load of the client issue checks * Save the pending draft when the key changes * Send the focused field on Ctrl+S and read 1e3
A progress card now opens the run instead of a progress dialog.
DAGSpec loads the client issues on mount without waiting for them. A test file that ended first left that load running, and the import of cron-parser after the test environment was gone failed the run.
summarizeSchedules ignored the scheduler's next run when no computed time matched it, which happens when the zone given is wrong, although the option is documented to win over the computed time. describeCron worded steps that do not divide their range, such as */45 or 0 */5, as even intervals; those now stay as the raw expression. The tests restore spies after each NodeDetailsFrame test, require a change callback before reading its form data, query the loading status by role and name, and describe the server-match case as it is.
Earlier PRs fixed three behaviors whose tests could only land here, where the test files exist: - A minimap drag ends at pointercancel or lostpointercapture, so a touch that the browser cancels no longer leaves the view following the pointer. - A wheel over the minimap that counts lines zooms by the same step as the canvas and keeps the page from scrolling. - The key-value editor sends a key named like an Object.prototype member, such as `constructor`, instead of dropping it.
Clearing the last value of a nested object in the parameters form once closed its block and hid the field being typed in. The test keeps that from coming back now that a form renders the template.
The canvas test covers a connect drag that ends in pointercancel: it links nothing and reports no drop. The YAML panel test covers a link that turns the step view expanded while the file shows: the step opens. Both test fixes from earlier in the stack, whose test files start here.
The notice line of the page names the line of the first YAML error while the canvas shows the steps that the server read.
The cron descriptors were a plain object: an expression such as "constructor" found an inherited function, and the schedule summary threw while it rendered. A Map holds only the listed descriptors, so any other expression gets no preview, like one the parser rejects. The tests now clear the docs sidebar key even when an assertion fails, and find the add control and the status dot by role and name, so the read-only check also sees a control named by aria-label.
The key-value widget sends nothing while two rows share a key and marks those keys invalid. The test file for the widget starts here.
A number input accepts 1e3. The value field of a number that also takes a reference must read it as a thousand, not as 1. The test file of the field starts in this PR.
yohamta0
force-pushed
the
stack/17-ui13
branch
from
October 31, 2026 10:41
9f79233 to
a71c77e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
List pages and the cockpit now open a run on its workflow page, not in a modal. This PR adds small helpers for the run view (tab rules, schedule summary, step status gates), a loading state for the workflow page, and a redirect for old run URLs. It also adds many tests for earlier visual-editor code.
Why
The workspace page replaces the run modal and the run page. Lists must link to it first, and old links must keep working. PR 16 ends the inspector work. PR 18 adds the workspace URL state and the legacy redirects that use these helpers. PR 19 onward builds the workspace data layer.
Changes
Counts: 25 existing files modified, 34 new files (32 of them tests).
features/dag-runs):RunStatusChipanduseListRunDisplay: a running run with no failed step reads "Healthy" in a list.lib/useOpenPage: a click navigates, Ctrl or Cmd click opens a new tab.dagRunPagination.ts: remove the unuseduseExactDAGRunshook (about 200 lines).features/dags/lib:runViewTabs.ts(RunViewTab, which tabs a run has),scheduleSummary.ts(schedule entries with next fire time),stepStatusGate.ts(when a step status can be set or retried).RunProgressStackno longer opensRunProgressModal. A card click goes to the run page (buildDAGPageURL).pages/dag-runs/LegacyRunRedirect.tsxfor/dag-runs/:name/:dagRunId. Small edits inpages/cockpit,queues/queue,artifacts,event-logs,wiki,system-status.TemplateSelectorloses its selected-template display;CockpitToolbar,DateKanbanListanduseCockpitStatefollow.WorkspaceLoading.tsx: the bar with the workflow name plus a loader, so the page does not move on load.SplitLayouttransitions list exact properties;WorkersSummary,QueueCard,PathsCard,LicenseProviderget minor edits.How to review
features/dags/lib/runViewTabs.ts,scheduleSummary.ts,stepStatusGate.ts.features/dag-runs/lib/useOpenPage.ts,RunStatusChip.tsx,useListRunDisplay.ts.RunProgressStack.tsxandpages/dag-runs/LegacyRunRedirect.tsx.TemplateSelector,DateKanbanList).Most attention: the removal of the progress modal in
RunProgressStack, and the removal ofuseExactDAGRuns(check that nothing else imports it).Tests
runViewTabs,scheduleSummary,stepStatusGateunit tests;repeat-badge,retry-count;LegacyRunRedirect;WorkspaceLoading;messages/untranslated.test.ts(checks that zh-CN and ja catalogs do not leave English text).NodeDetailsFrame,DAGSpec.compactNotices,DAGSpec.ndvSegments,YamlFilePanel,quickFixProvider,DAGEditorWithDocs,DetailsCanvas,editMessages, canvasFlowandoverlays,ExportMenu, inspector widgets (KeyValueWidget,ObjectTemplate,ReferenceTextWidget,StringOrMap,ValueOrReference),SaveDiffDialog.RunProgressStack,DateKanbanList,TemplateSelector, queue and artifacts page tests,relative-time.Screenshots
The workflow page is reached from lists only after later PRs wire the route. The screenshot shows the list page that links to it.