Repository navigation
Conversation
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/29-e2
branch
4 times, most recently
from
October 29, 2026 12:58
ae9d543 to
a6d74ac
Compare
yohamta0
force-pushed
the
stack/29-e2
branch
2 times, most recently
from
October 30, 2026 06:44
c9711fc to
2207936
Compare
yohamta0
force-pushed
the
stack/28-e1
branch
2 times, most recently
from
October 30, 2026 08:43
890417e to
bf97597
Compare
yohamta0
force-pushed
the
stack/29-e2
branch
2 times, most recently
from
October 30, 2026 11:03
fadf323 to
683ce6b
Compare
yohamta0
force-pushed
the
stack/29-e2
branch
2 times, most recently
from
October 31, 2026 05:37
568c0b3 to
e01e542
Compare
yohamta0
force-pushed
the
stack/28-e1
branch
2 times, most recently
from
October 31, 2026 06:28
85b0ca6 to
e7f5026
Compare
…loud#3408) * e2e: shared helpers, fixtures and updated specs * Split the e2e disk-conflict test by branch * Fail e2e teardown when a DAG is not deleted
The workspace specs checked that mode tabs, the add-step FAB and the YAML read-only chip are absent, but no component renders those test ids, so the checks could never fail. They are removed; the positive checks beside them cover the behavior. The focus-restore check after closing the node view now retries, since focus can return to the canvas a frame after the view hides. Button locators in the layout spec match exact names, so a longer label such as "Test run, not kept. Back to latest" cannot satisfy them. The continuous empty state is matched in full. adminToken and expectAt were copied into several specs; the workspace fixtures module now exports one of each.
The keyboard tests checked only that the run count grew, so the page could stay on the earlier run and still pass. They now check that ?run names the new run. The /executions redirect test read the URL once after Back, which could pass while a pushed redirect bounced back to the workflow. It now expects Back to return to the page that was open before the legacy link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR adds nine Playwright specs under
ui/e2e/workspace/. They cover the node view, the layout, keyboard use, deep links, legacy links, manual actions, pop-out logs, the continuous tab, and the absence of Mermaid code on the workspace page.Why
The workspace replaces several pages and keeps old links working. The behavior needs browser tests. This PR builds on the helpers of PR 28. PR 30 adds the second half of the specs.
Changes
ndv.spec.ts: node view on double-click, outputs of a run, declared outputs of a step that never ran, the whole-file YAML panel, typed step YAML kept across the form with undo.layout.spec.ts: page and canvas size at 1280x800, Start and Save slots stay in place, toolbar pinned at five widths, node view docked at 1280px and 900px.keyboard.spec.ts: run a step and read its log without the mouse; the node view keeps its keys after Run step.deeplinks.spec.ts,legacy-links.spec.ts: each workflow tab path opens its zone or panel,/spec,/status?dagRunId,/historyand/executionsredirect to the workspace.manual-actions.spec.ts: approve, push back with feedback, and send a human task back.popout.spec.ts: step log page, ZIP download of/dagRun-log, sub-run log with breadcrumb.continuous.spec.ts: the Continuous tab and its empty state; no tab for a run without a continuous step.no-mermaid.spec.ts: the workspace page loads no Mermaid code; a Wiki page with a Mermaid block does.How to review
ndv.spec.ts, the largest file.layout.spec.tsand the size assertions.deeplinks.spec.tsandlegacy-links.spec.tstogether.Pay most attention to these places:
?yamland?runparameters correct.Tests
This PR is test code:
continuous.spec.ts,deeplinks.spec.ts,keyboard.spec.ts,layout.spec.ts,legacy-links.spec.ts,manual-actions.spec.ts,ndv.spec.ts,no-mermaid.spec.ts,popout.spec.ts, all inui/e2e/workspace/.Screenshots
No visible UI change in this PR.
These specs cover the screens that PR 5 to PR 27 of the stack add.