Skip to content

test(ui): add YAML fixtures for the document model tests - #5

Open
SCcagg5 wants to merge 2 commits into
stack/04-g4from
stack/05-uifix
Open

SCcagg5 wants to merge 2 commits into
stack/04-g4from
stack/05-uifix

Conversation

@SCcagg5

@SCcagg5 SCcagg5 commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Part of a stack of 31 pull requests that depend on each other. They must be reviewed and merged in order: each PR builds on the previous one and its diff only contains its own changes.

All PRs of the stack
# PR
1 specs: Add spec 083 and the samples store
2 ir: Add run state fields for ephemeral runs and reused outputs
3 runtime: Bound continuous steps and carry outputs of selected steps
4 api: Add step samples, events, availability and selected-step runs
5 test(ui): add YAML fixtures for the document model tests
6 ui(lib): add shared UI kit, status helpers and right-panel shell
7 ui(canvas): add canvas engine core, toolbars and editor helpers
8 ui(i18n): add workspace message catalogs, first batch
9 ui(canvas): add canvas Flow view, step run panel and workflow panel
10 ui(editor): add YAML document model, canvas model and run source logic
11 ui(editor): Add edit session, YAML format and quick fixes, run actions, tab strip
12 ui(editor): Add canvas graph model, Add step panel, issues popover, run bar
13 ui(canvas): Add layered layout, dependency edges, status styles, reference picker
14 ui(canvas): Add export, flow builder, upstream data panel, output capture
15 ui(canvas): Add node cards, launchers, inspector sections, client issues
16 ui(editor): Add visual editor, step inspector and YAML file panel
17 ui(lists): Open runs on the workflow page; add tab and schedule helpers
18 ui(workspace): Add workspace URL state, legacy redirects and run list links
19 ui(workspace): Add workspace data layer, run facts and Workflow panel
20 ui(workspace): Add run start controls, visible runs and reuse source
21 ui(workspace): Add data provider, bar identity, continuous panel and step list
22 ui(logs): Add run actions cluster, cached logs and log popout page
23 ui(workspace): Add Activity dock, step run view and workflow page
24 test(workspace): Add integration tests for the workspace shell and step view
25 ui(pages): Retire classic run pages and open runs on the workflow page
26 test(editor): Add integration tests for the editor, inspector and run overlay
27 test(ui): Add repository-wide guard tests and ESLint boundary rules
28 e2e: Add workspace helpers and fixtures, update existing specs
29 e2e: Add workspace specs, part 1 of 2
30 e2e: Add workspace specs, part 2 of 2
31 examples: Add the workspace demo workflows

Stack 5/31. Base branch: stack/04-g4. Review and merge in order; this PR builds on the previous one.
Size: 43 files changed, 783 insertions(+).
Checked: Typecheck (tsc) of the whole UI and the unit tests of this PR (Vitest), on top of the previous PR.

Summary

This PR adds 43 YAML fixture files under ui/src/features/visual-editor/doc/__tests__/fixtures/. It adds no code and changes no existing file.

Why

The tests of the YAML document model need real workflow files with odd forms. They are kept apart so that the code PRs stay small. The fixtures are read by the document model tests that start in PR 11; the model code itself comes in PR 10.

Changes

  • 43 new files, 0 modified.
  • Syntax edge cases: anchors-aliases, block-scalars, folded-line-break, flow-collections, flow-maps-unicode, quoted-keys-and-values, odd-indentation, long-lines, empty-file, invalid-yaml.
  • Comments: comments-everywhere, build-comments, unicode-comments, multidoc-comments-markers, spec-harness-comments.
  • Multi-document files: multidoc-empty-between, multidoc-subdag, multidoc-unnamed-later.
  • Step forms: shorthand-steps, nested-array-run, nested-parallel-groups, map-steps, map-steps-forbidden, foreach-string-items.
  • Real-world workflows: demo-agent-release, demo-graph-etl, chain-router, router-numeric-band, router-regex-keys, harness-acp, scheduler-cron, xlsx-japanese, embedded-local.

How to review

  1. Skim the file names for coverage.
  2. Open the two or three fixtures you know best and check that they are valid Dagu YAML, except invalid-yaml.yaml, which is invalid on purpose.

Pay attention to fixtures that contain secrets or host paths. None is expected.

Tests

No test file in this PR. The fixtures are data for the tests in PR 11 and later.

Screenshots

No visible UI change in this PR. The document model that reads these files drives the editor shown in the final UI.

This was referenced Oct 28, 2026
…agucloud#3384)

* Intake, CLI and REST API: samples, events and availability of a step, selected step runs; generated types
* Satisfy linters in the step samples API
* Name the output source in the start steps test
* Skip POSIX-shell step run tests on Windows
* Clarify API descriptions of samples and sources
* Answer step sample queries by the contract
* Make the spec hash check atomic with the write
* Keep empty param defaults in the reference scope
* Tighten the outputsFromRuns conformance test
* Describe --outputs-from as dependency carrying
* Keep released step run contracts and fix reuse
* Mark handler output lists as static in the scope
* Keep the logs of a source run when removing a run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant