Repository navigation
Conversation
This was referenced Oct 28, 2026
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 29, 2026 12:58
e7c0757 to
a1f4947
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
2 times, most recently
from
October 29, 2026 13:21
56c4f4e to
7f1089c
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
2 times, most recently
from
October 30, 2026 06:44
14949d9 to
ed94b5a
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
2 times, most recently
from
October 30, 2026 08:07
2e9eeaa to
6391cc8
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 30, 2026 08:07
ed94b5a to
1138d42
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
from
October 30, 2026 08:43
6391cc8 to
c62562a
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 30, 2026 08:43
1138d42 to
17fc754
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
from
October 30, 2026 11:03
c62562a to
c69c6d8
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
2 times, most recently
from
October 31, 2026 04:50
29a591b to
cc6206c
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
2 times, most recently
from
October 31, 2026 05:37
17f31b9 to
7b0a8a1
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 31, 2026 05:37
cc6206c to
2f8063f
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
from
October 31, 2026 06:28
7b0a8a1 to
c4ff36b
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 31, 2026 09:21
a77738e to
b67869c
Compare
yohamta0
force-pushed
the
stack/23-ui19
branch
from
October 31, 2026 09:21
c4ff36b to
0d357a0
Compare
yohamta0
force-pushed
the
stack/22-ui18
branch
from
October 31, 2026 10:44
b67869c to
60f1640
Compare
…agucloud#3402) * UI: dags/components, workflow-workspace/bar, workflow-workspace/popout * Mark the source-match note as info * Fix stop-all, retry link, and run log details * Show the stop-all toast as a note * Let the log chevron and jump work as documented * Fix stale log stream, reschedule and run links
The workflow page now shows runs: an old ?dagRunId link and a progress card open the run there, and its run bar stops the run. The run page stays until a later change retires it.
A run link names the workflow by the DAG name of the run. When no file has that name, the page reads the run and opens its source file.
An earlier PR stops a legacy sub-run link from applying the step of the sub-run to the root run that it opens, since that step is not one of the root's steps. The page redirect test still expected the step in the target URL, so it failed. It now expects the root run alone.
A sub-run link opened its root run: Cmd/Ctrl-click on a sub-run, the pop-out run link and a legacy ?subDAGRunId link lost the sub-run, and a ?step of the sub-run was applied to the root. A run URL now names a sub-run with ?subRun next to ?run. Once the root run has loaded, the workspace opens that sub-run on the sub-run stack, with ?step as a step of the sub-run, and drops the link from the URL. A run link of a workflow whose file was deleted, or renamed while its DAG name stayed, ended at "Workflow not found". The run now shows on its own when it loads without a source file. A run link of a DAG named apart from its file also opened another DAG that has the file of that name; the page now asks the run for its file first. The sub-run drawer is an open dialog to the workspace, so Escape pops the drawer instead of also leaving the run snapshot or clearing the step. Other fixes: - The duration of a running step reads a time cut to the second, so the clock snapshot stays the same within a tick. - The run outputs stop polling when the 15 s after the end of a run close, with no other render needed. - The step sub-run list keeps children that the sub-run list does not have yet, after the others. - The log output placeholder of a log step is translated. - The E2E URL checks no longer depend on query order and retry on the new tab.
The run summary now links to the run page only while an agent waits for an answer. Only the case without a waiting agent had a test, so the link could disappear without a failure. Cover the waiting case, with the text and the address of the link.
stepParticipation now takes whether the run carries the step, since a skipped node alone does not tell a reused step from a plain skip. The step facts pass it from runInputProvenance. The outputs of a running or waiting step were read before they existed, and the request key stays the same when the step finishes, so the panel kept "No outputs in this run". Outputs are now read once the step settles.
A step run of an unsaved draft took its previous steps from the saved file, so a dependency that only the draft has was left out, and Run upstream steps could do nothing. The editor handle now gives the definition that the server built from the buffer, and a step run reads its steps from it. The node view of a foreach step had no item list: View items led to tabs without one. The Log tab of the node view now lists the items over the raw log, and a foreach step opens on that tab. For a workflow whose DAG name differs from its file name, the page hid the workspace while it looked up the file of each selected run. That remounted the editor and reset its text and undo history. A lookup now keeps a workspace that already shows the file. A run that no workspace can show stands on its own: a run whose file is gone, and now a run of an older DAG name of the file. The view follows the run while it is active, and a ?subRun link shows its sub-run instead of the root run. Show in all workspaces dropped only ?workspace, so the workspace selected in the app bar could hide the workflow again. It now selects all workspaces.
yohamta0
force-pushed
the
stack/23-ui19
branch
from
October 31, 2026 10:44
0d357a0 to
f52574e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All PRs of the stack
Summary
This PR assembles the workflow workspace and makes it the page of a workflow. It adds the workspace shell, the workflow bar, the Activity dock (timeline, run steps, logs), the step run view and the commands and keys. The workflow page
/dags/:namenow renders the workspace in place of the classic tabbed page. It removes the old DAG details modal and side panels.Why
The earlier UI PRs (5 to 22) built the canvas, the editor, the data layer and the first parts of the workspace. This PR joins them on one page, so the stack has a working end to end screen. PR 24 adds integration tests for it. PR 25 removes the remaining classic screens and rewires the links.
Changes
51 files: 8 modified, 32 new, 11 deleted.
WorkflowWorkspace.tsx,layout/WorkspaceLayout.tsx,canvas/WorkspaceCanvas.tsx,hosts/WorkspaceRunHosts.tsx(sub-run stack and root run context),executions/RunSnapshotCanvas.tsx(read-only canvas of a past run),commands/WorkflowCommands.tsx,keys/useWorkspaceKeys.ts,notices/useWorkspaceNotices.ts.bar/WorkflowBar.tsx,bar/RunChip.tsx,bar/RunDetailsPopover.tsx.DockContext.tsx,LogsDock.tsx,RunTimeline.tsx,RunStepsNav.tsx,StepFailure.tsx,useDockAutoOpen.ts,useDockStep.ts, anddock/tabs/(runTabBodies.tsx,logTarget.ts).step/StepRunView.tsx,StepFacts,StepForeach,StepLogPane,StepManualActions,StepRunTabs,StepSubRuns,useStepRunActions.ts. Canvas hooksuseDockYield.tsanduseStepCommandHost.tsconnect step commands to these actions.pages/dags/dag/index.tsxrendersWorkflowWorkspace,WorkspaceLoadingandLogPopoutPage, and redirects old URLs withuseLegacyRedirect.TimelineChart.tsxgets a label column, a cached-time zone and ghost steps from the source run.DAGStatus.tsx,NodeStatusTableRow.tsx,SubRunStackModal.tsxand two barrel files lose code that only the old page used.DAGDetailsContent,DAGDetailsModal,DAGDetailsPanel,DAGDetailsSidePanel,ModalLinkTab,cockpit/DAGPreviewModaland their tests.How to review
pages/dags/dag/index.tsxfor what the page keeps and drops.WorkflowWorkspace.tsxandlayout/WorkspaceLayout.tsxfor the structure.dock/DockContext.tsx, thenuseDockAutoOpen.ts, thenRunTimeline.tsx.step/StepRunView.tsxanduseStepRunActions.ts.Most attention: the dock open and close rules in
DockContextanduseDockAutoOpen, and the step actions inuseStepRunActions, because they decide which run a click acts on.Tests
This PR changes tests only by deleting the tests of the deleted components (
DAGDetails*.test.tsx,DAGPreviewModal.test.tsx). Tests for the new files are in PR 24.Screenshots
The page is reachable at
/dags/:namefrom this PR.