Skip to content

Scenario: The Command Palette #5400

Open

Description

[Original issue: #2046] [Original Spec: #2193] [v2 Spec: #5674] [Spec Addendum 1: #6532]
TODO for initial PR
  • The list view items should be clickable
  • The list should be sorted by weight, then alphabetically
  • There should be stronger weighting for consecutive chars. Case in point: the sett example below
  • If you click on a list view item, focus enters the list view item, and then you can't hit enter to select it.
  • tests tests tests tests.
  • The auto gen names should probably only have the first letter capitalized - I bet if I do that I'll have to revert it during the PR... hmm...

v2.0 Follow-up work

Tasks

Bugs

Related, but indirectly

Backlog work

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Apr 17, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 17, 2020
  3. changed the title [-][Reserved for future use][/-] [+]Scenario: The Command Palette[/+] on Apr 17, 2020
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Apr 17, 2020
  5. ghost added a commit that references this issue on Jun 11, 2020
  6. zadjii-msft commented on Jun 19, 2020

    @zadjii-msft
    MemberAuthor

    Alright, so lets get some teaser images of what's in progress:

    MicrosoftTeams-image (8)
    MicrosoftTeams-image (7)
    MicrosoftTeams-image (6)
    MicrosoftTeams-image (5)

    This is including the spec changes in review over in #6532.

    There's also a shadow on the dialog that the snipping tool is conveniently leaving out.

  7. ghost added a commit that references this issue on Jun 26, 2020
  8. ghost added a commit that references this issue on Aug 21, 2020
  9. ghost added a commit that references this issue on Aug 24, 2020
  10. added a commit that references this issue on Sep 5, 2020
  11. Don-Vito commented on Nov 16, 2020

    @Don-Vito
    Contributor

    Mike Griese (@zadjii-msft) - is there a plan to add a lazy loading for command palette. From my startup profiling, the load adds more than 0.5 sec on startup?

  12. zadjii-msft commented on Nov 18, 2020

    @zadjii-msft
    MemberAuthor

    Not at the moment, but .5s is pretty bad 😬 Maybe we should be! Presumably, we don't need to expand iterable commands before displaying the UI, so that could be done on a background thread, and if the user does super quickly open the cmdpal, then we could wait for that background job to complete. Iterable commands won't have a keybinding set on them, so I'm not worried about that so much.

    Out of curiosity, how are you profiling the startup? Are there any other hot paths in our startup that stand out? (Might be best to start a new thread for that discussion though)

  13. Don-Vito commented on Nov 18, 2020

    @Don-Vito
    Contributor

    Not at the moment, but .5s is pretty bad 😬 Maybe we should be! Presumably, we don't need to expand iterable commands before displaying the UI, so that could be done on a background thread, and if the user does super quickly open the cmdpal, then we could wait for that background job to complete. Iterable commands won't have a keybinding set on them, so I'm not worried about that so much.

    Out of curiosity, how are you profiling the startup? Are there any other hot paths in our startup that stand out? (Might be best to start a new thread for that discussion though)

    I am using intel's vtune profiler both in usual and kernel events modes.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CmdPalCommand Palette issues and featuresArea-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-ScenarioProduct-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions