Activity

1. William Wong (compulim)

   added

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   on Dec 2, 2019
2. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Dec 2, 2019
3. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Dec 2, 2019
4. Dustin L. Howett (MSFT) (DHowett-MSFT)

   assigned

   Dustin L. Howett (MSFT) (DHowett-MSFT)

   and

   Mike Griese (zadjii-msft)

   and unassigned

   Dustin L. Howett (MSFT) (DHowett-MSFT)

   on Dec 2, 2019
5. zadjii-msft commented on Dec 2, 2019

   

   Mike Griese (zadjii-msft)

   on Dec 2, 2019

   Member

   More actions

   I could have sworn that we had an issue that was "I want to be able to send input to the Terminal with a keybinding" but it doesn't seem like we do. Congratulations! This is now that issue ☺️

   Previously mentioned (in #2046):

   • We want to be able to send strings of characters
   • We want to be able to send input with or without a trailing newline (so people can run a command like Feature Request: global hotkey to re-run last command #2809)

   👍React with 👍2Reacted by Wallison Santos and sean7130

   😄React with 😄2Reacted by William Wong and Wallison Santos
6. Mike Griese (zadjii-msft)

   changed the title [-]Command for sending CTRL+BREAK[/-] [+]Enable sending input to the Terminal with a keybinding[/+] on Dec 2, 2019
7. Mike Griese (zadjii-msft)

   removed their assignment

   on Dec 2, 2019
8. Mike Griese (zadjii-msft)

   added

   Area-InputRelated to input processing (key presses, mouse, etc.)Related to input processing (key presses, mouse, etc.)

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   on Dec 2, 2019
9. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Dec 2, 2019
10. Mike Griese (zadjii-msft)

    added this to the Terminal Backlog milestone on Dec 2, 2019
11. Dustin L. Howett (MSFT) (DHowett-MSFT)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Dec 2, 2019
12. j4james commented on Dec 2, 2019

    

    James Holderness (j4james)

    on Dec 2, 2019

    Collaborator

    More actions

    In case this affects the implementation, note that there are a couple of VT escape sequences for reprogramming the keyboard which we may want to support one day (e.g. DECUDK and DECPFK).

    Also I think issue #2005 is quite similar to this.
13. 7 remaining items

    Load more
14. Dustin L. Howett (DHowett)

    modified the milestones: Terminal Backlog, Terminal v2.0 on Jul 30, 2020
15. zadjii-msft commented on Jul 31, 2020

    

    Mike Griese (zadjii-msft)

    on Jul 31, 2020

    Member

    More actions

    No real commitments on this one quite yet. I especially want to do this for it's potential integration with the command palette (#5400). The hardest part of this is honestly just designing exactly how the setting should work. How will arrow keys be encoded in the settings file? Trailing newlines? etc.

    The implementation itself should be fairly trivial

    👍React with 👍1Reacted by damnskippy
16. Mike Griese (zadjii-msft)

    added

    Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.

    on Jul 31, 2020
17. damnskippy commented on Jul 31, 2020

    

    damnskippy

    on Jul 31, 2020

    More actions

    Wonder if it's an option to specify a sequence/string of characters bound to a key shortcut. User can input the escape sequence for the key they want to enter. For example, left arrrow will be "\x1b[D". This would also allow for the other use case for this i.e. to be able to enter an arbitrary text (as opposed to mapping to another key). Say F12 is mapped to a character sequence "text entered over and over again\n" (including the newline). I believe Alacritty does something like this.

    Just a thought, not sure how useful.
18. lhecker commented on Aug 10, 2020

    

    Leonard Hecker (lhecker)

    on Aug 10, 2020

    Last edited by lhecker

    Member

    More actions

    I'd like to implement this feature, if you don't mind. 🙂

    I believe this feature is crucial, but realistically will probably only be used by a small fraction of all Windows Terminal users.
    As such it'd be best in my opinion to keep the feature as straightforward and low level as possible. That way it's easy to implement and simultaneously very powerful.

    Config

    I imagine a potential config setting to look like the following:

    {
        "keybindings":
        [
            // Bind Ctrl+Shift+C to the Delete key
            { "keys": "ctrl+shift+c", "command": { "action": "sendInput", "input": "\u007f" } },
    
            // Send some text when pressing F12
            { "keys": "f12", "command": { "action": "sendInput", "input": "text entered over and over again\n" } },
    
            // Swap left/right arrow keys (lol)
            { "keys": "left", "command": { "action": "sendInput", "input": "\u001b[C" } },
            { "keys": "right", "command": { "action": "sendInput", "input": "\u001b[D" } },
    
            // Send a VK_PLAY (media play/pause button) key press to your shell
            { "keys": "f11", "command": { "action": "sendInput", "input": "\u001b[250;0;0;1;0;1_\u001b[250;0;0;0;0;1_" } },
        ]
    }

    Unfortunately I don't have a solution for CtrlBreak as that's equivalent to calling TerminateProcess and AFAICS you may just as well close the offending tab, right? 🤔

    Implementation

    • Similar to other actions, extend ShortcutActionDispatch with SendInput.
    • Add a TerminalPage::_HandleSendInput method which calls TermControl::SendInput with the command.input value .
    • Add a TermControl::SendInput method which calls TermControl::_SendInputToConnection with the given input value.

    Future extension

    The above solution is very technical, but IMO sufficient for an initial implementation and can still be extended later on.
    For instance the Win32 key sequences could also be represented with a JSON object instead.

    ❤️React with ❤️4Reacted by Patrick Meinecke, damnskippy, sean7130 and Jeff Wang

    🚀React with 🚀3Reacted by Patrick Meinecke, damnskippy and Jeff Wang
19. zadjii-msft commented on Aug 10, 2020

    

    Mike Griese (zadjii-msft)

    on Aug 10, 2020

    Member

    More actions

    Thoughts off the top of the dome:

    • I think we'll need \u001b to be the encoding for escape (for json's sake). I don't love that, but I think json will explode on \x1b
    • As far as implementation is concerned, I think it might be easier to just expose TermControl::SendInput(hstring input) as a method projected off of the TermControl class, rather than return a tuple from TryKeyChord. Then, just have TerminalPage actually send the string to the control, kinda like it handles paste or other actions with args:

        void TerminalPage::_HandleSendInput(const IInspectable& /*sender*/,
                                            const TerminalApp::ActionEventArgs& args)
        {
            if (const auto& realArgs = args.ActionArgs().try_as<TerminalApp::SendInputArgs>())
            {
                const auto termControl = _GetActiveControl();
                args.Handled(termControl.SendInput(realArgs.Input()));
            }
        }

    The implementation of SendInput would be as easy as you suggest - the contents of realArgs.Input() are directly given to TermControl::_SendInputToConnection.

    I'm totally on board with this, thanks for the writeup! I'll throw you on the Assigned To line 😉

    🎉React with 🎉3Reacted by Patrick Meinecke, damnskippy and Jeff Wang
20. Mike Griese (zadjii-msft)

    assigned

    Leonard Hecker (lhecker)

    on Aug 10, 2020
21. lhecker commented on Aug 10, 2020

    

    Leonard Hecker (lhecker)

    on Aug 10, 2020

    Member

    More actions

    Aww... I always thought WT uses JSON5, but it seems it's using JSONC. (JSON5 supports \xNN escape codes.) *insert comment about using YAML here* 😄

    Thanks Mike Griese (@zadjii-msft)! I wasn't aware about AppKeyBindings::SetDispatch and how it integrates into TerminalPage.
    I've edited my proposal above to use unicode escape codes and changed the implementation section.
22. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Aug 11, 2020
23. ghost closed this as completedin #7249on Aug 12, 2020
24. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Aug 12, 2020
25. ghost added a commit that references this issue on Aug 12, 2020

    Fixed #3799: Introduce sendInput command (#7249)

    ...

    This issue will close once commit a2721c1 is merged into the 'main' branch.

    a2721c1
26. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Aug 12, 2020