Activity

1. Don-Vito

   added

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   on Nov 18, 2020
2. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Nov 18, 2020
3. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Nov 18, 2020
4. zadjii-msft commented on Nov 18, 2020

   

   Mike Griese (zadjii-msft)

   on Nov 18, 2020

   Member

   More actions

   I'll be danged, I could have sworn I had already filed a task for this.

   Ideas:

   • I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the toggleCommandPalette(mode=commandline) keybinding, it'll pop you directly into commandline mode? (with Enable shortcut while CommandPalette is open #8044) (and vice versa)
   • Action and commandline mode definitely, tab search maybe? I suppose { action: toggleCommandPalette, mode: tabSearch } doesn't really make sense now does it.
5. Mike Griese (zadjii-msft)

   added

   Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssues pertaining to the user interface of the Console or Terminal

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   and removed

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   on Nov 18, 2020
6. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Nov 18, 2020
7. Mike Griese (zadjii-msft)

   added this to the Terminal v2.0 milestone on Nov 18, 2020
8. DHowett commented on Nov 18, 2020

   

   Dustin L. Howett (DHowett)

   on Nov 18, 2020

   Member

   More actions

   I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

   👍React with 👍1Reacted by Mike Griese

   😄React with 😄1Reacted by Don-Vito
9. Don-Vito commented on Nov 18, 2020

   

   Don-Vito

   on Nov 18, 2020

   Last edited by Don-Vito

   ContributorAuthor

   More actions

   I'll be danged, I could have sworn I had already filed a task for this.

   Ideas:

   * I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the `toggleCommandPalette(mode=commandline)` keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa)
   
   * Action and commandline mode definitely, tab search maybe? I suppose `{ action: toggleCommandPalette, mode: tabSearch }` doesn't _really_ make sense now does it.
   

   Mike Griese (@zadjii-msft) - I believe that:

   • toggleCommandPalette(mode=commandline) - should work from everywhere (even if the window is minimized and the PC is hibernated)
   • same for toggleCommandPalette(mode=commandline)
   • while toggleCommandPalette() with no mode specified should rotate through the modes (closed->action->command line).

   WDYT?
10. Don-Vito commented on Nov 18, 2020

    

    Don-Vito

    on Nov 18, 2020

    ContributorAuthor

    More actions

    I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

    Yep.. that was a bad idea, especially since we already have a tabSeach binding...
11. Don-Vito

    changed the title [-]Allow binding a shortcut to openning CommandPalette in the Command Line Mode[/-] [+]Make the Command Line Mode easier to access[/+] on Nov 18, 2020
12. Dustin L. Howett (DHowett)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Nov 20, 2020
13. Don-Vito commented on Nov 23, 2020

    

    Don-Vito

    on Nov 23, 2020

    ContributorAuthor

    More actions

    I'll be danged, I could have sworn I had already filed a task for this.

    Mike Griese (@zadjii-msft) - I found it.. in the form of TODO 😆

     void TerminalPage::_HandleToggleCommandPalette(const IInspectable& /*sender*/,
                                                       const ActionEventArgs& args)
        {
            // TODO GH#6677: When we add support for commandline mode, first set the
            // mode that the command palette should be in, before making it visible.
            CommandPalette().EnableCommandPaletteMode();
            CommandPalette().Visibility(CommandPalette().Visibility() == Visibility::Visible ?
                                            Visibility::Collapsed :
                                            Visibility::Visible);
            args.Handled(true);
        }
    
14. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Nov 24, 2020
15. Mike Griese (zadjii-msft)

    added

    Area-CmdPalCommand Palette issues and featuresCommand Palette issues and features

    on Dec 1, 2020
16. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Dec 3, 2020
17. ghost closed this as completedin f072eafon Dec 3, 2020
18. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Dec 3, 2020
19. microsoft

    deleted a comment from on Dec 3, 2020
21. Comzyh (comzyh)

    added a commit that references this issue on Feb 25, 2024

    Add launchMode parameter to ToggleCommandPalette action (microsoft#8382)

    ...

    f072eaf