Skip to content

Provide realtime commandline parsing feedback in the commandline mode of the command palette #7284

Closed

Description

Follow up to: Command Palette: Add support for commandline mode #6677

Something that looks like:
image

but like, with the error message from parsing it.

We've gotta move the ThrottledFunc from TerminalControl up to the WinRTUtils so TerminalApp can use it to debounce filter text changed events.

            <StackPanel
                Padding="16"
                Visibility="Visible"
                Grid.Row="3">
                <TextBlock
                    Foreground="Red"
                    x:Name="_commandlineErrorText"
                    Text="Failed to parse commandline. Error was:">
                </TextBlock>
                <TextBlock
                    Padding="16, 0, 0, 0"
                    x:Name="_commandlineErrorText"
                    Text="Foo is not a commandline">
                </TextBlock>
            </StackPanel>

Activity

  1. added
    Help WantedWe encourage anyone to jump in on these.
    Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    on Aug 13, 2020
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 13, 2020
  3. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 15, 2020
  4. ghost added
    In-PRThis issue has a related PR
    on Dec 16, 2020
  5. ghost closed this as completedin #8515on Dec 16, 2020
  6. ghost removed
    In-PRThis issue has a related PR
    on Dec 16, 2020
  7. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Dec 16, 2020
  8. ghost added a commit that references this issue on Dec 16, 2020
    22d43a4
  9. added a commit that references this issue on Jan 28, 2021
    395d29c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-CmdPalCommand Palette issues and featuresArea-UserInterfaceIssues pertaining to the user interface of the Console or TerminalHelp WantedWe encourage anyone to jump in on these.Issue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions