Command palette search results should bold the matching text #6646

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Jun 23, 2020
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jun 23, 2020
3. Mike Griese (zadjii-msft)

   added

   Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssues pertaining to the user interface of the Console or Terminal

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Priority-3A description (P3)A description (P3)

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   on Jun 23, 2020
4. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jun 23, 2020
5. Mike Griese (zadjii-msft)

   added

   Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.

   on Jun 23, 2020
6. Mike Griese (zadjii-msft)

   added this to the Terminal Backlog milestone on Jun 23, 2020
7. DHowett commented on Jun 23, 2020

   

   Dustin L. Howett (DHowett)

   on Jun 23, 2020

   Member

   More actions

   If we're using TextBlocks we can just fill them with Runs generated at runtime 😄
8. DHowett commented on Jun 23, 2020

   

   Dustin L. Howett (DHowett)

   on Jun 23, 2020

   Member

   More actions

   

   <TextBlock FontFamily="Segoe UI" FontSize="32">
     <Run FontWeight="Bold">N</Run><Run>ew</Run> <Run FontWeight="Bold">T</Run><Run>ab</Run>
   </TextBlock>
9. zadjii-msft commented on Jun 23, 2020

   

   Mike Griese (zadjii-msft)

   on Jun 23, 2020

   MemberAuthor

   More actions

   Yes, that's easy enough, but then we need to hook up a lot more XAML - the Palette knows which characters need to be highlighted, so it would need to set that on each of the commands in the match list, then each of those guys would need to return a Run instead of just a string.

   It's not impossible, but it's a lot more XAML binding than anything I've done
10. Dustin L. Howett (DHowett)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Jun 25, 2020
11. DHowett commented on Jun 25, 2020

    

    Dustin L. Howett (DHowett)

    on Jun 25, 2020

    Member

    More actions

    Mind if I bump this one into 2.0? If you don't get to it, I'd like to. 😄
12. Mike Griese (zadjii-msft)

    removed this from the Terminal Backlog milestone on Jun 25, 2020
13. 4 remaining items

    Load more

14. Don-Vito commented on Oct 19, 2020

    

    Don-Vito

    on Oct 19, 2020

    Contributor

    More actions

    Dustin L. Howett (@DHowett), Mike Griese (@zadjii-msft) - so this was planned to be a nice warmup exercise for Saturday morning. This was a bad decision 😄.. aka how to ruin a half of your weekend..

    • Defining a model that instead of a name stores a vector of matched and not matched segments - easy
    • Now let's bind it to the runs - the WinRT Textblock::Inlines are not bindable (ouch)
    • No problem, let's register an attached property and create runs in code behind - coded everything (even with nice converter), XAML complains on the binding. Reading WinRT docs (ouch 2):
      
    • Ha, good luck defining imperatively dynamic context without tons of code-behind. No problem, I will simply create a custom control. WinRT TextBlock is sealed (ouch 3)
    • Found myself writing a User Control 😞

    On a positive side, it work.. on a negative I need to do a lot of cleanups before this worth a PR
    

    🚀React with 🚀1Reacted by Mike Griese
15. DHowett commented on Oct 19, 2020

    

    Dustin L. Howett (DHowett)

    on Oct 19, 2020

    Member

    More actions

    Hey! I worked on this for a bit too, actually, during a hackathon! I ended up binding the content of a Border to a property that produces a TextBlock itself with its own inline runs constructed at runtime.

    I’ve been meaning to put it up for review, but I can hold off so we don’t have conflicting changes.

    Thanks for working on this!
16. Don-Vito commented on Oct 19, 2020

    

    Don-Vito

    on Oct 19, 2020

    Contributor

    More actions

    Dustin L. Howett (@DHowett) - I kinda enjoyed 😄 . In any case please let me know if you believe it is something I should continue to productize - since if you have a working solution than probably we can skip mine.

    BTW, I am not complaining and not regretting anything, but consider removing "help wanted" - I've seen some additional items, that were marked as "help wanted" but were at different stages of implementation.
17. DHowett commented on Oct 19, 2020

    

    Dustin L. Howett (DHowett)

    on Oct 19, 2020

    Member

    More actions

    That’s a very good call (about not keeping the help tag on things we start working on). I expect your solution is better than mine—after all, mine was little more than a hack—so I’d love to see you finish it. A label that can highlight specific ranges is a very useful general-purpose UserControl.
18. Don-Vito commented on Oct 19, 2020

    

    Don-Vito

    on Oct 19, 2020

    Contributor

    More actions

    Dustin L. Howett (@DHowett) - from what I've learnt observing this community is that your "hacks" are much better than the best contribution I can do! 😄 In any case will continue to productize it during this week (it is in a bad shape, as I didn't work with neither C++, nor XAML in the last 8 years).
19. zadjii-msft commented on Oct 19, 2020

    

    Mike Griese (zadjii-msft)

    on Oct 19, 2020

    MemberAuthor

    More actions

    Don-Vito I love it! Looking forward to the PR ☺️
20. Mike Griese (zadjii-msft)

    removed

    Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.

    on Oct 19, 2020
21. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Oct 20, 2020
22. Mike Griese (zadjii-msft)

    modified the milestones: Terminal v2.0, Terminal v1.5 on Nov 5, 2020
23. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Nov 6, 2020
24. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Nov 6, 2020
25. Dustin L. Howett (DHowett)

    closed this as completedin 1aff3bcon Nov 6, 2020
27. Comzyh (comzyh)

    added a commit that references this issue on Feb 25, 2024

    Bold matching text in the command palette (microsoft#7977)

    ...

    This issue will close once commit 1aff3bc is merged into the 'main' branch.

    1aff3bc