Command palette goes to the top when you go back (<) from a submenu #13457

Activity

1. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Jul 7, 2022
2. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jul 7, 2022
3. zadjii-msft commented on Jul 7, 2022

   

   Mike Griese (zadjii-msft)

   on Jul 7, 2022

   Member

   More actions

   Hmm this is in #5400, I'm pretty sure it's a full issue somewhere too

   The "go back" button should pop only one layer of the stack, not go all the way back to the root (#8051 (comment))
4. vefatica commented on Jul 7, 2022

   

   Vincent Fatica (vefatica)

   on Jul 7, 2022

   Author

   More actions

   I guess that's a matter of terminology. The actual behavior and my desired behavior both go back to the command palette. It's the position in the command palette after going back that concerns me ... back to the beginning of the command palette or back to where I was.
5. Mike Griese (zadjii-msft)

   added

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   Issue-TaskIt's a feature request, but it doesn't really need a major design.It's a feature request, but it doesn't really need a major design.

   Priority-3A description (P3)A description (P3)

   good first issueThis is a fix that might be easier for someone to do as a first contributionThis is a fix that might be easier for someone to do as a first contribution

   Area-CmdPalCommand Palette issues and featuresCommand Palette issues and features

   on Jul 8, 2022
6. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jul 8, 2022
7. Mike Griese (zadjii-msft)

   added

   Help WantedWe encourage anyone to jump in on these.We encourage anyone to jump in on these.

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jul 8, 2022
8. ghost removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Jul 8, 2022
9. Mike Griese (zadjii-msft)

   added this to the Backlog milestone on Jul 8, 2022
10. Mike Griese (zadjii-msft)

    removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Jul 8, 2022
11. ghost added

    Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

    on Jul 8, 2022
12. JerBast commented on Jul 13, 2022

    

    Jeroen (JerBast)

    on Jul 13, 2022

    Contributor

    More actions

    Mike Griese (@zadjii-msft), I would be happy to work on this as my first contribution to this repo (if possible). I assume the desired result is to focus the filtered view to the previously selected item when returning from a nested collection?

    
13. zadjii-msft commented on Jul 13, 2022

    

    Mike Griese (zadjii-msft)

    on Jul 13, 2022

    Member

    More actions

    That's what I would do, yea! Lemme know if you have any questions. This line:

    terminal/src/cascadia/TerminalApp/CommandPalette.cpp

    Line 539 in 574a72b

    _nestedActionStack.Clear();

    is where I'd start ☺️
14. ghost added

    In-PRThis issue has a related PRThis issue has a related PR

    on Jul 14, 2022
15. ghost closed this as completedin #13504on Jul 19, 2022
16. ghost added a commit that references this issue on Jul 19, 2022

    Make cmd palette 'go back' button return to previously selected action (

    ...

    This issue will close once commit 0337869 is merged into the 'main' branch.

    0337869
17. ghost removed

    In-PRThis issue has a related PRThis issue has a related PR

    on Jul 19, 2022
18. ghost added

    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Fix is checked in, but it might be 3-4 weeks until a release.

    on Jul 19, 2022
20. vefatica commented on Sep 13, 2022

    

    Vincent Fatica (vefatica)

    on Sep 13, 2022

    Author

    More actions

    I just got this one:

    "Microsoft.WindowsTerminalPreview_Win10_1.16.2523.0_8wekyb3d8bbwe.msixbundle"

    or maybe it's this one:

    WindowsTerminalPreview 1.16.2209.09003

    Is that one Windows Terminal Preview v1.16.252?

    It has too many version descriptions!

    The back button works as desired. I didn't mention it earlier but I'd expect Esc to do the same thing (i.e., go back) but it just closes the command palette.