Skip to content

Add "recent commands' to Command Palette in commandline mode #8296

Closed

Description

@Don-Vito

Description of the new feature/enhancement

The idea is to store the history of the recent commands dispatched from command palette in command line mode. This history will be presented below the search bar. Typing in the search bar will filter the relevant history items (similar to the behavior we already have with filtering commands in action mode).

image

Usually when I use command palette in the command line mode I do it to run the same commands.
This feature will save me a lot of typing and prevent typos.

Proposed technical implementation details (optional)

I am not sure what is the best place to store the history, and what are the security concerns if exist.
We can start with storing the history in memory for the current session.

Activity

  1. added
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Nov 16, 2020
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 16, 2020
  3. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 16, 2020
  4. skyline75489 commented on Nov 17, 2020

    @skyline75489
    Collaborator

    I like this! VSCode will show recent commands history in its command palette and I found it useful.

  5. zadjii-msft commented on Nov 17, 2020

    @zadjii-msft
    Member

    dang this is a good idea

    We could certainly start with work with just stashing the recently used commands in memory while a window is open, and then once #7972 is implemented, we could actually write the mru list to disk and load it from there.

    I'll stick this in #5400. Thanks!

  6. added
    Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    and removed
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Nov 17, 2020
  7. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Nov 17, 2020
  8. Don-Vito commented on Nov 17, 2020

    @Don-Vito
    ContributorAuthor

    Mike Griese (@zadjii-msft) - then I would like to work on this 😊

  9. zadjii-msft commented on Nov 17, 2020

    @zadjii-msft
    Member

    Go for it!

  10. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Nov 17, 2020
  11. ghost added
    In-PRThis issue has a related PR
    on Nov 18, 2020
  12. Don-Vito commented on Nov 18, 2020

    @Don-Vito
    ContributorAuthor

    Implemented in-memory, MRU list (not set) of 10 (hard-coded).
    There is no auto-completion, the history entries get filtered out, however-to invoke the entry you need to select the item:
    CommandHistory2

  13. ghost removed
    In-PRThis issue has a related PR
    on Nov 25, 2020
  14. ghost closed this as completedin 274f5a7on Nov 25, 2020
  15. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions