Skip to content

[Usable-Command Palette]-Keyboard shortcuts are not included in the sub menu of New Tab list item. #7912

Closed

Description

@DasaradhaKamjula

User Experience:
Shortcuts that are provided inside dropdown for these submenu controls should be appended in sub menu too. Visual and screen reader user experience should be consistent through out the app .

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for New tab command in the search field
4.Navigate to New Tab list item having sub menu and activate it .
5.verify whether the shortcuts are appended with the list items in New tab are not.

Actual:
Keyboard shortcuts are not included in the sub menu of New Tab list item.

Expected:
Keyboard shortcuts should be included in the sub menu of New Tab list item like they are included in the drop down of windows terminal for the same list items.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B64DD7C5C-AA62-4D53-886E-BCAEE5341C01%7D&file=Guideline%20101%20Recommended%20Assistive%20Technology%20Tools%20for%20MAS%20Testing%20of%20Microsoft%20Digital%20Properties_v3.docx&action=default&mobileredirect=true

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 13, 2020
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 13, 2020
  3. zadjii-msft commented on Oct 13, 2020

    @zadjii-msft
    Member

    This is by design, the sub-commands of the "New tab..." command only have shortcut text if the user has a keybinding specifically for that action. Note that there's a difference between the actions specified by

    { "command": { "action": "newTab", "index": 0 }, "keys": "ctrl+shift+1" },

    and

    { "command": { "action": "newTab", "profile": "profile0" }, "keys": "ctrl+shift+1" }

    Even if "profile0" is the first profile the user has. If the user has the second action in their settings, the shortcut text will appear for the nested menu item:

    image

  4. added
    Resolution-By-DesignIt's supposed to be this way. Sometimes for compatibility reasons.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 13, 2020
  5. zadjii-msft commented on Aug 19, 2021

    @zadjii-msft
    Member

    Chandresh1007 Priyanka-Chauhan123 DasaradhaKamjula Since this is by design, can we close this issue?

  6. ghost added
    No-Recent-ActivityThis issue/PR is going stale and may be auto-closed without further activity.
    on Aug 23, 2021
  7. Priyanka-Chauhan123 commented on Aug 24, 2021

    @Priyanka-Chauhan123
    Collaborator

    Agree with the above comments as the shortcuts are appearing for the nested menu items and closing this bug.

  8. ghost removed
    No-Recent-ActivityThis issue/PR is going stale and may be auto-closed without further activity.
    on Aug 24, 2021
  9. ghost removed
    Needs-Author-FeedbackThe original author of the issue/PR needs to come back and respond to something
    on Jun 23, 2022
  10. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jun 23, 2022
  11. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A11yTTValidatedYet another label for the a11y folks. They want so many. So so many.A11yUsableAccessibility trackingArea-CmdPalCommand Palette issues and featuresArea-UserInterfaceIssues pertaining to the user interface of the Console or TerminalFixedIssues assigned by the accessibility team that have been fixed.HCL-E+DAccessibility trackingHCL-WindowsTerminalAccessibility trackingImpact-ComplianceIt gotta be this way.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-By-DesignIt's supposed to be this way. Sometimes for compatibility reasons.WindowsTerminal_Win32

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions