Repository navigation
[No QA] Consolidated help docs: new-expensify/reports-and-expenses - #101959
stephanieelliott wants to merge 42 commits into
Conversation
…rts-and-expenses
…rts-and-expenses
…rts-and-expenses
…rts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
…orts-and-expenses
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **Delete an expense**: Only the member who created that specific expense. | ||
|
|
||
| To edit expenses in Approved or Paid reports, a Workspace Admin will need to unapprove the report first. The one exception is receipts: a Workspace Admin can attach or replace a receipt on an expense in an Approved report without unapproving it. [Learn how to attach or replace a receipt on an Approved report](/articles/new-expensify/reports-and-expenses/Attach-and-edit-receipts-on-expenses). | ||
| To edit expenses in Approved or Paid reports, a workspace admin will need to unapprove the report first. |
There was a problem hiding this comment.
Terminology/casing: Use "Workspace Admin" (capitalized) instead of "workspace admin" to match the exact role name used throughout Expensify docs and elsewhere in this same article (per HELPSITE_NAMING_CONVENTIONS.md — match capitalization exactly, be consistent).
|
|
||
| ## Why Don't I See the Reconciliation - All Expenses Export Template? | ||
|
|
||
| The **Reconciliation - All Expenses** template appears only if you're a **Workspace admin** or **Card admin** of a workspace that has company cards or the Expensify Card enabled. If you don't see it, confirm your role on the workspace and that a card product is enabled. |
There was a problem hiding this comment.
Casing: "Workspace admin" should be "Workspace Admin" to match the exact role label used consistently in the docs (HELPSITE_NAMING_CONVENTIONS.md — match capitalization exactly, be consistent). Confirm "Card admin" matches its exact UI/role casing as well.
| Suggestion: Show the bulk actions bar at the bottom of the Reports search page with the "Duplicate reports" option visible after selecting multiple reports. | ||
| Location: After step 3 (web). | ||
| Purpose: Helps the user identify the bulk duplicate option in the dropdown. | ||
| Purpose: Helps the user identify the bulk duplicate option in the bar. |
There was a problem hiding this comment.
Terminology: Use "member" instead of "user" to match Expensify's standard audience term (Member, not User).
| Suggestion: Show the bulk actions bar at the bottom of the Expenses page with the "Duplicate expenses" option visible after selecting multiple expenses. | ||
| Location: After step 4. | ||
| Purpose: Helps the user identify the bulk duplicate option in the dropdown. | ||
| Purpose: Helps the user identify the bulk duplicate option in the bar. |
There was a problem hiding this comment.
Terminology: Use "member" instead of "user" to match Expensify's standard audience term (Member, not User).
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates 42 upstream doc PRs across the new-expensify/reports-and-expenses folder (28 files, 2 new). The dominant theme is a UI-accurate rewrite of bulk-action guidance: the old "Choose Selected" pattern is replaced with platform-specific instructions for the new web bulk-actions bar (with a More overflow) and the mobile Selected tap. Two well-structured new articles are added (How to Merge Reports, Invite Members to an Expense Report), and several sections are corrected for accuracy (Cancel payment rules, distance rate behavior, report destination logic, Reimbursable edit rules). Overall this is a high-quality, accuracy-improving change. Scores Summary
Key FindingsStrengths:
Issues to address:
Recommendations
Files Reviewed
Note: This is a top-level summary. Terminology/casing items above are the priority follow-ups. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11466c9c99
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - **Open a receipt to view it**: Anyone who can see the expense, including members who cannot edit it. | ||
| - **Attach or replace a receipt on an Approved report**: Only a Workspace Admin. The member who created the expense and the approver must have the report unapproved first (see below). | ||
| - **Delete a receipt on an Approved report, or change any receipt on a Paid report**: Requires the report to be unapproved first (see below). | ||
| - **Edit a receipt in an Approved or Paid report**: Requires the report to be unapproved first (see below). |
There was a problem hiding this comment.
This incorrectly tells Workspace Admins that an Approved report must be unapproved before any receipt edit. canEditFieldOfMoneyRequest() explicitly permits an admin to add or replace a receipt on an approved, unsettled report (isAdminChangingReceiptOnApprovedReport), while deletion and Paid reports remain locked. Keep that exception documented so admins do not unnecessarily reopen and resubmit reports.
Useful? React with 👍 / 👎.
| # How to duplicate an expense | ||
|
|
||
| You can create a copy of one or more expenses using **Duplicate expense**. This generates new expenses with the same details as the originals, including the merchant, amount, category, tags, and tax. The date is set to today and receipt images are not copied. An expense that is on a report is copied onto your primary workspace, while an Unreported expense is copied onto your personal space. | ||
| You can create a copy of one or more expenses using **Duplicate expense**. This generates new expenses on your primary workspace with the same details as the originals, including the merchant, amount, category, tags, and tax. The date is set to today and receipt images are not copied. |
There was a problem hiding this comment.
This now claims every duplicate is created on the primary workspace, but duplicateExpenseTransaction() detects an Unreported source and routes it through trackExpense() even when a default workspace exists. Duplicating an unreported expense therefore still creates an unreported personal expense, so this guidance will make users look for the copy in the wrong workspace.
Useful? React with 👍 / 👎.
| 3. Click the green **selected** button, which shows how many reports you selected (for example, **2 selected**). | ||
| 4. Select **Merge reports**. |
There was a problem hiding this comment.
On web, selecting reports renders SearchBulkActionsBarWide as a floating bar at the bottom of the list; the green selected dropdown is only used by the narrow/mobile layout. Because these steps cover both platforms, desktop users cannot follow step 3 as written and should instead choose Merge reports directly from the bottom bar (or More), with the current instruction retained only for mobile.
Useful? React with 👍 / 👎.
| ## Why can't I see Merge reports in the selection menu? | ||
|
|
||
| **Merge reports** only appears when every report you selected can be merged. You won't see it if: |
There was a problem hiding this comment.
The FAQ presents report eligibility as the complete explanation for whether Merge reports appears, but useSearchBulkActions also requires isBetaEnabled(CONST.BETAS.REPORT_MERGE). A user without that beta will never see the action even when every listed condition is satisfied, so the availability prerequisite should be included here.
Useful? React with 👍 / 👎.
| 2. Click the report with the expense(s) you want to move. | ||
| 3. Click the checkbox next to each expense you want to move. | ||
| 4. Click the green **1 selected** button > **Move to report**. The count in the button label matches the number of expenses you selected. | ||
| 5. Choose a destination report, select **Create report** to create a new report, or select **Remove from report** to move the expenses to your personal space. | ||
|
|
||
| **Note:** A system message records the move in the expense when you move an expense into a submitted report or select **Remove from report**. Moving an expense into a draft report does not add a system message, because a draft report is not yet part of the audit trail. | ||
| 3. Choose the green **selected** button > **Move expense(s)**. |
There was a problem hiding this comment.
The rewritten “move or remove all” flow opens a report and immediately instructs the user to choose the selected button, but no expenses have been selected, so that bulk-action control is not shown. Restore the removed step that checks each expense—or explicitly instruct the user to select all—before invoking Move expense(s).
Useful? React with 👍 / 👎.
| 4. Select **Selected** at the top. | ||
| 5. Select **Export**. |
There was a problem hiding this comment.
This new workflow covers web and mobile but still directs users to Selected at the top. The wide Spend layout now exposes bulk actions in the floating bottom bar and has no such top dropdown; only the narrow/mobile layout renders the Selected button. Split this step by platform so web users choose Export from the bottom bar (or More) and mobile users tap Selected.
Useful? React with 👍 / 👎.
1 participant
Summary
Consolidates 42 help doc PRs for
new-expensify/reports-and-expensesinto a single reviewable PR.Included PRs
Test plan