Repository navigation
Conversation
Co-authored-by: Cong Pham <suneox@users.noreply.github.com>
40 tasks done
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Disable Reimbursable in Edit multiple when a selected expense is locked (
Expensify/App#101090).That PR added
disabled: isFieldDisabledForAnyTransaction(CONST.EDIT_REQUEST_FIELD.REIMBURSABLE)to the Reimbursable row in the Edit multiple panel, so the row is now greyed out when any selected expense has a locked reimbursable value — for example an expense on a report closed with Mark as done on a Submit and Close Workspace. Before the fix the row stayed tappable and the change was silently dropped.docs/articles/new-expensify/reports-and-expenses/Edit-Expenses.mddocumented the general rule ("If editing is not allowed on a field for any of the selected expenses, that field will not be available for editing") but never mentioned Reimbursable, so a user who hits the greyed-out row has nothing to search for. This PR makes that case explicit:areSelectedTransactionsReimbursablehides the row, the newdisabledprop greys it out — so the article keeps them separate rather than merging them.keywordsandinternalScopefor retrieval on phrases like "reimbursable greyed out".UI labels used in the article (Reimbursable, Edit multiple, Mark as done, Rules, Spend, Expenses, Done, Paid) were checked against
src/languages/en.tsfor exact capitalization. No new article was created and no existing headings were renamed, so the structure still satisfiesdocs/HELP_AUTHORING_GUIDELINES.md(single#title plus# FAQ, question-form FAQ headings) anddocs/HELPSITE_NAMING_CONVENTIONS.md(bold, UI-exact labels, no quoted labels).npm run spell-changedpasses on the changed file.Fixed Issues
$
PROPOSAL:
Documentation-only follow-up, so there is no issue for this PR to close. Source PR: Disable Reimbursable in Edit multiple when a selected expense is locked (
Expensify/App#101090).Tests
// TODO: The human co-author must confirm the wording matches current behavior before marking this PR as "ready for review".
Suggested check, using the steps from
Expensify/App#101090:Offline tests
Not applicable. This PR only changes Markdown in
docs/articles, which has no offline behavior.QA Steps
// TODO: The human co-author must fill this out before marking this PR as "ready for review". This PR changes help site Markdown only, so it may qualify for [No QA].
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@suneox, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.