Skip to content

[No QA] Docs updates for E/A#99132 expense type, reimbursable status, and card feed name - #99802

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsExpenseViewTypeAndCardFeed
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsExpenseViewTypeAndCardFeed

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Documentation-only follow-up for #99132, which changed what the expense details show in New Expensify.

Nothing on the help site described the single-expense detail view, so no article stated the old behavior — these are gaps rather than corrections. Two articles are updated:

docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md

This article already ends its expense table section with "Clicking a row opens the full expense details in a side panel (web) or details screen (mobile)" but never said what those details contain. Two new sections pick up from there:

  • What the Amount row shows in the expense details — documents the new Amount • [expense type] • [reimbursable status] label, lists the expense types, notes that the reimbursable status now shows both Reimbursable and Non-reimbursable (previously only the non-reimbursable case appeared) and only on single-expense reports, and documents Purchase [amount] and Converted [amount] now appearing on their own line under the Amount row instead of inline.
  • What the Card row shows on an imported card expense — documents that commercial card feed expenses now show {feed name} - {last four} instead of the masked card number, that a custom feed name is used when set, and that the workspace Company cards list is unaffected.

internalScope was also added to the front matter, which the article was missing.

docs/articles/new-expensify/connect-credit-cards/Configure-Company-Card-Settings.md

Adds one sentence under the Card feed name setting explaining that this name now surfaces on each imported expense, since that is the setting admins use to control the new label.

Verification

Label text was verified against the live web UI rather than inferred from the diff:

  • Separator is • (U+2022, CONST.DOT_SEPARATOR), not · — byte-checked against src/CONST/index.ts.
  • Amount • Cash • Reimbursable, and Amount • Cash • Non-reimbursable after toggling the Reimbursable switch off.
  • Expense detail row label is exactly Reimbursable.
  • Workspace settings menu item is exactly Company cards.

Expense type strings were taken from getDetailedExpenseTypeTranslationKey and src/languages/en.ts: Cash, Distance, Per diem, Time, Pending, Expensify Card, Company card, Personal card, Travel Card. The Visa cards - 1234 example matches the getCommercialFeedCardDescription unit test.

The feed settings page itself could not be reached in the test environment — Add cards requires a magic-code account validation step, so the Card feed name label is sourced from the existing article rather than re-verified live.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: all new headings are ##, task-based and start with a question word, UI labels are bolded and match the UI exactly, and the single cross-link uses a relative path with descriptive anchor text.

Fixed Issues

$ #98913
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…on the expense view

Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 28, 2026 21:57
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 28, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#99132 expense type, reimbursable status, and card feed name [No QA] Docs updates for E/A#99132 expense type, reimbursable status, and card feed name Aug 28, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

@stephanieelliott

Copy link
Copy Markdown
Contributor

@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

@mukhrr bump on this!

@MelvinBot

MelvinBot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Web test steps verification results: ✅ pass

While mukhrr gets to this, I re-verified the two articles against the current code and the live web UI. Every claim in the diff is accurate — all nine expense-type strings, the Amount • [type] • [reimbursable status] label, the single-expense-only gate on the status, the Purchase/Converted lines, and the {feed name} - {last four} Card row all match what the app does today. I did not mark this ready for review — the Tests and QA Steps sections still need the human co-author, and mukhrr should still confirm.

EUR expense details showing Amount • Cash / €50.00 / Converted $58.14 on separate lines

Step Status
Amount row label reads exactly Amount • Cash • ReimbursableAccessible label: Amount • Cash • Reimbursable, $25.00
Expense details showing Amount • Cash • Reimbursable and Reimbursable toggle on
✅
Row labelled exactly Reimbursable with a toggleSnapshot node: [switch] "Reimbursable"
Reimbursable toggle row
✅
Label reads exactly Amount • Cash • Non-reimbursable after toggling offAccessible label: Amount • Cash • Non-reimbursable, $25.00; audit log confirmed the change
Expense details showing Amount • Cash • Non-reimbursable and toggle off
✅
Converted [amount] appears on its own line under the Amount rowEUR expense in a USD workspace: Converted $58.14 renders on its own line beneath €50.00. Screenshot-only evidence — it isn't exposed as a distinct accessibility node.
EUR expense details showing Amount • Cash / €50.00 / Converted $58.14 on separate lines
✅
Code verification — all 7 doc claims, plus 4 optional accuracy nits

All strings byte-checked against en.ts; all nine expense types match the article exactly, including Per diem, Company card, Personal card, and Travel Card capitalization. getDetailedExpenseTypeTranslationKey can return only those nine, so the list is exhaustive.

Claim Verdict Evidence
Amount • [type] • [status] with CONST.DOT_SEPARATOR (U+2022) ✅ MoneyRequestView.tsx:762-764, CONST/index.ts:6848
Nine expense types, exact strings ✅ TransactionUtils/index.ts:312-330
Reimbursable / Non-reimbursable, single-expense reports only ✅ MoneyRequestView.tsx:761-764, MoneyRequestReportUtils.ts:123-129
Purchase / Converted on their own line ✅ MoneyRequestView.tsx:737-744, rendered via FormHelpMessage
Card row shows {feed name} - {last four}; custom name wins ✅ CardUtils.ts:293-304, CardUtilsTest.ts:3446-3501
Card row only on card-imported expenses ✅ MoneyRequestView.tsx:354-358
Workspace Company cards list still shows the masked number ✅ WorkspaceCompanyCardsTableRow.tsx:93 — untouched by #99132

Optional polish — none of these make the article wrong:

  1. Extra label segments. Between the type and the status the code can insert • Canceled, • Approved, • Paid with Expensify, or • Split (MoneyRequestView.tsx:745-757), so a real label can read Amount • Company card • Canceled • Reimbursable.
  2. Purchase and Converted are mutually exclusive — they share one variable, and Converted requires !isFromCardImport. "Two additional amounts can appear" could be read as both at once. Consider "One of two additional amounts…".
  3. Purchase isn't company-card-specific. The gate is isFromCardImport, which includes Expensify Card and personal-card imports.
  4. Amex gl1205 feeds are excluded. CUSTOM_FEED_PREFIXES is cdf/vcf/gl1025 only, so an Amex feed on gl1205 still shows the masked number — the "Visa, Mastercard, or American Express" phrasing slightly over-promises.

view run · no recording available

@stephanieelliott stephanieelliott self-assigned this Sep 5, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

@MelvinBot you shared a screenshot of the UI change in this comment, which was very helpful. If I wanted you to take the same action on another PR, how should I prompt you?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Ask me to verify the change in the running app. The screenshots come from the browser/emulator tester I spawn, and I only spawn it when the request is about testing UI behavior — not when it's about reviewing the diff.

Prompts that work:

  • @MelvinBot test this PR on web and post screenshots of the UI change
  • @MelvinBot run the test steps in this PR and show a screenshot for each step
  • @MelvinBot verify in the app that the Amount row reads "Amount • [type] • [status]"

A few things that make the output better:

  • Name what to look at. Each thing you list becomes one assertion, and each assertion comes back as its own table row with its own screenshot. Vague asks get fewer screenshots.
  • "Run the test steps in this PR" makes me read the Tests/QA section and use each step verbatim as an assertion.
  • Say web or Android if you care which. Otherwise I default to web.
  • It only works when there's something to look at in NewDot. A backend-only or pure-docs PR with no matching UI won't produce screenshots.
  • Testing never pushes code or marks the PR ready for review — ask for those separately.

Heads up: browser control wasn't available on this run, so I couldn't demo it live here.


view run

@stephanieelliott

Copy link
Copy Markdown
Contributor

No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants