Skip to content

[No QA] Docs updates for E/A#100675 deleting every expense in a group - #101378

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-e-a-100675-group-delete
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-e-a-100675-group-delete

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Flag the group's own snapshot entry when a whole-group delete removes it (Expensify/App#100675).

That PR settled what a user sees on the Spend page when they delete expenses inside a grouped search. None of that behavior was documented — How-to-Delete-Expenses.md covered deleting one expense, deleting several expenses, and deleting from a report, but never mentioned groups.

Added two sections to docs/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses.md:

  • ## How to delete every expense in a group on the Spend page — the steps, including that a group row has its own checkbox that selects every expense the group is currently showing.
  • ## What happens after you delete every expense in a group — the four outcomes the PR defines:
    • Delete every expense a group contains → the whole group row leaves the results.
    • Results show fewer expenses than the group contains (a limit: smaller than the group count) → only the selected expenses are deleted, the group stays and collapses, and the expenses that weren't shown are untouched.
    • Offline → the group row stays, shown as pending.
    • Failed delete → the group row comes back.

The truncated-results case is the one worth documenting: it looks like a bug to a member who deletes "everything" and watches the group survive, and it is now deliberate behavior.

Also corrected (pre-existing, not caused by #100675): the article referenced the bulk action button as Selected in three places. The live UI renders it with the selection count — 1 selected, 3 selected — per en.ts, verified in the app. Those three now read X selected, matching the convention already used in Configure-Per-Diem-in-a-workspace.md. Drop this part if you'd rather keep it out of scope — the same stale label appears in other articles and could be swept separately.

All UI labels were verified against the live app: the Spend tab, the Expenses sub-tab, the group row checkbox, the X selected bulk action button, its Delete option, and the confirmation modal's Delete button.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: one # heading plus # FAQ, only ## below it, every new heading task-based and starting with a question word, exact bolded UI labels, and the cross-link placed outside the numbered steps.

Fixed Issues

$ #100122
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

This PR changes documentation only — no application code is touched.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Covers the group-row outcome after a whole-group delete, the truncated-results case where the group stays and collapses, and the offline/failed-delete behavior introduced in #100675. Also corrects the bulk action button label to the exact UI text.

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 16, 2026 20:16
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 16, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#100675 deleting every expense in a group [No QA] Docs updates for E/A#100675 deleting every expense in a group Sep 16, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://94b3a106.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor

No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants