Repository navigation
Conversation
Covers the group-row outcome after a whole-group delete, the truncated-results case where the group stays and collapses, and the offline/failed-delete behavior introduced in #100675. Also corrects the bulk action button label to the exact UI text. Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
40 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://94b3a106.helpdot.pages.dev ⚡️ Updated articles: |
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Flag the group's own snapshot entry when a whole-group delete removes it (
Expensify/App#100675).That PR settled what a user sees on the Spend page when they delete expenses inside a grouped search. None of that behavior was documented —
How-to-Delete-Expenses.mdcovered deleting one expense, deleting several expenses, and deleting from a report, but never mentioned groups.Added two sections to
docs/articles/new-expensify/reports-and-expenses/How-to-Delete-Expenses.md:## How to delete every expense in a group on the Spend page— the steps, including that a group row has its own checkbox that selects every expense the group is currently showing.## What happens after you delete every expense in a group— the four outcomes the PR defines:limit:smaller than the group count) → only the selected expenses are deleted, the group stays and collapses, and the expenses that weren't shown are untouched.The truncated-results case is the one worth documenting: it looks like a bug to a member who deletes "everything" and watches the group survive, and it is now deliberate behavior.
Also corrected (pre-existing, not caused by #100675): the article referenced the bulk action button as Selected in three places. The live UI renders it with the selection count —
1 selected,3 selected— peren.ts, verified in the app. Those three now read X selected, matching the convention already used inConfigure-Per-Diem-in-a-workspace.md. Drop this part if you'd rather keep it out of scope — the same stale label appears in other articles and could be swept separately.All UI labels were verified against the live app: the Spend tab, the Expenses sub-tab, the group row checkbox, the X selected bulk action button, its Delete option, and the confirmation modal's Delete button.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#heading plus# FAQ, only##below it, every new heading task-based and starting with a question word, exact bolded UI labels, and the cross-link placed outside the numbered steps.Fixed Issues
$ #100122
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR changes documentation only — no application code is touched.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.