Repository navigation
Conversation
Co-authored-by: Dilshod Bunyodov <dilshodmackbook-sketch@users.noreply.github.com>
40 tasks done
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Docs-only follow-up to #99689, which changed what the Select all selection count shows on the Reports tab of the Spend page.
Before that PR, choosing Select all on the Reports tab labelled the button with the number of matching expenses. It now labels it with the number of matching reports, which means the button count and the footer Expenses count legitimately differ — for example, 110 selected above a footer reading Expenses: 93. The help site never described either count, so a member seeing two different numbers has nothing to check against. That mismatch is what the linked issues were originally reported as.
This updates
docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md:keywordsmetadata with the select-all and selection-count search phrases.No behavior change and no product code touched.
Label and UI verification: Spend, Reports, and Filters were confirmed against the live web UI. Select all, Select all on this page,
N selected, Total spend, and Expenses were confirmed against the shipped strings insrc/languages/en.tsand their call sites (SearchSelectAllMenu.tsx,SearchPageFooter.tsx) — the test account had no reports, so the multi-select header could not be driven live.Fixed Issues
$ #99689
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate the documented behavior matches the app.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate these changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@dilshodmackbook-sketch, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.