Repository navigation
Conversation
Co-authored-by: I.K. <M00rish@users.noreply.github.com>
|
@M00rish this is the help site follow-up for #98381. I couldn't add you as an assignee — GitHub only allows assigning collaborators of Please review the files changed and confirm they reflect the current behavior. Then post a new comment saying |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot mark this PR as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sakluger |
HelpDot Documentation ReviewOverall AssessmentThis PR is a strong, well-scoped documentation follow-up to #98381. It adds one new article (Invite-Members-to-an-Expense-Report.md) covering the invite-to-expense-report workflow and corrects three inaccuracies in Expense-and-Report-Actions.md. The changes are tightly aligned with the governance files: single workflow per article, complete metadata, task-based headings, UI-exact labels, and clean cross-linking. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0de88e9120
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…s-to-an-Expense-Report.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
| ## How do I invite a member to an expense report? | ||
| ## How do I invite a member to a report? | ||
|
|
||
| On a Draft report, select the report header, select **Members**, then select **Invite member**. Search for the person by name, email, or phone number, select them, then select **Invite**. |
There was a problem hiding this comment.
Vague navigation / missing exact UI label: "select the report header" is a non-deterministic navigation phrase (see HELPSITE_NAMING_CONVENTIONS.md — Prohibited Language and Core UI Referencing Rules; always reference the exact UI label). It also skips a step: the verified path is report header → Details → Members → Invite member (per the PR description), so Details is missing. Consider: "Open the report, select Details, select Members, then select Invite member."
|
|
||
| On a Draft report, select the report header, select **Members**, then select **Invite member**. Search for the person by name, email, or phone number, select them, then select **Invite**. | ||
|
|
||
| Invited members can see every expense on the report and comment, but they aren't added to the workspace or approval workflow. The Invite member option is available to the submitter and Workspace Admins while the report is in Draft status. [Learn how to invite members to an expense report](/articles/new-expensify/reports-and-expenses/Invite-Members-to-an-Expense-Report). |
There was a problem hiding this comment.
Button label not bolded: "The Invite member option" references the UI button Invite member, which must be bold per HELPSITE_NAMING_CONVENTIONS.md (Button Naming Standards — bold all button names). Use "The Invite member option".
Broken cross-link: This links to /articles/new-expensify/reports-and-expenses/Invite-Members-to-an-Expense-Report, but that article does not exist in the repo and is not added in this PR (only this file is changed). Per HELP_AUTHORING_GUIDELINES.md Pre-Publish Validation, cross-links must resolve. Either add the target article in this PR or remove the link.
HelpDot Documentation ReviewOverall AssessmentThis PR makes targeted corrections to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
A preview of your ExpensifyHelp changes have been deployed to https://f7181a29.helpdot.pages.dev ⚡️ Updated articles: |
|
will be handled in #99955 |
Explanation of Change
Help site follow-up for #98381, which made Invite member available on expense reports (previously it only appeared on group chats).
The shipped rules from that PR are: you can invite only while the expense report is in Draft, only if you submitted the report or are a Workspace Admin on that workspace, and never on an archived report or on an expense submitted to an individual. An invited member gains visibility of every expense on the report.
Two changes:
New article —
docs/articles/new-expensify/reports-and-expenses/Invite-Members-to-an-Expense-Report.mdThere was no article covering this workflow, only a one-line FAQ answer. The new article documents who can invite, the step-by-step flow, what an invited member can see, and why the button may be missing.
Corrections —
docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.mdThe existing action table described this feature inaccurately:
Draft and Outstanding reports/All roles. Both are wrong — it is Draft only, and only for the submitter or a Workspace Admin.All UI labels were verified against dev NewDot on web: report header → Details → Members → green Invite member button → Invite members page → green Invite submit button.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md.@M00rish, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #98381
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Docs-only change: no app code is touched. Review the rendered markdown and confirm the described behavior matches the product.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Docs-only change under
docs/articles; no product QA is expected.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari