Repository navigation
Conversation
Co-authored-by: nkdengineer <nkdengineer@users.noreply.github.com>
40 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://016caa8b.helpdot.pages.dev ⚡️ Updated articles: |
3 tasks
stephanieelliott
approved these changes
Sep 27, 2026
3 tasks
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #100468, which hides
has:filter options that can't apply to the current user.After that PR, the expense
has:options Tag, Category, Submitted violation, and Approved violation only appear in the Has filter and in search autocomplete when at least one workspace you belong to has Tags, Categories, or Rules enabled. The help site still describedhas:as always offering those values, so a member with no workspace would look for options that are no longer shown.Changes in
docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md:has:row in the expense operator table to listapproved-violation(it was missing) and to note that some values depend on a workspace feature being enabled.## Why some has: values are not suggested for expensessection mapping each value to the workspace feature that enables it, covering both the search bar and the Has filter under Filters on the Spend page, and stating that hiding a value only affects the suggestions — typed queries and saved searches still work.has:filter.Feature and option labels were taken from the product strings in
src/languages/en.ts(Receipt,Attachment,Tag,Category,Submitted violation,Approved violation,Has) and the More features titles (Categories,Tags,Rules).Fixed Issues
$ #99965
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This is a docs-only change under
docs/articles, so it does not affect app behavior. Please confirm the article text matches the current behavior.Offline tests
N/A — docs-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Docs-only change under
docs/articles— no app behavior changes to QA.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@nkdengineer, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.