Skip to content

[no QA] Docs updates for E/A#100426 manual merchant, date, amount entry in Scan flow - #101136

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-scan-manual-fields
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-scan-manual-fields

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #100426, which added manual Merchant, Date, and Amount entry to the Scan confirmation screen. The help site still described the Scan flow as SmartScan-only, so members had no documentation for the new fields or for the all-or-nothing rule that governs them.

docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md

  • Added How to enter the merchant, date, and amount yourself when scanning a receipt — the steps to reveal the fields behind Show more and fill them in, plus what the Automatic label means.
  • Added What happens when you enter scan details yourself — the all-or-nothing requirement, that clearing a field hands it back to SmartScan, that entered values are final and are not overwritten by the scan, how multi-receipt scans behave, and the cases where manual entry is unavailable (splits, test receipts, moved tracked expenses).
  • Added an FAQ entry for the required-field errors members will hit if they fill in only one of the three fields.
  • Updated keywords and internalScope so the new workflow is retrievable.

docs/articles/new-expensify/reports-and-expenses/Troubleshoot-SmartScan-Issues.md

  • Added an FAQ entry pointing members who want to skip waiting on SmartScan to the new section.

Every UI label was checked against the app rather than paraphrased: Scan, Show more, Merchant, Date, Amount, Automatic, and Create expense. npm run spell-changed passes on both files.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: task-based ## headings only, no ### or deeper, bolded UI labels in Sentence case with no quotation marks, relative cross-links placed outside numbered steps, and the screenshot suggestion left as a non-rendered <!-- SCREENSHOT: --> comment.

@thelullabyy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #93854
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This PR only changes Markdown under docs/articles, so there is no app behavior to test. Please confirm the documented behavior matches what #100426 shipped.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// This PR only changes Markdown under docs/articles and has no runtime impact.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 15, 2026 01:37
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 15, 2026
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#100426 manual merchant, date, amount entry in Scan flow [no QA] Docs updates for E/A#100426 manual merchant, date, amount entry in Scan flow Sep 22, 2026
@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please assign yourself this PR, then close it

@MelvinBot MelvinBot self-assigned this Sep 27, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I assigned myself to this PR, but I couldn't close it. This run's permissions blocked the close command.

To close it, click Close pull request at the bottom of the PR page. You can also retry your request with @MelvinBot.


view run

@stephanieelliott

Copy link
Copy Markdown
Contributor

This doesn't need a help site update, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants