Repository navigation
Conversation
Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
40 tasks done
3 tasks
Contributor
|
@MelvinBot Please assign yourself this PR, then close it |
Contributor
Author
|
I assigned myself to this PR, but I couldn't close it. This run's permissions blocked the close command. To close it, click Close pull request at the bottom of the PR page. You can also retry your request with |
3 tasks
Contributor
|
This doesn't need a help site update, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #100426, which added manual Merchant, Date, and Amount entry to the Scan confirmation screen. The help site still described the Scan flow as SmartScan-only, so members had no documentation for the new fields or for the all-or-nothing rule that governs them.
docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.mdkeywordsandinternalScopeso the new workflow is retrievable.docs/articles/new-expensify/reports-and-expenses/Troubleshoot-SmartScan-Issues.mdEvery UI label was checked against the app rather than paraphrased: Scan, Show more, Merchant, Date, Amount, Automatic, and Create expense.
npm run spell-changedpasses on both files.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: task-based##headings only, no###or deeper, bolded UI labels in Sentence case with no quotation marks, relative cross-links placed outside numbered steps, and the screenshot suggestion left as a non-rendered<!-- SCREENSHOT: -->comment.@thelullabyy, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #93854
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This PR only changes Markdown under
docs/articles, so there is no app behavior to test. Please confirm the documented behavior matches what #100426 shipped.Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// This PR only changes Markdown under
docs/articlesand has no runtime impact.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari