Repository navigation
perf(web): sidebar drags restyle only the sidebar - #17659
maria-rcks merged 8 commits into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 18 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughSidebar resizing now applies frame-by-frame width changes to the gap and container. When dragging finishes, the wrapper receives the final width. Cleanup removes temporary width and transition-duration styles, and changing the sidebar’s open state cancels an active drag. ChangesSidebar resize behavior
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to Sidebar dragging keeps the active layout in sync and commits accepted widths when finished. No actionable merge-blocking risk was identified.
|
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This single-file performance change keeps live drag updates confined to the sidebar elements that need them, then commits the final width through the existing wrapper variable and persistence path. Cancellation and cleanup are handled locally, with no product-default, schema, infrastructure, or static-analysis changes. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Dismissing prior approval to re-evaluate d720801
## What's Changed * feat(web): draft screen project picker is searchable by @juliusmarminge in pingdotgg/t3code#17664 * fix(server): report incomplete transcript usage scans by @maria-rcks in pingdotgg/t3code#15661 * fix(web): every resize-driven layout commits in the same frame by @maria-rcks in pingdotgg/t3code#17656 * fix(web): right panel and terminal drawer follow the pointer while dragging by @maria-rcks in pingdotgg/t3code#17657 * fix(web): terminal drawer keeps its height after the window shrinks by @maria-rcks in pingdotgg/t3code#17658 * perf(web): sidebar drags restyle only the sidebar by @maria-rcks in pingdotgg/t3code#17659 * fix(web): server browser page resizes while the panel is dragged by @maria-rcks in pingdotgg/t3code#17660 * fix(storage): make worktree cleanup work and show why it skipped by @maria-rcks in pingdotgg/t3code#17563 * test(usage): usage service tests keep their state directory until cache writes land by @tris203 in pingdotgg/t3code#17636 * fix(checkpoint): pulls and rebases no longer flood a turn's changed files by @t3dotgg in pingdotgg/t3code#17161 * fix(web): place notification icons after titles by @voltcrash in pingdotgg/t3code#12209 * fix(web): attachments on an open question are visible again by @tiliakoos in pingdotgg/t3code#15537 * fix(web): scale Files tree with interface font size by @Umais-Adeed in pingdotgg/t3code#8011 * fix(server): probe only owned preview listeners by @maria-rcks in pingdotgg/t3code#16687 * fix(chat): surface pending subagent questions on parents by @maria-rcks in pingdotgg/t3code#16634 * fix(web): section header chevrons point up when collapsed by @ZenderGoD in pingdotgg/t3code#14273 * fix(web): timeline divider pill shows a pointer, visible hover and focus ring by @jonesfionn101-dotcom in pingdotgg/t3code#15188 * fix(git): allow creating prs from dirty worktrees by @maria-rcks in pingdotgg/t3code#15625 * docs(install): polish binary install destination phrasing by @ege-arhan in pingdotgg/t3code#15732 * perf(server): keep passive terminal output flowing by @StiensWout in pingdotgg/t3code#17178 * fix(web): stop button icon no longer shifts on hover by @NK-Works in pingdotgg/t3code#16012 * fix(web): add bottom padding to expanded tool panels by @12ya in pingdotgg/t3code#16525 * fix(web): keep incremental highlighter return type portable by @luke2x in pingdotgg/t3code#17259 * fix(web): sidebar "Code" label no longer clips its letter tops by @akbarakma in pingdotgg/t3code#16134 * fix(tests): use POSIX paths for the simulated macOS device host by @Quicksaver in pingdotgg/t3code#17241 * fix(mobile): Android composer keeps the caret in view on AOSP-based keyboards by @bitmvk in pingdotgg/t3code#17492 * test(web): allow cold timeline imports on CI by @lastobelus in pingdotgg/t3code#16608 * fix(mobile): pinch zooms chat images on Android by @AKolenda in pingdotgg/t3code#15047 * fix(web): selected provider ring no longer clipped during panel resize by @jfortez in pingdotgg/t3code#17534 * docs(usage): OpenCode Go limits need a Go API key by @nexxeln in pingdotgg/t3code#15664 * fix(web): improve usage scanning indicator alignment by @AksharP5 in pingdotgg/t3code#15498 * fix(server): print pairing credential expiry as ISO timestamp by @kvnloo in pingdotgg/t3code#14128 * chore(ci): use GPT 6.1 Sol Max for check agents by @ishaanko in pingdotgg/t3code#14312 * fix(mobile): honor requested terminal native architectures by @bompus in pingdotgg/t3code#10709 * fix(server): keep preview browser connected after operation timeouts by @juliusmarminge in pingdotgg/t3code#17693 * fix(web): timeline divider focus ring stays inside the pill by @t3dotgg in pingdotgg/t3code#17702 * perf(desktop): reuse the prepared shell environment in the local backend by @Yash-Singh1 in pingdotgg/t3code#17384 * fix(web): align settings page widths by @diegoarff in pingdotgg/t3code#12158 * test(server): resolve the temp dir before matching the symlinked entrypoint by @ylcn91 in pingdotgg/t3code#9400 * fix(web): keep inline code pills intact when they wrap by @satyalyadav in pingdotgg/t3code#12038 * Revert "chore(ci): use GPT 6.1 Sol Max for check agents" by @maria-rcks in pingdotgg/t3code#17698 * fix(web): show the correct new thread shortcut in command palette by @vaishnavsm in pingdotgg/t3code#8513 * fix(desktop): declare macOS local network usage by @jsilets in pingdotgg/t3code#11922 * docs: add Scoop as Windows installation method by @Mostafa-Ben-Git in pingdotgg/t3code#10509 * fix(server): agents run in their own systemd scopes so an OOM kill spares the server by @t3dotgg in pingdotgg/t3code#17662 * fix(web): welcome wizard says where imported projects come from by @UzEE in pingdotgg/t3code#14584 * fix(web): cite works on responses that end before a tool call by @maria-rcks in pingdotgg/t3code#17713 * fix(desktop): sign Windows native addons by @Lumbreras2306 in pingdotgg/t3code#8206 * fix(server): track resumed subagent follow-ups as separate tasks by @Yash-Singh1 in pingdotgg/t3code#17696 * fix(web): nested corners follow their container's radius by @maria-rcks in pingdotgg/t3code#17695 * feat(web): pr panel actions confirm in place by @maria-rcks in pingdotgg/t3code#17710 * feat(web): reorder right panel tabs by dragging by @eimexdev in pingdotgg/t3code#17730 * fix(azure-devops): list pull requests with token sign-in and check out into worktrees by @maria-rcks in pingdotgg/t3code#17725 * fix(usage): keep one email in two workspaces as two accounts by @maria-rcks in pingdotgg/t3code#17711 * feat(pull-requests): hosts can report edit and resolve permissions per item by @juliusmarminge in pingdotgg/t3code#17667 * perf(server): run Git for Windows' real git.exe, not its launcher by @SunkenInTime in pingdotgg/t3code#17707 * fix(clients): restart continuations show as a T3 Code notice, not another agent's message by @juliusmarminge in pingdotgg/t3code#17723 * fix(mobile): browser picture in picture opens from the header button by @juliusmarminge in pingdotgg/t3code#17731 * feat(source-control): GitCafe lives in @t3tools/source-control-gitcafe by @juliusmarminge in pingdotgg/t3code#17681 * fix(web): add provider wizard no longer shifts sideways while it grows by @flamboh in pingdotgg/t3code#17292 * fix(web): PR search keeps the caret where you type by @flamboh in pingdotgg/t3code#17675 * fix(server): thread PR badges catch up when another environment reads the PR by @flamboh in pingdotgg/t3code#17729 * fix(server): refuse editor paths with line breaks or quotes when the editor is a Windows command shim by @juliusmarminge in pingdotgg/t3code#17749 ## New Contributors * @tiliakoos made their first contribution in pingdotgg/t3code#15537 * @Umais-Adeed made their first contribution in pingdotgg/t3code#8011 * @ZenderGoD made their first contribution in pingdotgg/t3code#14273 * @jonesfionn101-dotcom made their first contribution in pingdotgg/t3code#15188 * @ege-arhan made their first contribution in pingdotgg/t3code#15732 * @NK-Works made their first contribution in pingdotgg/t3code#16012 * @12ya made their first contribution in pingdotgg/t3code#16525 * @luke2x made their first contribution in pingdotgg/t3code#17259 * @akbarakma made their first contribution in pingdotgg/t3code#16134 * @Quicksaver made their first contribution in pingdotgg/t3code#17241 * @bitmvk made their first contribution in pingdotgg/t3code#17492 * @lastobelus made their first contribution in pingdotgg/t3code#16608 * @jfortez made their first contribution in pingdotgg/t3code#17534 * @diegoarff made their first contribution in pingdotgg/t3code#12158 * @ylcn91 made their first contribution in pingdotgg/t3code#9400 * @satyalyadav made their first contribution in pingdotgg/t3code#12038 * @vaishnavsm made their first contribution in pingdotgg/t3code#8513 * @jsilets made their first contribution in pingdotgg/t3code#11922 * @Mostafa-Ben-Git made their first contribution in pingdotgg/t3code#10509 * @UzEE made their first contribution in pingdotgg/t3code#14584 * @Lumbreras2306 made their first contribution in pingdotgg/t3code#8206 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2908...v0.0.46-nightly.20261010.2922 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2922
## What's Changed * feat(web): draft screen project picker is searchable by @juliusmarminge in pingdotgg/t3code#17664 * fix(server): report incomplete transcript usage scans by @maria-rcks in pingdotgg/t3code#15661 * fix(web): every resize-driven layout commits in the same frame by @maria-rcks in pingdotgg/t3code#17656 * fix(web): right panel and terminal drawer follow the pointer while dragging by @maria-rcks in pingdotgg/t3code#17657 * fix(web): terminal drawer keeps its height after the window shrinks by @maria-rcks in pingdotgg/t3code#17658 * perf(web): sidebar drags restyle only the sidebar by @maria-rcks in pingdotgg/t3code#17659 * fix(web): server browser page resizes while the panel is dragged by @maria-rcks in pingdotgg/t3code#17660 * fix(storage): make worktree cleanup work and show why it skipped by @maria-rcks in pingdotgg/t3code#17563 * test(usage): usage service tests keep their state directory until cache writes land by @tris203 in pingdotgg/t3code#17636 * fix(checkpoint): pulls and rebases no longer flood a turn's changed files by @t3dotgg in pingdotgg/t3code#17161 * fix(web): place notification icons after titles by @voltcrash in pingdotgg/t3code#12209 * fix(web): attachments on an open question are visible again by @tiliakoos in pingdotgg/t3code#15537 * fix(web): scale Files tree with interface font size by @Umais-Adeed in pingdotgg/t3code#8011 * fix(server): probe only owned preview listeners by @maria-rcks in pingdotgg/t3code#16687 * fix(chat): surface pending subagent questions on parents by @maria-rcks in pingdotgg/t3code#16634 * fix(web): section header chevrons point up when collapsed by @ZenderGoD in pingdotgg/t3code#14273 * fix(web): timeline divider pill shows a pointer, visible hover and focus ring by @jonesfionn101-dotcom in pingdotgg/t3code#15188 * fix(git): allow creating prs from dirty worktrees by @maria-rcks in pingdotgg/t3code#15625 * docs(install): polish binary install destination phrasing by @ege-arhan in pingdotgg/t3code#15732 * perf(server): keep passive terminal output flowing by @StiensWout in pingdotgg/t3code#17178 * fix(web): stop button icon no longer shifts on hover by @NK-Works in pingdotgg/t3code#16012 * fix(web): add bottom padding to expanded tool panels by @12ya in pingdotgg/t3code#16525 * fix(web): keep incremental highlighter return type portable by @luke2x in pingdotgg/t3code#17259 * fix(web): sidebar "Code" label no longer clips its letter tops by @akbarakma in pingdotgg/t3code#16134 * fix(tests): use POSIX paths for the simulated macOS device host by @Quicksaver in pingdotgg/t3code#17241 * fix(mobile): Android composer keeps the caret in view on AOSP-based keyboards by @bitmvk in pingdotgg/t3code#17492 * test(web): allow cold timeline imports on CI by @lastobelus in pingdotgg/t3code#16608 * fix(mobile): pinch zooms chat images on Android by @AKolenda in pingdotgg/t3code#15047 * fix(web): selected provider ring no longer clipped during panel resize by @jfortez in pingdotgg/t3code#17534 * docs(usage): OpenCode Go limits need a Go API key by @nexxeln in pingdotgg/t3code#15664 * fix(web): improve usage scanning indicator alignment by @AksharP5 in pingdotgg/t3code#15498 * fix(server): print pairing credential expiry as ISO timestamp by @kvnloo in pingdotgg/t3code#14128 * chore(ci): use GPT 6.1 Sol Max for check agents by @ishaanko in pingdotgg/t3code#14312 * fix(mobile): honor requested terminal native architectures by @bompus in pingdotgg/t3code#10709 * fix(server): keep preview browser connected after operation timeouts by @juliusmarminge in pingdotgg/t3code#17693 * fix(web): timeline divider focus ring stays inside the pill by @t3dotgg in pingdotgg/t3code#17702 * perf(desktop): reuse the prepared shell environment in the local backend by @Yash-Singh1 in pingdotgg/t3code#17384 * fix(web): align settings page widths by @diegoarff in pingdotgg/t3code#12158 * test(server): resolve the temp dir before matching the symlinked entrypoint by @ylcn91 in pingdotgg/t3code#9400 * fix(web): keep inline code pills intact when they wrap by @satyalyadav in pingdotgg/t3code#12038 * Revert "chore(ci): use GPT 6.1 Sol Max for check agents" by @maria-rcks in pingdotgg/t3code#17698 * fix(web): show the correct new thread shortcut in command palette by @vaishnavsm in pingdotgg/t3code#8513 * fix(desktop): declare macOS local network usage by @jsilets in pingdotgg/t3code#11922 * docs: add Scoop as Windows installation method by @Mostafa-Ben-Git in pingdotgg/t3code#10509 * fix(server): agents run in their own systemd scopes so an OOM kill spares the server by @t3dotgg in pingdotgg/t3code#17662 * fix(web): welcome wizard says where imported projects come from by @UzEE in pingdotgg/t3code#14584 * fix(web): cite works on responses that end before a tool call by @maria-rcks in pingdotgg/t3code#17713 * fix(desktop): sign Windows native addons by @Lumbreras2306 in pingdotgg/t3code#8206 * fix(server): track resumed subagent follow-ups as separate tasks by @Yash-Singh1 in pingdotgg/t3code#17696 * fix(web): nested corners follow their container's radius by @maria-rcks in pingdotgg/t3code#17695 * feat(web): pr panel actions confirm in place by @maria-rcks in pingdotgg/t3code#17710 * feat(web): reorder right panel tabs by dragging by @eimexdev in pingdotgg/t3code#17730 * fix(azure-devops): list pull requests with token sign-in and check out into worktrees by @maria-rcks in pingdotgg/t3code#17725 * fix(usage): keep one email in two workspaces as two accounts by @maria-rcks in pingdotgg/t3code#17711 * feat(pull-requests): hosts can report edit and resolve permissions per item by @juliusmarminge in pingdotgg/t3code#17667 * perf(server): run Git for Windows' real git.exe, not its launcher by @SunkenInTime in pingdotgg/t3code#17707 * fix(clients): restart continuations show as a T3 Code notice, not another agent's message by @juliusmarminge in pingdotgg/t3code#17723 * fix(mobile): browser picture in picture opens from the header button by @juliusmarminge in pingdotgg/t3code#17731 * feat(source-control): GitCafe lives in @t3tools/source-control-gitcafe by @juliusmarminge in pingdotgg/t3code#17681 * fix(web): add provider wizard no longer shifts sideways while it grows by @flamboh in pingdotgg/t3code#17292 * fix(web): PR search keeps the caret where you type by @flamboh in pingdotgg/t3code#17675 * fix(server): thread PR badges catch up when another environment reads the PR by @flamboh in pingdotgg/t3code#17729 * fix(server): refuse editor paths with line breaks or quotes when the editor is a Windows command shim by @juliusmarminge in pingdotgg/t3code#17749 ## New Contributors * @tiliakoos made their first contribution in pingdotgg/t3code#15537 * @Umais-Adeed made their first contribution in pingdotgg/t3code#8011 * @ZenderGoD made their first contribution in pingdotgg/t3code#14273 * @jonesfionn101-dotcom made their first contribution in pingdotgg/t3code#15188 * @ege-arhan made their first contribution in pingdotgg/t3code#15732 * @NK-Works made their first contribution in pingdotgg/t3code#16012 * @12ya made their first contribution in pingdotgg/t3code#16525 * @luke2x made their first contribution in pingdotgg/t3code#17259 * @akbarakma made their first contribution in pingdotgg/t3code#16134 * @Quicksaver made their first contribution in pingdotgg/t3code#17241 * @bitmvk made their first contribution in pingdotgg/t3code#17492 * @lastobelus made their first contribution in pingdotgg/t3code#16608 * @jfortez made their first contribution in pingdotgg/t3code#17534 * @diegoarff made their first contribution in pingdotgg/t3code#12158 * @ylcn91 made their first contribution in pingdotgg/t3code#9400 * @satyalyadav made their first contribution in pingdotgg/t3code#12038 * @vaishnavsm made their first contribution in pingdotgg/t3code#8513 * @jsilets made their first contribution in pingdotgg/t3code#11922 * @Mostafa-Ben-Git made their first contribution in pingdotgg/t3code#10509 * @UzEE made their first contribution in pingdotgg/t3code#14584 * @Lumbreras2306 made their first contribution in pingdotgg/t3code#8206 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2908...v0.0.46-nightly.20261010.2922 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2922
Problem
Every frame of a sidebar drag changed
--sidebar-widthon[data-slot=sidebar-wrapper], the app root. Changing an inherited custom property there restyles every element in the app. The settings page, with no React work at all, still spent about 42ms per frame on style and layout.Fix
During the drag, the width is written only to the sidebar gap and container, the two elements that read it.
--sidebar-widthis set on the wrapper once, on release. Collapsing the sidebar mid-drag now cancels the drag and restores the earlier width, instead of keeping an unsaved width.Collapse and expand still animate and land at the same width. There's no visual change, so there are no screenshots. The sidebar test passes.
Opus 5.5 via Claude Code in T3 Code
🤖 Generated with Claude Code