Skip to content

fix(web): sidebar "Code" label no longer clips its letter tops - #16134

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
akbarakma:fix/sidebar-label-clip
Oct 10, 2026
Merged

maria-rcks merged 1 commit into
pingdotgg:mainfrom
akbarakma:fix/sidebar-label-clip

Conversation

@akbarakma

Copy link
Copy Markdown
Contributor

Problem

In the sidebar header, the "Code" label next to the T3 mark has its letters cut flat: the top of "C", the ascender of "d", and the bottoms of "C", "o", "d" and "e". It shows on the desktop app and in browsers that support text-box (Chromium, Safari 18.2+).

Change

The label combines [text-box:trim-both_cap_alphabetic] (added in #11906) with truncate. The trim shrinks the span's box to cap height, and truncate's overflow: hidden clips everything outside that box, which is exactly the overshoot of round letters and the "d" ascender.

This adds supports-[text-box:trim-both_cap_alphabetic]:py-1, the same guard WorkspaceBreadcrumbText and the menu item label already use for this combination. The padding is equal top and bottom, so the capitals stay centered on the T3 mark. Browsers without text-box render exactly as before.

Scope and approval

A very small, focused fix for an obvious visual bug: one class and a one-line comment in one file, with no behavior change.

Verification

  • Desktop dev build (Electron 44, macOS Retina, interface size 18): captured the window with the fix toggled off and on. 37 device pixels come back, all on the clip edges: the top and bottom rows of "C", the top two rows of the "d" stem, and the bottom row of "o", "d", "e". Two "after" captures taken before and after the toggle are pixel-identical.
  • Safari 27 (web dev build): the "Code" strokes shift 0 rows between before and after, the "d" ascender comes back, and the T3 mark is unchanged.
  • Alignment at default size: computed cap box of "Code" is y 21.06–30.93, the T3 mark is 21.07–30.93.
  • vp lint apps/web/src/components/sidebar/SidebarChrome.tsx --deny-warnings and vp run --filter @t3tools/web typecheck pass.
  • Not checked: Windows and Linux desktop, Firefox, 1x displays.

Each square below is one screen pixel, enlarged 8x. The dashed lines mark the trimmed box; red marks the pixels the fix restores.

pr-a-evidence

Before / after at 4x:

Before:

pr-a-before

After:

pr-a-after-4x

Built with Claude Opus 5.5 through Claude Code, running in T3 Code.

The label combined text-box trimming with truncate, so overflow clipping cut the ascender and round-letter overshoot. Pad the label where text-box is supported, matching the breadcrumb and menu labels.
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 5, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at fe1bdaf

Macroscope's review found this PR approvable — This is a one-file, support-gated styling fix that restores clipped glyph pixels in the sidebar label while leaving unsupported browsers unchanged. It introduces no API, default, deployment, security, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingdotgg/t3code/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f9df5d44-11e0-41a9-b377-226331b91fef
📥 Commits

Reviewing files that changed from the base of the PR and between 3e6b450 and fe1bdaf.

📒 Files selected for processing (1)
  • apps/web/src/components/sidebar/SidebarChrome.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The sidebar wordmark text span applies vertical padding when the browser supports text-box: trim-both_cap_alphabetic. Unsupported browsers retain the existing truncation styling.

Changes

Sidebar wordmark

Layer / File(s) Summary
Conditional wordmark padding
apps/web/src/components/sidebar/SidebarChrome.tsx
The wordmark text span adds vertical padding when the browser supports text-box: trim-both_cap_alphabetic.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: flamboh

Merge Risk: ⚪ Minimal · up to fe1bd

The sidebar wordmark receives conditional padding in supporting browsers. No actionable regression is established, so the change appears mergeable with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix for clipping in the sidebar “Code” label.
Description check ✅ Passed The description covers the problem, change, scope rationale, verification results, unchecked platforms, and before-and-after screenshots. It follows the repository template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@maria-rcks
maria-rcks merged commit 391f813 into pingdotgg:main Oct 10, 2026
31 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 10, 2026
## What's Changed
* feat(web): draft screen project picker is searchable by @juliusmarminge in pingdotgg/t3code#17664
* fix(server): report incomplete transcript usage scans by @maria-rcks in pingdotgg/t3code#15661
* fix(web): every resize-driven layout commits in the same frame by @maria-rcks in pingdotgg/t3code#17656
* fix(web): right panel and terminal drawer follow the pointer while dragging by @maria-rcks in pingdotgg/t3code#17657
* fix(web): terminal drawer keeps its height after the window shrinks by @maria-rcks in pingdotgg/t3code#17658
* perf(web): sidebar drags restyle only the sidebar by @maria-rcks in pingdotgg/t3code#17659
* fix(web): server browser page resizes while the panel is dragged by @maria-rcks in pingdotgg/t3code#17660
* fix(storage): make worktree cleanup work and show why it skipped by @maria-rcks in pingdotgg/t3code#17563
* test(usage): usage service tests keep their state directory until cache writes land by @tris203 in pingdotgg/t3code#17636
* fix(checkpoint): pulls and rebases no longer flood a turn's changed files by @t3dotgg in pingdotgg/t3code#17161
* fix(web): place notification icons after titles by @voltcrash in pingdotgg/t3code#12209
* fix(web): attachments on an open question are visible again by @tiliakoos in pingdotgg/t3code#15537
* fix(web): scale Files tree with interface font size by @Umais-Adeed in pingdotgg/t3code#8011
* fix(server): probe only owned preview listeners by @maria-rcks in pingdotgg/t3code#16687
* fix(chat): surface pending subagent questions on parents by @maria-rcks in pingdotgg/t3code#16634
* fix(web): section header chevrons point up when collapsed by @ZenderGoD in pingdotgg/t3code#14273
* fix(web): timeline divider pill shows a pointer, visible hover and focus ring by @jonesfionn101-dotcom in pingdotgg/t3code#15188
* fix(git): allow creating prs from dirty worktrees by @maria-rcks in pingdotgg/t3code#15625
* docs(install): polish binary install destination phrasing by @ege-arhan in pingdotgg/t3code#15732
* perf(server): keep passive terminal output flowing by @StiensWout in pingdotgg/t3code#17178
* fix(web): stop button icon no longer shifts on hover by @NK-Works in pingdotgg/t3code#16012
* fix(web): add bottom padding to expanded tool panels by @12ya in pingdotgg/t3code#16525
* fix(web): keep incremental highlighter return type portable by @luke2x in pingdotgg/t3code#17259
* fix(web): sidebar "Code" label no longer clips its letter tops by @akbarakma in pingdotgg/t3code#16134
* fix(tests): use POSIX paths for the simulated macOS device host by @Quicksaver in pingdotgg/t3code#17241
* fix(mobile): Android composer keeps the caret in view on AOSP-based keyboards by @bitmvk in pingdotgg/t3code#17492
* test(web): allow cold timeline imports on CI by @lastobelus in pingdotgg/t3code#16608
* fix(mobile): pinch zooms chat images on Android by @AKolenda in pingdotgg/t3code#15047
* fix(web): selected provider ring no longer clipped during panel resize by @jfortez in pingdotgg/t3code#17534
* docs(usage): OpenCode Go limits need a Go API key by @nexxeln in pingdotgg/t3code#15664
* fix(web): improve usage scanning indicator alignment by @AksharP5 in pingdotgg/t3code#15498
* fix(server): print pairing credential expiry as ISO timestamp by @kvnloo in pingdotgg/t3code#14128
* chore(ci): use GPT 6.1 Sol Max for check agents by @ishaanko in pingdotgg/t3code#14312
* fix(mobile): honor requested terminal native architectures by @bompus in pingdotgg/t3code#10709
* fix(server): keep preview browser connected after operation timeouts by @juliusmarminge in pingdotgg/t3code#17693
* fix(web): timeline divider focus ring stays inside the pill by @t3dotgg in pingdotgg/t3code#17702
* perf(desktop): reuse the prepared shell environment in the local backend by @Yash-Singh1 in pingdotgg/t3code#17384
* fix(web): align settings page widths by @diegoarff in pingdotgg/t3code#12158
* test(server): resolve the temp dir before matching the symlinked entrypoint by @ylcn91 in pingdotgg/t3code#9400
* fix(web): keep inline code pills intact when they wrap by @satyalyadav in pingdotgg/t3code#12038
* Revert "chore(ci): use GPT 6.1 Sol Max for check agents" by @maria-rcks in pingdotgg/t3code#17698
* fix(web): show the correct new thread shortcut in command palette by @vaishnavsm in pingdotgg/t3code#8513
* fix(desktop): declare macOS local network usage by @jsilets in pingdotgg/t3code#11922
* docs: add Scoop as Windows installation method by @Mostafa-Ben-Git in pingdotgg/t3code#10509
* fix(server): agents run in their own systemd scopes so an OOM kill spares the server by @t3dotgg in pingdotgg/t3code#17662
* fix(web): welcome wizard says where imported projects come from by @UzEE in pingdotgg/t3code#14584
* fix(web): cite works on responses that end before a tool call by @maria-rcks in pingdotgg/t3code#17713
* fix(desktop): sign Windows native addons by @Lumbreras2306 in pingdotgg/t3code#8206
* fix(server): track resumed subagent follow-ups as separate tasks by @Yash-Singh1 in pingdotgg/t3code#17696
* fix(web): nested corners follow their container's radius by @maria-rcks in pingdotgg/t3code#17695
* feat(web): pr panel actions confirm in place by @maria-rcks in pingdotgg/t3code#17710
* feat(web): reorder right panel tabs by dragging by @eimexdev in pingdotgg/t3code#17730
* fix(azure-devops): list pull requests with token sign-in and check out into worktrees by @maria-rcks in pingdotgg/t3code#17725
* fix(usage): keep one email in two workspaces as two accounts by @maria-rcks in pingdotgg/t3code#17711
* feat(pull-requests): hosts can report edit and resolve permissions per item by @juliusmarminge in pingdotgg/t3code#17667
* perf(server): run Git for Windows' real git.exe, not its launcher by @SunkenInTime in pingdotgg/t3code#17707
* fix(clients): restart continuations show as a T3 Code notice, not another agent's message by @juliusmarminge in pingdotgg/t3code#17723
* fix(mobile): browser picture in picture opens from the header button by @juliusmarminge in pingdotgg/t3code#17731
* feat(source-control): GitCafe lives in @t3tools/source-control-gitcafe by @juliusmarminge in pingdotgg/t3code#17681
* fix(web): add provider wizard no longer shifts sideways while it grows by @flamboh in pingdotgg/t3code#17292
* fix(web): PR search keeps the caret where you type by @flamboh in pingdotgg/t3code#17675
* fix(server): thread PR badges catch up when another environment reads the PR by @flamboh in pingdotgg/t3code#17729
* fix(server): refuse editor paths with line breaks or quotes when the editor is a Windows command shim by @juliusmarminge in pingdotgg/t3code#17749

## New Contributors
* @tiliakoos made their first contribution in pingdotgg/t3code#15537
* @Umais-Adeed made their first contribution in pingdotgg/t3code#8011
* @ZenderGoD made their first contribution in pingdotgg/t3code#14273
* @jonesfionn101-dotcom made their first contribution in pingdotgg/t3code#15188
* @ege-arhan made their first contribution in pingdotgg/t3code#15732
* @NK-Works made their first contribution in pingdotgg/t3code#16012
* @12ya made their first contribution in pingdotgg/t3code#16525
* @luke2x made their first contribution in pingdotgg/t3code#17259
* @akbarakma made their first contribution in pingdotgg/t3code#16134
* @Quicksaver made their first contribution in pingdotgg/t3code#17241
* @bitmvk made their first contribution in pingdotgg/t3code#17492
* @lastobelus made their first contribution in pingdotgg/t3code#16608
* @jfortez made their first contribution in pingdotgg/t3code#17534
* @diegoarff made their first contribution in pingdotgg/t3code#12158
* @ylcn91 made their first contribution in pingdotgg/t3code#9400
* @satyalyadav made their first contribution in pingdotgg/t3code#12038
* @vaishnavsm made their first contribution in pingdotgg/t3code#8513
* @jsilets made their first contribution in pingdotgg/t3code#11922
* @Mostafa-Ben-Git made their first contribution in pingdotgg/t3code#10509
* @UzEE made their first contribution in pingdotgg/t3code#14584
* @Lumbreras2306 made their first contribution in pingdotgg/t3code#8206

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2908...v0.0.46-nightly.20261010.2922

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2922
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 10, 2026
## What's Changed
* feat(web): draft screen project picker is searchable by @juliusmarminge in pingdotgg/t3code#17664
* fix(server): report incomplete transcript usage scans by @maria-rcks in pingdotgg/t3code#15661
* fix(web): every resize-driven layout commits in the same frame by @maria-rcks in pingdotgg/t3code#17656
* fix(web): right panel and terminal drawer follow the pointer while dragging by @maria-rcks in pingdotgg/t3code#17657
* fix(web): terminal drawer keeps its height after the window shrinks by @maria-rcks in pingdotgg/t3code#17658
* perf(web): sidebar drags restyle only the sidebar by @maria-rcks in pingdotgg/t3code#17659
* fix(web): server browser page resizes while the panel is dragged by @maria-rcks in pingdotgg/t3code#17660
* fix(storage): make worktree cleanup work and show why it skipped by @maria-rcks in pingdotgg/t3code#17563
* test(usage): usage service tests keep their state directory until cache writes land by @tris203 in pingdotgg/t3code#17636
* fix(checkpoint): pulls and rebases no longer flood a turn's changed files by @t3dotgg in pingdotgg/t3code#17161
* fix(web): place notification icons after titles by @voltcrash in pingdotgg/t3code#12209
* fix(web): attachments on an open question are visible again by @tiliakoos in pingdotgg/t3code#15537
* fix(web): scale Files tree with interface font size by @Umais-Adeed in pingdotgg/t3code#8011
* fix(server): probe only owned preview listeners by @maria-rcks in pingdotgg/t3code#16687
* fix(chat): surface pending subagent questions on parents by @maria-rcks in pingdotgg/t3code#16634
* fix(web): section header chevrons point up when collapsed by @ZenderGoD in pingdotgg/t3code#14273
* fix(web): timeline divider pill shows a pointer, visible hover and focus ring by @jonesfionn101-dotcom in pingdotgg/t3code#15188
* fix(git): allow creating prs from dirty worktrees by @maria-rcks in pingdotgg/t3code#15625
* docs(install): polish binary install destination phrasing by @ege-arhan in pingdotgg/t3code#15732
* perf(server): keep passive terminal output flowing by @StiensWout in pingdotgg/t3code#17178
* fix(web): stop button icon no longer shifts on hover by @NK-Works in pingdotgg/t3code#16012
* fix(web): add bottom padding to expanded tool panels by @12ya in pingdotgg/t3code#16525
* fix(web): keep incremental highlighter return type portable by @luke2x in pingdotgg/t3code#17259
* fix(web): sidebar "Code" label no longer clips its letter tops by @akbarakma in pingdotgg/t3code#16134
* fix(tests): use POSIX paths for the simulated macOS device host by @Quicksaver in pingdotgg/t3code#17241
* fix(mobile): Android composer keeps the caret in view on AOSP-based keyboards by @bitmvk in pingdotgg/t3code#17492
* test(web): allow cold timeline imports on CI by @lastobelus in pingdotgg/t3code#16608
* fix(mobile): pinch zooms chat images on Android by @AKolenda in pingdotgg/t3code#15047
* fix(web): selected provider ring no longer clipped during panel resize by @jfortez in pingdotgg/t3code#17534
* docs(usage): OpenCode Go limits need a Go API key by @nexxeln in pingdotgg/t3code#15664
* fix(web): improve usage scanning indicator alignment by @AksharP5 in pingdotgg/t3code#15498
* fix(server): print pairing credential expiry as ISO timestamp by @kvnloo in pingdotgg/t3code#14128
* chore(ci): use GPT 6.1 Sol Max for check agents by @ishaanko in pingdotgg/t3code#14312
* fix(mobile): honor requested terminal native architectures by @bompus in pingdotgg/t3code#10709
* fix(server): keep preview browser connected after operation timeouts by @juliusmarminge in pingdotgg/t3code#17693
* fix(web): timeline divider focus ring stays inside the pill by @t3dotgg in pingdotgg/t3code#17702
* perf(desktop): reuse the prepared shell environment in the local backend by @Yash-Singh1 in pingdotgg/t3code#17384
* fix(web): align settings page widths by @diegoarff in pingdotgg/t3code#12158
* test(server): resolve the temp dir before matching the symlinked entrypoint by @ylcn91 in pingdotgg/t3code#9400
* fix(web): keep inline code pills intact when they wrap by @satyalyadav in pingdotgg/t3code#12038
* Revert "chore(ci): use GPT 6.1 Sol Max for check agents" by @maria-rcks in pingdotgg/t3code#17698
* fix(web): show the correct new thread shortcut in command palette by @vaishnavsm in pingdotgg/t3code#8513
* fix(desktop): declare macOS local network usage by @jsilets in pingdotgg/t3code#11922
* docs: add Scoop as Windows installation method by @Mostafa-Ben-Git in pingdotgg/t3code#10509
* fix(server): agents run in their own systemd scopes so an OOM kill spares the server by @t3dotgg in pingdotgg/t3code#17662
* fix(web): welcome wizard says where imported projects come from by @UzEE in pingdotgg/t3code#14584
* fix(web): cite works on responses that end before a tool call by @maria-rcks in pingdotgg/t3code#17713
* fix(desktop): sign Windows native addons by @Lumbreras2306 in pingdotgg/t3code#8206
* fix(server): track resumed subagent follow-ups as separate tasks by @Yash-Singh1 in pingdotgg/t3code#17696
* fix(web): nested corners follow their container's radius by @maria-rcks in pingdotgg/t3code#17695
* feat(web): pr panel actions confirm in place by @maria-rcks in pingdotgg/t3code#17710
* feat(web): reorder right panel tabs by dragging by @eimexdev in pingdotgg/t3code#17730
* fix(azure-devops): list pull requests with token sign-in and check out into worktrees by @maria-rcks in pingdotgg/t3code#17725
* fix(usage): keep one email in two workspaces as two accounts by @maria-rcks in pingdotgg/t3code#17711
* feat(pull-requests): hosts can report edit and resolve permissions per item by @juliusmarminge in pingdotgg/t3code#17667
* perf(server): run Git for Windows' real git.exe, not its launcher by @SunkenInTime in pingdotgg/t3code#17707
* fix(clients): restart continuations show as a T3 Code notice, not another agent's message by @juliusmarminge in pingdotgg/t3code#17723
* fix(mobile): browser picture in picture opens from the header button by @juliusmarminge in pingdotgg/t3code#17731
* feat(source-control): GitCafe lives in @t3tools/source-control-gitcafe by @juliusmarminge in pingdotgg/t3code#17681
* fix(web): add provider wizard no longer shifts sideways while it grows by @flamboh in pingdotgg/t3code#17292
* fix(web): PR search keeps the caret where you type by @flamboh in pingdotgg/t3code#17675
* fix(server): thread PR badges catch up when another environment reads the PR by @flamboh in pingdotgg/t3code#17729
* fix(server): refuse editor paths with line breaks or quotes when the editor is a Windows command shim by @juliusmarminge in pingdotgg/t3code#17749

## New Contributors
* @tiliakoos made their first contribution in pingdotgg/t3code#15537
* @Umais-Adeed made their first contribution in pingdotgg/t3code#8011
* @ZenderGoD made their first contribution in pingdotgg/t3code#14273
* @jonesfionn101-dotcom made their first contribution in pingdotgg/t3code#15188
* @ege-arhan made their first contribution in pingdotgg/t3code#15732
* @NK-Works made their first contribution in pingdotgg/t3code#16012
* @12ya made their first contribution in pingdotgg/t3code#16525
* @luke2x made their first contribution in pingdotgg/t3code#17259
* @akbarakma made their first contribution in pingdotgg/t3code#16134
* @Quicksaver made their first contribution in pingdotgg/t3code#17241
* @bitmvk made their first contribution in pingdotgg/t3code#17492
* @lastobelus made their first contribution in pingdotgg/t3code#16608
* @jfortez made their first contribution in pingdotgg/t3code#17534
* @diegoarff made their first contribution in pingdotgg/t3code#12158
* @ylcn91 made their first contribution in pingdotgg/t3code#9400
* @satyalyadav made their first contribution in pingdotgg/t3code#12038
* @vaishnavsm made their first contribution in pingdotgg/t3code#8513
* @jsilets made their first contribution in pingdotgg/t3code#11922
* @Mostafa-Ben-Git made their first contribution in pingdotgg/t3code#10509
* @UzEE made their first contribution in pingdotgg/t3code#14584
* @Lumbreras2306 made their first contribution in pingdotgg/t3code#8206

**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2908...v0.0.46-nightly.20261010.2922

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants