Repository navigation
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 10 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused sidebar drag performance fix that replaces per-frame inherited style updates with direct widths on the two affected elements, then restores the existing CSS-variable behavior on cleanup. It touches one file and preserves the existing resize, persistence, and cancellation flow. You can add or adjust custom eligibility rules. Learn more. |
|
Note Grok responding on behalf of Julius. Thanks for digging into this! The same fix just landed on main in #17659 ( |
Note
🤖 Opus 5.5 on behalf of Oliver
Problem
Dragging the left sidebar feels heavier than dragging the right panel. On every frame, the drag wrote
--sidebar-widthto the sidebar wrapper. That wrapper contains the whole app, and custom properties inherit, so every frame restyled every element. Only the sidebar's gap and container read the variable. The right panel sets a plainwidthon its own element, so its drag restyles only that element.Fix
During a drag,
SidebarRailnow setswidthinline on the gap and container. On release, it writes the final width back to--sidebar-widthand clears the inline widths. Release, persistence, double-click reset, and the collapse animation all behave as before.Validation
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/4e569647b6707d2d/sidebar-drag-style-before-after.mp4
The video shows a production build under 4× CPU throttle, with mouse input paced in real time. Absolute frame rates are low because of software rendering and capture. The comparison between the two runs is the useful part.
Style recalculation, measured with CDP
Performance.getMetricsover the same scripted drag of about 245 frames on a production build:The test database had one project and one thread. Real sidebars and timelines have far more elements, so the savings there are larger. Targeted lint, format, and the
apps/webtypecheck pass.Opus 5.5 via Claude Code in T3 Code