Skip to content

refactor(source-control): Azure DevOps lives in @t3tools/source-control-azure-devops - #17592

Merged
juliusmarminge merged 2 commits into
t3/source-control-forgejofrom
t3/source-control-azure-devops
Oct 9, 2026
Merged

juliusmarminge merged 2 commits into
t3/source-control-forgejofrom
t3/source-control-azure-devops

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Third layer of moving each source control host into its own package. It stacks on #17581.

The Azure DevOps support moves out of apps/server into @t3tools/source-control-azure-devops, one subpath per module:

  • the az CLI client (AzureDevOpsCli)
  • the repository provider
  • the pull request CLI and provider
  • JSON decoding and diff reconstruction

The package reaches the server only through SourceControlHost.

  • Its driver joins BUILT_IN_SOURCE_CONTROL_DRIVERS. Neither registry, server.ts, nor ws.ts names Azure DevOps any more.
  • The built-in list is now typed by the union of its drivers' requirements, as BUILT_IN_DRIVERS is for agent providers, so the registry's R channel stays honest as more hosts join.
  • Discovery keeps its existing host order (github, gitlab, azure-devops, bitbucket, forgejo). The order is pinned until every host is a driver, and the discovery test asserts it.
  • The diff dependency moves from apps/server to the package, which is now its only user.

Tests move with their code, with only imports and wiring changed. The az client test runs against TestSourceControlHost.

Verified with tsc (apps/server and the packages), knip, a frozen-lockfile install, release smoke, and 59 test files (1405 tests).

🤖 Generated with Claude Code — Claude Opus 5.5 in T3 Code

@juliusmarminge
juliusmarminge added this pull request to stack #17582 October 9, 2026 19:56
@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Oct 9, 2026
@juliusmarminge juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 9, 2026
@github-actions github-actions Bot added the size:L 100-499 changed lines (additions + deletions). label Oct 9, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 9, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at caa3dfd

Macroscope's review found this PR approvable — This is a bounded Azure DevOps package extraction with existing implementation and tests moved intact. Server wiring, service dependencies, and discovery ordering preserve the prior runtime path without introducing schema, deployment, security, or default-behavior changes.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire — 5.0 KiB — 6.8 KiB ✅
Codex Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Codex Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Codex Live turn WebSocket decoded — 20.9 KiB — 29.3 KiB ✅
Codex Live turn messages — 2 — 8 ✅
Claude Total thread wire — 5.0 KiB — 6.8 KiB ✅
Claude Thread snapshot wire — 3.8 KiB — 4.9 KiB ✅
Claude Live turn WebSocket wire — 1.2 KiB — 2.0 KiB ✅
Claude Live turn WebSocket decoded — 21.2 KiB — 29.3 KiB ✅
Claude Live turn messages — 1 — 8 ✅

Baseline: unavailable · PR result: caa3dfd · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 399db524-be94-4f87-8986-ba6b4ddaa3c0

📥 Commits

Reviewing files that changed from the base of the PR and between d876f7f and caa3dfd.


⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (29)
  • apps/server/package.json
  • apps/server/scripts/evaluate-thread-titles.ts
  • apps/server/src/pullRequest/PullRequestProviderRateLimit.test.ts
  • apps/server/src/pullRequest/PullRequestProviderRegistry.ts
  • apps/server/src/server.ts
  • apps/server/src/sourceControl/SourceControlDiscovery.test.ts
  • apps/server/src/sourceControl/SourceControlProviderRegistry.test.ts
  • apps/server/src/sourceControl/SourceControlProviderRegistry.ts
  • apps/server/src/sourceControl/builtInDrivers.ts
  • apps/server/src/ws.ts
  • docs/internals/pull-request-file-revisions.md
  • package.json
  • packages/source-control-azure-devops/package.json
  • packages/source-control-azure-devops/src/server/AzureDevOpsCli.test.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsCli.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestCli.test.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestCli.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.test.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsSourceControlProvider.test.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsSourceControlProvider.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsDiff.test.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsDiff.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsPullRequestJson.test.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsPullRequestJson.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsPullRequests.ts
  • packages/source-control-azure-devops/src/server/driver.ts
  • packages/source-control-azure-devops/tsconfig.json
  • scripts/release-smoke.ts

💤 Files with no reviewable changes (12)
  • packages/source-control-azure-devops/src/server/AzureDevOpsSourceControlProvider.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsPullRequests.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsDiff.test.ts
  • apps/server/src/ws.ts
  • apps/server/scripts/evaluate-thread-titles.ts
  • apps/server/src/server.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsDiff.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsPullRequestProvider.test.ts
  • apps/server/src/pullRequest/PullRequestProviderRegistry.ts
  • packages/source-control-azure-devops/src/server/azureDevOpsPullRequestJson.test.ts
  • packages/source-control-azure-devops/src/server/AzureDevOpsSourceControlProvider.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.



📝 Walkthrough

Walkthrough

Azure DevOps source-control and pull-request services are defined in a workspace package and exposed through a driver. The server registers that driver with its built-in drivers. Direct Azure DevOps provider wiring is removed from the server registries.

Changes

Azure DevOps package integration

Layer / File(s) Summary
Package services and driver
packages/source-control-azure-devops/*, package.json, scripts/release-smoke.ts, docs/internals/pull-request-file-revisions.md
The package defines server exports and a driver that combines source-control and pull-request providers. Azure DevOps CLI process execution uses SourceControlHost. Workspace analysis, release smoke fixtures, and the documentation link include the package.
Server provider registration
apps/server/package.json, apps/server/src/sourceControl/*, apps/server/src/pullRequest/*, apps/server/src/server.ts, apps/server/src/ws.ts, apps/server/scripts/evaluate-thread-titles.ts
The built-in driver registry includes Azure DevOps. The source-control registry sorts registrations before creating providers. Direct Azure DevOps provider and CLI wiring is removed from server registries. Related tests use package exports and mock the Azure DevOps pull-request CLI.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor


Merge Risk: ⚪ Minimal · up to caa3d

Azure DevOps registration and service wiring appear intact. No actionable merge-blocking risk remains after normal checks.

Pre-merge checks | Passed 3 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The description explains the implementation and provides detailed verification results, but it does not use the required Problem, Change, Scope and approval, and Verification sections. It also does no… Rewrite the description using all required section headings. Add the problem, expected behavior, and relevant reproduction or environment details. Explain the change under Change. Under Scope and approval, link the triaged issue or maintain…
✅ Passed checks (3 passed)
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: moving Azure DevOps support into the dedicated @t3tools/source-control-azure-devops package.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the implementation and provides detailed verification results, but it does not use the required Problem, Change, Scope and approval, and Verification sections. It also does not document the underlying problem or provide a triaged issue or explicit maintainer approval.

Resolution

Rewrite the description using all required section headings. Add the problem, expected behavior, and relevant reproduction or environment details. Explain the change under Change. Under Scope and approval, link the triaged issue or maintainer approval, or explain why this focused refactor qualifies for an exemption. Keep the detailed verification results under Verification.



  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

juliusmarminge and others added 2 commits October 9, 2026 14:38
…ol-azure-devops

The az CLI client, repository provider, pull request CLI and provider,
JSON decoding and diff reconstruction move into their own package and
reach the server only through SourceControlHost. Its driver joins
BUILT_IN_SOURCE_CONTROL_DRIVERS, so neither registry names Azure DevOps.

The built-in list is typed by the union of its drivers' requirements,
and discovery keeps its existing host order. The diff dependency moves
from apps/server to the package, its only user.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… DevOps provider

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@juliusmarminge
juliusmarminge force-pushed the t3/source-control-azure-devops branch from d876f7f to caa3dfd Compare October 9, 2026 21:41
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 9, 2026 21:41

Dismissing prior approval to re-evaluate caa3dfd

@juliusmarminge
juliusmarminge merged commit d01febb into main Oct 9, 2026
34 of 54 checks passed
@juliusmarminge
juliusmarminge deleted the t3/source-control-azure-devops branch October 9, 2026 21:50
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Oct 10, 2026
## What's Changed
* chore(deps): upgrade Effect to 4.0.2 by @juliusmarminge in pingdotgg/t3code#17571
* fix(devices): recover stalled video without losing simulator input by @juliusmarminge in pingdotgg/t3code#17566
* fix(web): keep checkout stable while pr actions load by @maria-rcks in pingdotgg/t3code#16625
* fix(mobile): show waiting thread status by @maria-rcks in pingdotgg/t3code#16693
* feat(web): add parent thread breadcrumb navigation by @maria-rcks in pingdotgg/t3code#16666
* fix(server): restart inactivity after snoozed threads wake by @maria-rcks in pingdotgg/t3code#16674
* feat(desktop): passkeys in the in-app browser on macOS by @juliusmarminge in pingdotgg/t3code#16952
* fix(client): load earlier turns works for MCP threads over T3 Connect by @juliusmarminge in pingdotgg/t3code#17599
* refactor(client): sign relay request URLs built from the HttpApi contract by @juliusmarminge in pingdotgg/t3code#17602
* refactor(source-control): add @t3tools/source-control-core by @juliusmarminge in pingdotgg/t3code#17573
* refactor(source-control): Forgejo lives in @t3tools/source-control-forgejo by @juliusmarminge in pingdotgg/t3code#17581
* refactor(source-control): Azure DevOps lives in @t3tools/source-control-azure-devops by @juliusmarminge in pingdotgg/t3code#17592
* refactor(source-control): GitLab lives in @t3tools/source-control-gitlab by @juliusmarminge in pingdotgg/t3code#17594
* refactor(source-control): Bitbucket lives in @t3tools/source-control-bitbucket by @juliusmarminge in pingdotgg/t3code#17597
* refactor(source-control): GitHub lives in @t3tools/source-control-github by @juliusmarminge in pingdotgg/t3code#17607
* refactor(usage): transcript readers come from their drivers by @juliusmarminge in pingdotgg/t3code#17576
* refactor(usage): OpenCode usage comes from provider-opencode by @juliusmarminge in pingdotgg/t3code#17577
* refactor(usage): Cursor account usage comes from provider-cursor by @juliusmarminge in pingdotgg/t3code#17578
* refactor(usage): Antigravity usage is a reader on its driver by @juliusmarminge in pingdotgg/t3code#17579
* refactor(usage): usage readers use Effect FileSystem and SqlClient by @juliusmarminge in pingdotgg/t3code#17615
* fix(web): composer context strip pads both edges evenly by @limineol in pingdotgg/t3code#17562
* test(usage): v4 cache upgrade test waits for the migrated cache write by @Mnigos in pingdotgg/t3code#17553
* feat(mobile): support Duo in the shared iOS app by @juliusmarminge in pingdotgg/t3code#12648
* refactor(source-control): GitManager reads provider resolvers, not host kinds by @juliusmarminge in pingdotgg/t3code#17617
* refactor(source-control): PullRequestService reads GitHub resolvers, not its kind by @juliusmarminge in pingdotgg/t3code#17619
* refactor(source-control): Forgejo identity and Azure DevOps addressing move into their packages by @juliusmarminge in pingdotgg/t3code#17624
* refactor: home directory comes from a HostProcessHomeDirectory reference by @juliusmarminge in pingdotgg/t3code#17628
* refactor(shared): host process references live in a HostProcess module by @juliusmarminge in pingdotgg/t3code#17641
* feat(web): filter PR comments by bots and resolved threads by @juliusmarminge in pingdotgg/t3code#17645
* fix(clients): remove redundant prefix from PR watch status by @extoci in pingdotgg/t3code#17635
* fix(web): pending requests wait until you stop typing by @maria-rcks in pingdotgg/t3code#17637
* fix(models): remove new badges from Claude Opus and Sonnet 5.5 by @extoci in pingdotgg/t3code#17646
* fix(ui): keep focus and selection borders visible across the app by @maria-rcks in pingdotgg/t3code#16675
* fix(mobile): prevent row presses during native back swipes by @juliusmarminge in pingdotgg/t3code#17648
* fix(server): Codex shadow homes replace stray sqlite maintenance locks by @juliusmarminge in pingdotgg/t3code#17663
* feat(desktop): T3 Code can be your default web browser on macOS by @juliusmarminge in pingdotgg/t3code#17587
* test(server): the ACP process-tree test no longer collides with the runner's own pid by @yordis in pingdotgg/t3code#17647
* fix(web): keep branch restore action inline in narrow composers by @Saikrishna1876 in pingdotgg/t3code#14811
* fix(web): composer banner actions stay inline whenever they fit by @maria-rcks in pingdotgg/t3code#17640


**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2886...v0.0.46-nightly.20261010.2908

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2908
github-actions Bot added a commit to davidvanderklay/t3code-flake that referenced this pull request Oct 10, 2026
## What's Changed
* chore(deps): upgrade Effect to 4.0.2 by @juliusmarminge in pingdotgg/t3code#17571
* fix(devices): recover stalled video without losing simulator input by @juliusmarminge in pingdotgg/t3code#17566
* fix(web): keep checkout stable while pr actions load by @maria-rcks in pingdotgg/t3code#16625
* fix(mobile): show waiting thread status by @maria-rcks in pingdotgg/t3code#16693
* feat(web): add parent thread breadcrumb navigation by @maria-rcks in pingdotgg/t3code#16666
* fix(server): restart inactivity after snoozed threads wake by @maria-rcks in pingdotgg/t3code#16674
* feat(desktop): passkeys in the in-app browser on macOS by @juliusmarminge in pingdotgg/t3code#16952
* fix(client): load earlier turns works for MCP threads over T3 Connect by @juliusmarminge in pingdotgg/t3code#17599
* refactor(client): sign relay request URLs built from the HttpApi contract by @juliusmarminge in pingdotgg/t3code#17602
* refactor(source-control): add @t3tools/source-control-core by @juliusmarminge in pingdotgg/t3code#17573
* refactor(source-control): Forgejo lives in @t3tools/source-control-forgejo by @juliusmarminge in pingdotgg/t3code#17581
* refactor(source-control): Azure DevOps lives in @t3tools/source-control-azure-devops by @juliusmarminge in pingdotgg/t3code#17592
* refactor(source-control): GitLab lives in @t3tools/source-control-gitlab by @juliusmarminge in pingdotgg/t3code#17594
* refactor(source-control): Bitbucket lives in @t3tools/source-control-bitbucket by @juliusmarminge in pingdotgg/t3code#17597
* refactor(source-control): GitHub lives in @t3tools/source-control-github by @juliusmarminge in pingdotgg/t3code#17607
* refactor(usage): transcript readers come from their drivers by @juliusmarminge in pingdotgg/t3code#17576
* refactor(usage): OpenCode usage comes from provider-opencode by @juliusmarminge in pingdotgg/t3code#17577
* refactor(usage): Cursor account usage comes from provider-cursor by @juliusmarminge in pingdotgg/t3code#17578
* refactor(usage): Antigravity usage is a reader on its driver by @juliusmarminge in pingdotgg/t3code#17579
* refactor(usage): usage readers use Effect FileSystem and SqlClient by @juliusmarminge in pingdotgg/t3code#17615
* fix(web): composer context strip pads both edges evenly by @limineol in pingdotgg/t3code#17562
* test(usage): v4 cache upgrade test waits for the migrated cache write by @Mnigos in pingdotgg/t3code#17553
* feat(mobile): support Duo in the shared iOS app by @juliusmarminge in pingdotgg/t3code#12648
* refactor(source-control): GitManager reads provider resolvers, not host kinds by @juliusmarminge in pingdotgg/t3code#17617
* refactor(source-control): PullRequestService reads GitHub resolvers, not its kind by @juliusmarminge in pingdotgg/t3code#17619
* refactor(source-control): Forgejo identity and Azure DevOps addressing move into their packages by @juliusmarminge in pingdotgg/t3code#17624
* refactor: home directory comes from a HostProcessHomeDirectory reference by @juliusmarminge in pingdotgg/t3code#17628
* refactor(shared): host process references live in a HostProcess module by @juliusmarminge in pingdotgg/t3code#17641
* feat(web): filter PR comments by bots and resolved threads by @juliusmarminge in pingdotgg/t3code#17645
* fix(clients): remove redundant prefix from PR watch status by @extoci in pingdotgg/t3code#17635
* fix(web): pending requests wait until you stop typing by @maria-rcks in pingdotgg/t3code#17637
* fix(models): remove new badges from Claude Opus and Sonnet 5.5 by @extoci in pingdotgg/t3code#17646
* fix(ui): keep focus and selection borders visible across the app by @maria-rcks in pingdotgg/t3code#16675
* fix(mobile): prevent row presses during native back swipes by @juliusmarminge in pingdotgg/t3code#17648
* fix(server): Codex shadow homes replace stray sqlite maintenance locks by @juliusmarminge in pingdotgg/t3code#17663
* feat(desktop): T3 Code can be your default web browser on macOS by @juliusmarminge in pingdotgg/t3code#17587
* test(server): the ACP process-tree test no longer collides with the runner's own pid by @yordis in pingdotgg/t3code#17647
* fix(web): keep branch restore action inline in narrow composers by @Saikrishna1876 in pingdotgg/t3code#14811
* fix(web): composer banner actions stay inline whenever they fit by @maria-rcks in pingdotgg/t3code#17640


**Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2886...v0.0.46-nightly.20261010.2908

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant