Repository navigation
refactor(usage): transcript readers come from their drivers - #17576
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a broad production usage-pipeline refactor that introduces a new provider-core reader contract, moves three transcript implementations, generalizes resumable parsing and cache state, and rewires UsageService dispatch. The tests support the intended behavior, but the shared infrastructure and persisted-cache boundary make the change too substantial for automatic approval. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (1)
Limit details: You’ve used all 10 included reviews currently available. 📝 WalkthroughWalkthroughProvider-core adds shared provider usage-reader contracts. Claude, Codex, and Grok add transcript readers. The server discovers readers through built-in drivers and uses their formats for transcript parsing, resumable state, cache decoding, and shared-session deduplication. ChangesProvider usage reader integration
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~60 minutes Change: Refactor Sequence Diagram(s)sequenceDiagram
participant UsageService
participant BUILT_IN_USAGE_DRIVERS
participant ProviderUsageReader
participant readTranscriptRecords
UsageService->>BUILT_IN_USAGE_DRIVERS: enumerate usage readers
UsageService->>ProviderUsageReader: resolve transcript directories
UsageService->>readTranscriptRecords: parse files using reader formats
Merge Risk: ⚪ Minimal · up to No identified issue blocks merging this change after normal checks. Pre-merge checks |
|
ProviderDriver gains an optional usage reader (provider-core/server/usage). The JSONL engine takes a TranscriptUsageFormat instead of branching on the provider. Claude and Codex formats sit next to their drivers; Grok's format and GROK_HOME resolution move into provider-grok. UsageService builds each driver's instances generically and no longer hard-codes transcript homes. The scan cache stores the format's encoded state in cs, byte-compatible with the previous Codex state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9291a7b to
6c36724
Compare
|
Adversarial review (3 reviewers, one per layer group) found no blockers. Two behavior changes against main are fixed in this push:
Also verified: the parsers, prefilters and field selection match main. The Codex |
## What's Changed * chore(deps): upgrade Effect to 4.0.2 by @juliusmarminge in pingdotgg/t3code#17571 * fix(devices): recover stalled video without losing simulator input by @juliusmarminge in pingdotgg/t3code#17566 * fix(web): keep checkout stable while pr actions load by @maria-rcks in pingdotgg/t3code#16625 * fix(mobile): show waiting thread status by @maria-rcks in pingdotgg/t3code#16693 * feat(web): add parent thread breadcrumb navigation by @maria-rcks in pingdotgg/t3code#16666 * fix(server): restart inactivity after snoozed threads wake by @maria-rcks in pingdotgg/t3code#16674 * feat(desktop): passkeys in the in-app browser on macOS by @juliusmarminge in pingdotgg/t3code#16952 * fix(client): load earlier turns works for MCP threads over T3 Connect by @juliusmarminge in pingdotgg/t3code#17599 * refactor(client): sign relay request URLs built from the HttpApi contract by @juliusmarminge in pingdotgg/t3code#17602 * refactor(source-control): add @t3tools/source-control-core by @juliusmarminge in pingdotgg/t3code#17573 * refactor(source-control): Forgejo lives in @t3tools/source-control-forgejo by @juliusmarminge in pingdotgg/t3code#17581 * refactor(source-control): Azure DevOps lives in @t3tools/source-control-azure-devops by @juliusmarminge in pingdotgg/t3code#17592 * refactor(source-control): GitLab lives in @t3tools/source-control-gitlab by @juliusmarminge in pingdotgg/t3code#17594 * refactor(source-control): Bitbucket lives in @t3tools/source-control-bitbucket by @juliusmarminge in pingdotgg/t3code#17597 * refactor(source-control): GitHub lives in @t3tools/source-control-github by @juliusmarminge in pingdotgg/t3code#17607 * refactor(usage): transcript readers come from their drivers by @juliusmarminge in pingdotgg/t3code#17576 * refactor(usage): OpenCode usage comes from provider-opencode by @juliusmarminge in pingdotgg/t3code#17577 * refactor(usage): Cursor account usage comes from provider-cursor by @juliusmarminge in pingdotgg/t3code#17578 * refactor(usage): Antigravity usage is a reader on its driver by @juliusmarminge in pingdotgg/t3code#17579 * refactor(usage): usage readers use Effect FileSystem and SqlClient by @juliusmarminge in pingdotgg/t3code#17615 * fix(web): composer context strip pads both edges evenly by @limineol in pingdotgg/t3code#17562 * test(usage): v4 cache upgrade test waits for the migrated cache write by @Mnigos in pingdotgg/t3code#17553 * feat(mobile): support Duo in the shared iOS app by @juliusmarminge in pingdotgg/t3code#12648 * refactor(source-control): GitManager reads provider resolvers, not host kinds by @juliusmarminge in pingdotgg/t3code#17617 * refactor(source-control): PullRequestService reads GitHub resolvers, not its kind by @juliusmarminge in pingdotgg/t3code#17619 * refactor(source-control): Forgejo identity and Azure DevOps addressing move into their packages by @juliusmarminge in pingdotgg/t3code#17624 * refactor: home directory comes from a HostProcessHomeDirectory reference by @juliusmarminge in pingdotgg/t3code#17628 * refactor(shared): host process references live in a HostProcess module by @juliusmarminge in pingdotgg/t3code#17641 * feat(web): filter PR comments by bots and resolved threads by @juliusmarminge in pingdotgg/t3code#17645 * fix(clients): remove redundant prefix from PR watch status by @extoci in pingdotgg/t3code#17635 * fix(web): pending requests wait until you stop typing by @maria-rcks in pingdotgg/t3code#17637 * fix(models): remove new badges from Claude Opus and Sonnet 5.5 by @extoci in pingdotgg/t3code#17646 * fix(ui): keep focus and selection borders visible across the app by @maria-rcks in pingdotgg/t3code#16675 * fix(mobile): prevent row presses during native back swipes by @juliusmarminge in pingdotgg/t3code#17648 * fix(server): Codex shadow homes replace stray sqlite maintenance locks by @juliusmarminge in pingdotgg/t3code#17663 * feat(desktop): T3 Code can be your default web browser on macOS by @juliusmarminge in pingdotgg/t3code#17587 * test(server): the ACP process-tree test no longer collides with the runner's own pid by @yordis in pingdotgg/t3code#17647 * fix(web): keep branch restore action inline in narrow composers by @Saikrishna1876 in pingdotgg/t3code#14811 * fix(web): composer banner actions stay inline whenever they fit by @maria-rcks in pingdotgg/t3code#17640 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2886...v0.0.46-nightly.20261010.2908 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2908
## What's Changed * chore(deps): upgrade Effect to 4.0.2 by @juliusmarminge in pingdotgg/t3code#17571 * fix(devices): recover stalled video without losing simulator input by @juliusmarminge in pingdotgg/t3code#17566 * fix(web): keep checkout stable while pr actions load by @maria-rcks in pingdotgg/t3code#16625 * fix(mobile): show waiting thread status by @maria-rcks in pingdotgg/t3code#16693 * feat(web): add parent thread breadcrumb navigation by @maria-rcks in pingdotgg/t3code#16666 * fix(server): restart inactivity after snoozed threads wake by @maria-rcks in pingdotgg/t3code#16674 * feat(desktop): passkeys in the in-app browser on macOS by @juliusmarminge in pingdotgg/t3code#16952 * fix(client): load earlier turns works for MCP threads over T3 Connect by @juliusmarminge in pingdotgg/t3code#17599 * refactor(client): sign relay request URLs built from the HttpApi contract by @juliusmarminge in pingdotgg/t3code#17602 * refactor(source-control): add @t3tools/source-control-core by @juliusmarminge in pingdotgg/t3code#17573 * refactor(source-control): Forgejo lives in @t3tools/source-control-forgejo by @juliusmarminge in pingdotgg/t3code#17581 * refactor(source-control): Azure DevOps lives in @t3tools/source-control-azure-devops by @juliusmarminge in pingdotgg/t3code#17592 * refactor(source-control): GitLab lives in @t3tools/source-control-gitlab by @juliusmarminge in pingdotgg/t3code#17594 * refactor(source-control): Bitbucket lives in @t3tools/source-control-bitbucket by @juliusmarminge in pingdotgg/t3code#17597 * refactor(source-control): GitHub lives in @t3tools/source-control-github by @juliusmarminge in pingdotgg/t3code#17607 * refactor(usage): transcript readers come from their drivers by @juliusmarminge in pingdotgg/t3code#17576 * refactor(usage): OpenCode usage comes from provider-opencode by @juliusmarminge in pingdotgg/t3code#17577 * refactor(usage): Cursor account usage comes from provider-cursor by @juliusmarminge in pingdotgg/t3code#17578 * refactor(usage): Antigravity usage is a reader on its driver by @juliusmarminge in pingdotgg/t3code#17579 * refactor(usage): usage readers use Effect FileSystem and SqlClient by @juliusmarminge in pingdotgg/t3code#17615 * fix(web): composer context strip pads both edges evenly by @limineol in pingdotgg/t3code#17562 * test(usage): v4 cache upgrade test waits for the migrated cache write by @Mnigos in pingdotgg/t3code#17553 * feat(mobile): support Duo in the shared iOS app by @juliusmarminge in pingdotgg/t3code#12648 * refactor(source-control): GitManager reads provider resolvers, not host kinds by @juliusmarminge in pingdotgg/t3code#17617 * refactor(source-control): PullRequestService reads GitHub resolvers, not its kind by @juliusmarminge in pingdotgg/t3code#17619 * refactor(source-control): Forgejo identity and Azure DevOps addressing move into their packages by @juliusmarminge in pingdotgg/t3code#17624 * refactor: home directory comes from a HostProcessHomeDirectory reference by @juliusmarminge in pingdotgg/t3code#17628 * refactor(shared): host process references live in a HostProcess module by @juliusmarminge in pingdotgg/t3code#17641 * feat(web): filter PR comments by bots and resolved threads by @juliusmarminge in pingdotgg/t3code#17645 * fix(clients): remove redundant prefix from PR watch status by @extoci in pingdotgg/t3code#17635 * fix(web): pending requests wait until you stop typing by @maria-rcks in pingdotgg/t3code#17637 * fix(models): remove new badges from Claude Opus and Sonnet 5.5 by @extoci in pingdotgg/t3code#17646 * fix(ui): keep focus and selection borders visible across the app by @maria-rcks in pingdotgg/t3code#16675 * fix(mobile): prevent row presses during native back swipes by @juliusmarminge in pingdotgg/t3code#17648 * fix(server): Codex shadow homes replace stray sqlite maintenance locks by @juliusmarminge in pingdotgg/t3code#17663 * feat(desktop): T3 Code can be your default web browser on macOS by @juliusmarminge in pingdotgg/t3code#17587 * test(server): the ACP process-tree test no longer collides with the runner's own pid by @yordis in pingdotgg/t3code#17647 * fix(web): keep branch restore action inline in narrow composers by @Saikrishna1876 in pingdotgg/t3code#14811 * fix(web): composer banner actions stay inline whenever they fit by @maria-rcks in pingdotgg/t3code#17640 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2886...v0.0.46-nightly.20261010.2908 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2908
UsageService hard-coded every provider: it decoded Claude and Codex settings itself, resolved each transcript home, and the JSONL engine branched on
provider === "codex" | "grok". Adding a provider meant editing the aggregator.ProviderDrivergains an optionalusagereader, a discriminated union (transcripts|scan) defined inprovider-core/server/usage, with its own environment (UsageR) so UsageService doesn't require every driver's creation environment.TranscriptUsageFormat(field selection, line prefilter, parsers, optional resumable state with a schema).GROK_HOMEresolution move intoprovider-grok. Claude's and Codex's sit next to their drivers until those become packages.sharedSessionsAcrossFiles).csfield stores the format's schema-encoded state. It is byte-identical to the previous Codex state, so existing caches still resume.BUILT_IN_USAGE_DRIVERSto keep today's result order (Claude, Codex, Grok, …).No behavior change:
UsageService.test.tschanged only in wiring and imports.🤖 Generated with Claude Code (Claude Opus 5.5, Claude Code harness)