Repository navigation
fix(mcp): agent HTML pages stop painting slab backgrounds - #16752
Conversation
Tell agents to leave the page background unset by default, since it already matches the thread, and to pad any box that does paint its own background. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR changes the default styling guidance supplied to agents for existing inline HTML renders, which can alter user-visible page backgrounds, padding, and corners. Despite being a small, guidance-only diff, product-default changes require human review. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe HTML render layout guide now specifies that pages inherit the thread background and that root and outer backgrounds remain unset. It retains the fluid-width and no-outer-card guidance and adds padding and corner requirements for separately colored boxes. ChangesHTML layout guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This change only updates layout guidance, and no concrete user-facing or operational issue is established. It is mergeable with normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
## What's Changed * docs: connect Claude Code, Codex, ChatGPT and bots over MCP by @juliusmarminge in pingdotgg/t3code#16741 * fix(web): thread details card gives titles room to read by @t3dotgg in pingdotgg/t3code#16746 * fix(mcp): agent HTML pages stop painting slab backgrounds by @t3dotgg in pingdotgg/t3code#16752 * fix: composer picks up new project skills without a server restart by @juliusmarminge in pingdotgg/t3code#16750 * feat(server): run a project action when a worktree thread settles by @t3dotgg in pingdotgg/t3code#16290 * feat(web): old Claude threads compact on send instead of stacking notices by @t3dotgg in pingdotgg/t3code#16631 * fix(server): settled threads stop polling their pull requests by @t3dotgg in pingdotgg/t3code#16762 * fix(server): stop storing tool image bytes no client reads by @derektrimm in pingdotgg/t3code#16652 * fix(server): status refresh no longer pegs CPU in repos with thousands of untracked files by @t3dotgg in pingdotgg/t3code#16771 * perf(server): background branch lookups share one GitHub query per sweep by @t3dotgg in pingdotgg/t3code#16760 * fix(server): threads settle as soon as a client sees their PR merge by @t3dotgg in pingdotgg/t3code#16761 * feat(server,web,mobile): agents see snooze state and link to threads by @t3dotgg in pingdotgg/t3code#16782 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261007.2761...v0.0.46-nightly.20261007.2774 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261007.2774
…raming (#28) * fix(server): forks no longer merge into their upstream repo's project group (pingdotgg#16353) Fixes pingdotgg#4880. Originally pingdotgg#14639 by @Project516. Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com> * fix(server): stop the startup project sync from delaying the app window (pingdotgg#14912) * fix(web): avoid blocking image preparation conversions (pingdotgg#13342) * fix(server): return partial workspace index on timeout (pingdotgg#11500) * fix(server): probe project favicon candidates concurrently (pingdotgg#12543) * fix(observability): a failing trace disk no longer stalls the server (pingdotgg#13758) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): status polling no longer locks the git index (pingdotgg#14718) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * perf(shared): scan PATH once per command before spawning, not on every spawn (pingdotgg#12600) * fix(server): main's startup auto-pull test compiles again (pingdotgg#16357) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): project favicons stop being rescanned every minute (pingdotgg#16206) Favicons in ProjectEnrichmentService now keep for 15 minutes. Repository identity keeps its 1-minute TTL, so remote changes still show within a minute. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Claude limits load again for users with large transcript histories (pingdotgg#16358) The Claude capabilities probe now asks for usage with skipBehaviors, so it no longer scans every local transcript and misses its 4 s deadline. Takes over pingdotgg#14456. Co-authored-by: Ashkaan <a@ashkaan.me> * Add esthor to the list of GitHub users * fix(server): caches and ids are written atomically (pingdotgg#16242) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): one-shot initializers no longer race (pingdotgg#16260) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): the PR cache sweep only removes real entry files (pingdotgg#16285) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore: keep one copy each of undici 8 and ws 8 (pingdotgg#16211) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(shared): DrainableWorker keeps running after a failed item (pingdotgg#16223) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): metrics count interrupted work on the monotonic clock (pingdotgg#16207) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(web): import connection storage as a namespace in its test (pingdotgg#16315) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(contracts): trimmed IDs round-trip (pingdotgg#16300) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): main's settings, keybindings and session tests compile again (pingdotgg#16363) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(lint): catch known tags with Effect.catchTags (pingdotgg#16361) * fix(observability): T3 Connect tracing stops at the relay boundary (pingdotgg#16314) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(relay): error and deadline responses carry CORS headers (pingdotgg#16253) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): bring back the live shimmer on work log rows (pingdotgg#16372) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor: Effect code gets UUIDs and SHA-256 from Effect's Crypto (pingdotgg#16377) * fix(relay): export traces through one tracer, one request span each (pingdotgg#16382) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Pi thread titles use linked PR context (pingdotgg#16210) * fix(desktop): retry transient bearer bootstrap and degrade on session fetch failure (pingdotgg#12919) * fix(server): avoid scanning completed history for pending secrets (pingdotgg#16409) * fix(orchestration-v2): let Stop recover stalled runs (pingdotgg#15442) * fix(release): resolve version-qualified catalog overrides (pingdotgg#16411) * fix(web): type in front of bold that starts a composer line (pingdotgg#13217) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(desktop): prevent browser screenshot filename collisions (pingdotgg#14784) * fix(server): end clone options before the repository URL (pingdotgg#14781) * fix(web): queued messages no longer split the composer notice stack (pingdotgg#16400) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> * fix(server): reject invalid explicit Bitbucket repositories (pingdotgg#15876) * fix(desktop): use the crypto service for screenshot IDs (pingdotgg#16415) * fix(shared): find versioned JetBrains macOS app bundles (pingdotgg#16246) * fix(server): OpenCode 2 threads get T3 Code's MCP tools (pingdotgg#16142) * feat(preview): run the browser on the environment server (pingdotgg#15328) * fix: restore service references breaking ci (pingdotgg#16495) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mcp): mark declared tool failures as errors (pingdotgg#15617) * fix(release): unblock nightly browser tests and cli builds (pingdotgg#16515) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mcp): preserve thread command rejection reasons (pingdotgg#15627) * chore(deps): upgrade @effect/tsgo to 0.46.1 (pingdotgg#16360) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(orchestration-v2): show reported subagent models (pingdotgg#14108) Co-authored-by: Yash Singh <saiansh2525@gmail.com> * fix(web): Apple logo no longer dips below the device host label (pingdotgg#14825) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): show subagent effort and speed in hover cards (pingdotgg#13056) Co-authored-by: Julius Marminge <julius0216@outlook.com> * feat(web): reopen closed tabs across the app (pingdotgg#15207) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): stop wide ordered list markers from clipping (pingdotgg#16523) * fix(desktop): build AppImage with the static runtime toolset (fixes libfuse2 launch failure) (pingdotgg#7765) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(mobile): keep usage-limit notice opaque (pingdotgg#15602) * feat(server): GitHub API transport that uses gh only for the token (pingdotgg#16319) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): pull requests talk to GitHub's API instead of the gh CLI (pingdotgg#16320) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): source control, media and discovery use GitHub's API instead of gh (pingdotgg#16321) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat: choose the GitHub account per host, save a GitHub token, and fewer reads per PR action (pingdotgg#16322) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Rebase stack moves each layer onto the rebased layer below it (pingdotgg#16551) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): diff panel keeps the chosen scope while a turn runs (pingdotgg#16571) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(desktop): honor the telemetry opt-out from the shell profile (pingdotgg#16563) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(marketing): disclose product usage data in the privacy policy (pingdotgg#16562) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): note anonymous usage data in onboarding and link the privacy policy (pingdotgg#16564) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * perf(web): diff panel no longer re-renders every file header each time a patch arrives (pingdotgg#16033) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): every T3 MCP tool declares who may call it (pingdotgg#16335) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): outside agents sign in to the T3 MCP server with OAuth (pingdotgg#16336) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): copy an environment's MCP URL for outside agents (pingdotgg#16337) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(tsconfig): turn off the Schema-over-JSON diagnostic in test files (pingdotgg#16375) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(review): CodeRabbit gates outside contributors' pull requests (pingdotgg#16332) * fix(desktop): include Linux package license and app metadata (pingdotgg#16597) * fix(server): one failing RPC handler no longer ends the client's other requests (pingdotgg#15515) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(contracts): a context record that cannot be encoded no longer fails the send (pingdotgg#16398) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): open pull request row actions on right-click (pingdotgg#16612) * fix(web): show attempted paths in file preview errors (pingdotgg#15628) * fix(vcs): passive sidebar rows stop retaining remote pollers (pingdotgg#15666) * feat(web): group keybindings settings by area with a page toolbar (pingdotgg#12822) * feat(web): stop T3-owned subagents from Lineage (pingdotgg#15211) * feat(web): add fast actions to linked pull requests (pingdotgg#16627) * feat(web): open right panel tab menu with Mod+T (pingdotgg#15686) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(server): provider sessions clean up when their start is interrupted (pingdotgg#15571) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): show "No project" near the top of the new thread picker (pingdotgg#16628) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(server): instrument WS RPCs in group middleware (pingdotgg#15548) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(deps): upgrade @pierre/diffs to 1.5.2 and @pierre/trees to beta.6 (pingdotgg#16644) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(relay): a host restarting onto a deleted tunnel gets a new one (pingdotgg#16649) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): recover a deleted tunnel when Cloudflare says "Tunnel not found" (pingdotgg#16648) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): iPhone Duo fold controls follow the phone's orientation (pingdotgg#16630) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): keep workspace options when expanding lineage (pingdotgg#16635) * fix(web): preserve bare anchor placeholders in markdown (pingdotgg#16637) * fix(pi): preserve provider identity in discovered models (pingdotgg#16661) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(auth): preserve explicitly granted pairing scopes (pingdotgg#9785) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate environment administration permissions (pingdotgg#9786) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate source control write permissions (pingdotgg#9787) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate filesystem read and write permissions (pingdotgg#9788) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate browser preview control permissions (pingdotgg#9789) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate diagnostics and usage permissions (pingdotgg#9790) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): allow passive terminal observation (pingdotgg#9791) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(auth): keep old clients connected across scope changes (pingdotgg#10298) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(server): hosted agents like ChatGPT can sign in to the T3 MCP server (pingdotgg#16718) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: connect Claude Code, Codex, ChatGPT and bots over MCP (pingdotgg#16741) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): thread details card gives titles room to read (pingdotgg#16746) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(mcp): agent HTML pages stop painting slab backgrounds (pingdotgg#16752) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: composer picks up new project skills without a server restart (pingdotgg#16750) * feat(server): run a project action when a worktree thread settles (pingdotgg#16290) Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): old Claude threads compact on send instead of stacking notices (pingdotgg#16631) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): settled threads stop polling their pull requests (pingdotgg#16762) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): stop storing tool image bytes no client reads (pingdotgg#16652) * fix(server): status refresh no longer pegs CPU in repos with thousands of untracked files (pingdotgg#16771) Co-authored-by: Braulio Oliveira <brauliobo@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * perf(server): background branch lookups share one GitHub query per sweep (pingdotgg#16760) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): threads settle as soon as a client sees their PR merge (pingdotgg#16761) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server,web,mobile): agents see snooze state and link to threads (pingdotgg#16782) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(release): Forgejo build resolves version-qualified catalog overrides Upstream now pins overrides such as undici@^8 to the catalog; the packaging script looked up the whole selector and failed. Mirrors upstream pingdotgg#16411. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): HTML renders and PDFs load behind a proxy that forbids framing Clients frame asset documents from the environment's origin, which is often not their own. A reverse proxy that adds X-Frame-Options: SAMEORIGIN blanked every HTML render and PDF preview in that setup. Inline HTML and PDF asset responses now carry `frame-ancestors *`, which browsers honour in place of X-Frame-Options. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): desktop renderer may frame asset documents CSP's `*` matches only http(s) ancestors, so the desktop app's custom scheme origins are listed explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com> Co-authored-by: Igor Makowski <56691628+Mnigos@users.noreply.github.com> Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com> Co-authored-by: Michel Liao <107891771+Michel-Liao@users.noreply.github.com> Co-authored-by: Ishaan Kothari <ishaanko.mail@gmail.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: ahalekelly <7078138+ahalekelly@users.noreply.github.com> Co-authored-by: SkiTee3000 <39069192+SkiTee3000@users.noreply.github.com> Co-authored-by: Ashkaan <a@ashkaan.me> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Erik Thorelli <ethorelli@gmail.com> Co-authored-by: James Villarrubia <8172873+jamesvillarrubia@users.noreply.github.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> Co-authored-by: Alex Southwell <saphid@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tristan Manchester <108270628+tristanmanchester@users.noreply.github.com> Co-authored-by: Arav Jain <aravhawk@gmail.com> Co-authored-by: Sypher760-gif <sayffadil@gmail.com> Co-authored-by: Nikita Koynov <43469098+nkoynov@users.noreply.github.com> Co-authored-by: maria <maria@kuuro.net> Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Lorenzo <150276837+Bombatomica64@users.noreply.github.com> Co-authored-by: Benedikt Rump <bjrump@gmail.com> Co-authored-by: Stevan Borus <steva.borus@gmail.com> Co-authored-by: Gabriel De Andrade <30420087+gabrielelpidio@users.noreply.github.com> Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com> Co-authored-by: Derek Trimm <275381468+derektrimm@users.noreply.github.com> Co-authored-by: Braulio Oliveira <brauliobo@gmail.com>
Agents' inline HTML pages sometimes paint a solid background (often
#000from personal "true black" style rules) with no padding. The page then reads as a dark slab in the thread, and its content touches the slab's edges.The
html_renderlayout guide now tells agents:html,body, and the outermost element with no background color. The injected--backgroundalready matches the thread. This rule overrides general style preferences.var(--radius)corners.Backgrounds are still allowed. We only add guidance, with no CSS override.
Check: I gave the same mock request to agents with a "true black" rule and the
html-communicationskill. With the new guide, 3 of 3 runs left the page background unset and padded the boxes that had a background by 16px. With the old guide, 3 of 3 runs usedvar(--background), so I could not reproduce the original#000slab locally. The fix is guidance only, and an agent can still ignore it.Reviewed with sol-loop: 1 round with GPT-6.1 Sol on medium.
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code