[ShousenZHANG]

Summary

Part of #36288, following #44237.

#44237 left the Tencent vector store out of type checking. Its 40 diagnostics are fixed here, and both tencent_vector.py and its unit tests are removed from api/pyrefly-local-excludes.txt.

The real problem behind 12 of them: TencentConfig.database was str | None, and every client call passes it as database_name. With TENCENT_VECTOR_DB_DATABASE unset, the config was accepted, and the first call, create_database_if_not_exists(database_name=None), built DatabaseRequest(database=None), which protobuf sends as an empty database name. The error then came back from the server instead of naming the setting.

What changed

• TencentConfig.database is required. A validate_config model validator raises config TENCENT_VECTOR_DB_DATABASE is required when it is missing or empty, the same check and message the Baidu and AnalyticDB configs use. The factory passes TENCENT_VECTOR_DB_DATABASE or "", like the URL next to it, so the validator reports the setting. A new parametrized test, test_config_requires_a_database, covers None and ""; it fails on main.
• Index lists are typed list[vdb_index.IndexField], since the collection mixes filter, vector and sparse indexes (4 diagnostics).
• Upsert documents are typed list[document.Document | dict[str, Any]], the type upsert takes.
• Vector dimension on load. describe_collection returns the index base types; the "vector" index is the VectorIndex _create_collection made, so it is cast, and the dimension is only taken when the SDK reports one (it is int | None), keeping the 1024 default otherwise.
• SDK annotations. tcvectordb declares filter: Union[Filter, str] = None and encode_queries returns one or many sparse vectors. The two filter=None arguments get a targeted # pyrefly: ignore[bad-argument-type], and the single-query result is cast, each with a comment.
• Unit tests. The fake SDK modules are types.ModuleType objects, and assigning attributes to them produced 19 diagnostics. They are now set through vars(module)[...], with the values unchanged. One assertion after _load_collection() becomes assert not vector._enable_hybrid_search, because the is True assertion just above it left the attribute narrowed.

Verification

• Pyrefly 1.3.2, as pinned in uv.lock, on tencent_vector.py and test_tencent_vector.py: 40 diagnostics before, zero after.
• The production check that dev/pyrefly-check-local runs (excluding tests/ and the remaining list), with the provider packages imported from this branch: passed. pyrefly check --config=tests/unit_tests/pyrefly.toml: passed.
• These all passed:
  • ruff format --check and ruff check on the whole api/ tree, without the cache
  • lint-imports: 68 contracts kept
  • dev/lint_response_contracts.py --fail-on-mismatch
  • scripts/check_no_new_getattr.py, check_no_new_controller_sqlalchemy.py, check_no_new_session_mock.py, check_no_new_base_model.py, check_no_new_test_doubles.py and check_no_spec_mock.py
• pytest on Python 3.13:
  • vdb-tencent unit tests: 7 passed; the 5 existing test IDs are unchanged, plus the two new cases
  • test_config_requires_a_database against main: both cases fail with DID NOT RAISE ValueError
  • all vector store unit tests (providers/vdb/*/tests/unit_tests and tests/unit_tests/core/rag/datasource/vdb): 709 passed

Screenshots

Before	After
N/A: backend config validation and typing; 40 diagnostics in excluded files.	N/A: zero diagnostics; both files back in make type-check.

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've verified the change and added or updated tests where meaningful regression risk justifies coverage.
• I've updated the documentation accordingly.
• I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods (backend only: ran the underlying ruff, import-linter, guard-script and Pyrefly commands listed above)

From Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-10-19 03:24:24.919492632 +0000
+++ /tmp/pyrefly_pr.txt	2026-10-19 03:24:16.123443185 +0000
@@ -372,44 +372,6 @@
   --> providers/vdb/vdb-tencent/tests/integration_tests/conftest.py:94:24
 ERROR Argument `FilterIndexConfig | None` is not assignable to parameter `filter_index_config` with type `FilterIndexConfig` in function `tcvectordb.rpc.model.collection.RPCCollection.__init__` [bad-argument-type]
   --> providers/vdb/vdb-tencent/tests/integration_tests/conftest.py:95:33
-ERROR Object of class `ModuleType` has no attribute `IndexType` [missing-attribute]
-  --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:99:5
-ERROR Object of class `ModuleType` has no attribute `MetricType` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:105:5
-ERROR Object of class `ModuleType` has no attribute `FieldType` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:106:5
-ERROR Object of class `ModuleType` has no attribute `Document` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:108:5
-ERROR Object of class `ModuleType` has no attribute `HNSWSearchParams` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:109:5
-ERROR Object of class `ModuleType` has no attribute `AnnSearch` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:110:5
-ERROR Object of class `ModuleType` has no attribute `Filter` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:111:5
-ERROR Object of class `ModuleType` has no attribute `KeywordSearch` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:112:5
-ERROR Object of class `ModuleType` has no attribute `WeightedRerank` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:113:5
-ERROR Object of class `ModuleType` has no attribute `HNSWParams` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:115:5
-ERROR Object of class `ModuleType` has no attribute `FilterIndex` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:116:5
-ERROR Object of class `ModuleType` has no attribute `VectorIndex` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:117:5
-ERROR Object of class `ModuleType` has no attribute `SparseIndex` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:118:5
-ERROR Object of class `ModuleType` has no attribute `BM25Encoder` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:120:5
-ERROR Object of class `ModuleType` has no attribute `document` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:122:5
-ERROR Object of class `ModuleType` has no attribute `enum` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:123:5
-ERROR Object of class `ModuleType` has no attribute `index` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:124:5
-ERROR Object of class `ModuleType` has no attribute `RPCVectorDBClient` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:126:5
-ERROR Object of class `ModuleType` has no attribute `VectorDBException` [missing-attribute]
-   --> providers/vdb/vdb-tencent/tests/unit_tests/test_tencent_vector.py:127:5
 ERROR Object of class `ModuleType` has no attribute `VectorType` [missing-attribute]
   --> providers/vdb/vdb-tidb-vector/tests/unit_tests/test_tidb_vector.py:77:5
 ERROR Object of class `ModuleType` has no attribute `Vector` [missing-attribute]

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	75.38%	75.37%	-0.00%
Strict coverage	75.05%	75.05%	-0.00%
Typed symbols	62,554	62,554	0
Untyped symbols	20,525	20,528	+3
Modules	3802	3802	0

[codecov]

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.42%. Comparing base (96202aa) to head (718b7d0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...vdb-tencent/src/dify_vdb_tencent/tencent_vector.py	93.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #44325   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files        5516     5516           
  Lines      330388   330445   +57     
  Branches    66084    66101   +17     
=======================================
+ Hits       292120   292188   +68     
+ Misses      33073    33068    -5     
+ Partials     5195     5189    -6     

Flag	Coverage Δ
api	88.63% <97.43%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.