[hyoban]

Summary

Removes unnecessary type assertions across web/ (155 files) using dify/no-unnecessary-type-assertion, a type-aware tsslint rule written for this migration.

The rule is a migration tool, not a regular lint rule.

• It is not loaded by lint:tss or CI. web/tsslint.config.ts only enables it when TSSLINT_TYPE_ASSERTION_MIGRATION=true.

• To run it again:

  pnpm --filter dify-web migrate:type-assertions

  This runs tsslint with --force --fix. Fix mode can run out of memory on large batches, so repeat it until nothing changes. Then run vp lint --fix (unused imports) and tsc.

What it does

• Removes value as T when value already has exactly type T.
• Removes an upcast value as T where the receiver type is fixed:
  • an argument to a non-generic, non-overloaded call
  • a return in an annotated, non-generic function
  • an assignment whose target type is not a union
• Shortens value as unknown as T to value as T when the two types are assignable in one direction.

What it leaves alone

• Values typed by their context: literals, object/array literals, functions, generic calls.
• Literal-typed values that would widen.
• References in narrowing positions, including through property access such as (x as T).kind === 'a'.
• Destructured const initializers.

Why the checks stop there

The checks were trimmed to what this migration needed. An ablation on main's original code showed that the removed checks never changed a report. Re-running the trimmed rule from main reproduces this PR's changes exactly.

Because of that, the rule is not a general-purpose safe autofix. Always verify a new run with tsc.

Why not typescript/no-unnecessary-type-assertion?

In web/ no type-aware typescript rules are enabled; they are only configured for sdks/nodejs-client. Enabling the built-in rule and applying its fix broke type-checking, because it removes assertions that drive generic inference (get(url) as Promise<T>, values inside vi.hoisted(...)). The rule has no option to turn that off.

Verification

• tsc reports 0 errors.
• vp lint passes.
• scripts/check-web-production-unused-after-knip-fix.mjs passes.
• The rule's 8 unit tests pass.
• Regular lint:tss is unchanged; it does not load the rule.

Removing a type assertion does not change emitted JavaScript, so the test suites of the changed spec files were not run.

Checklist

• This change requires a documentation update, included: Dify Document
• I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
• I've verified the change and added or updated tests where meaningful regression risk justifies coverage.
• I've updated the documentation accordingly.
• I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods

🤖 Generated with Claude Code

From Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 87.76224% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.12%. Comparing base (0d580fd) to head (d76bd89).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...b/plugins/tsslint/no-unnecessary-type-assertion.ts	89.94%	18 Missing ⚠️
web/plugins/tsslint/test-utils.ts	75.86%	7 Missing ⚠️
.../workflow/nodes/_base/components/variable/utils.ts	40.00%	3 Missing ⚠️
...omponents/workflow/hooks/use-nodes-interactions.ts	33.33%	2 Missing ⚠️
...onents/workflow/nodes/trigger-plugin/use-config.ts	0.00%	2 Missing ⚠️
.../components/error-handle/error-handle-on-panel.tsx	50.00%	1 Missing ⚠️
...omponents/workflow/nodes/trigger-plugin/default.ts	0.00%	1 Missing ⚠️
...rigger-schedule/utils/execution-time-calculator.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #44219      +/-   ##
==========================================
- Coverage   89.12%   89.12%   -0.01%     
==========================================
  Files        5308     5310       +2     
  Lines      327106   327295     +189     
  Branches    64277    64376      +99     
==========================================
+ Hits       291543   291709     +166     
- Misses      30368    30391      +23     
  Partials     5195     5195              

Flag	Coverage Δ
dify-ui	92.25% <ø> (ø)
web	89.70% <87.76%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.