fix(test): compile the platform-conditional fixtures warning-free on windows

[JamBalaya56562]

Two compiler warnings that only a Windows build can see. Both are created by #[cfg], and neither has ever been compiled here, because there is no windows-latest job.

They matter more than warnings usually do: mise r lint:clippy is

cargo clippy --all --all-features --all-targets -- -D warnings

--all-targets covers test targets and -D warnings denies. On Windows these are a build failure, not noise — so this is a prerequisite for the CI job rather than a tidy-up.

conformance/tests/derive_settings.rs — unused import: WarningKind

WarningKind is imported at the top of the file, and the only test that uses it is #[cfg(unix)]: it builds a non-UTF-8 path with OsStr::from_bytes, which exists only there. Everywhere else the import has no use.

It moves inside the test, beside the use std::os::unix::ffi::OsStrExt; that is already there for the same reason.

I looked at whether the test could instead run on Windows, since the mechanism under test is platform-independent — SettingGiven::NotText is decided by std::str::from_utf8 over bytes. It cannot, and the reason is documented in argv/src/lib.rs: os_string_from_bytes deliberately refuses an unpaired surrogate on Windows rather than reaching for from_encoded_bytes_unchecked, so the crate needs no unsafe. The Unix test's first assertion — that the field keeps the real bytes — is therefore false on Windows by design. A Windows sibling would be a different test asserting that refusal, which is a coverage gap worth filling but not this change.

usage-rs/tests/facade.rs — variant name ends with the enum's name

enum Shell {
    Bash,
    Zsh,
    #[cfg(windows)]
    PowerShell,
}

On Linux the enum is { Bash, Zsh } and nothing fires. On Windows the third variant appears, a variant name ends with the enum's own, and clippy::enum_variant_names reports it.

Allowed with a reason rather than renamed. PowerShell is the shell's actual name, and a spelling picked to satisfy the lint would be one no user types — which is the opposite of what a ValueEnum fixture should demonstrate.

Measurement

Run on windows-latest in a fork, since there is no Windows job here yet.

Before — cargo clippy --all --all-features --all-targets with warnings not denied, to enumerate rather than stop at the first:

warning: unused import: `WarningKind`
  --> conformance\tests\derive_settings.rs:15:75
warning: variant name ends with the enum's name
    --> usage-rs\tests\facade.rs:1349:5

Two, and only two.

After — the real task, mise r lint:clippy, with no continue-on-error:

[lint:clippy] $ cargo clippy --all --all-features --all-targets -- -D warnings
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 19s

Green. The Linux test job on the same commit is green too, so neither edit changes anything there — as expected, since neither warning exists on Linux (0 hits for warning: across 4,415 lines of that job's log).

Why draft

Behind #1232 and #1233, which fix the five actual Windows test failures. This one clears the lint half of the same door. The windows-latest job follows once all three land.

---

This description was generated by Claude Code.

Summary by CodeRabbit

• Tests
  • Improved platform-specific test organization without changing behavior.
  • Preserved the user-facing spelling of the Windows PowerShell option while clarifying its platform-specific usage.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 72c950dc-30d1-4fb0-99b3-d7fe9b916b5d

📥 Commits

Reviewing files that changed from the base of the PR and between baad8d2 and cee56a4.

📒 Files selected for processing (2)

• conformance/tests/derive_settings.rs
• usage-rs/tests/facade.rs

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The changes localize WarningKind to its Unix-specific test and add a documented Clippy allowance for the private Shell enum. No behavior or public declarations change.

Changes

Lint and test hygiene

Layer / File(s)	Summary
Test import scope conformance/tests/derive_settings.rs	The Unix-specific test now imports WarningKind locally.
Shell lint allowance usage-rs/tests/facade.rs	The private Shell enum documents and allows clippy::enum_variant_names without changing variants or parsing behavior.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to cee56

This localized change makes platform-specific test fixtures compile warning-free on Windows without changing production behavior; the relevant lint checks are green, so no actionable merge-blocking risk remains.

Suggested reviewers: jdx

Poem

A rabbit tidies imports with care,
Keeps WarningKind close to its test there.
Clippy sees Shell and rests,
While comments explain the quests.
No behavior hops anywhere.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the pull request's main change: fixing platform-conditional test warnings on Windows.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}