feat(spec): omit versions from metadata views - #1066
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9bd0595 to
c2782ea
Compare
Instruction countsNothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does. New, nothing to compare against: Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
c2782ea to
12ec766
Compare
12ec766 to
11df93c
Compare
30a227f to
86d5ac2
Compare
86d5ac2 to
a018105
Compare
a018105 to
5d9fb00
Compare
Add
SpecView::omit_version()for checked-in generated specs whose release automation manages versions separately. The base derived spec remains versioned, so runtime--versionbehavior is unchanged; only the cold metadata view omits it. A laterversion(...)override restores an explicit version.Tests:
cargo test -p usage-argv --all-features a_spec_view_applies_identity_and_sparse_effects_without_mutating_the_basecargo clippy -p usage-argv --all-features -- -D warningsNote
Low Risk
Cold-path metadata only; parsing and version responses still use the base spec, with small API surface and test coverage.
Overview
Adds
SpecView::omit_version()so cold-path metadata (KDL emission, help consumers) can drop the version string while the derivedSpecstill carries one for runtime--version.The view tracks an
omit_versionflag:spec()andto_kdl()then emit no version instead of inheriting the base; callingversion(...)clears omission and restores an explicit override. Tests cover base KDL still including version, omitted KDL without aversionline, andomit_versionthenversionordering.Reviewed by Cursor Bugbot for commit 5d9fb00. Bugbot is set up for automated code reviews on this repo. Configure here.