fix(config): accept case-insensitive boolean words - #1207
Conversation
Co-authored-by: jdx <jdx@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughBoolean coercion accepts recognized true and false words case-insensitively. Tests cover mixed- and uppercase spellings while preserving numeric and empty-string handling. ChangesBoolean coercion
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change makes textual boolean values case-insensitive while preserving numeric and unknown-value behavior; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
Summary
Preserve fnox's existing settings behavior while moving its registry to
usage-config: boolean words from textual layers are now ASCII-case-insensitive.Before the migration, values such as
FNOX_NO_DEFAULTS=TRUE,YES, orONwere accepted. The shared resolver only accepted lowercase words, warned, and fell back tofalse, which could unexpectedly merge top-level secrets.Numeric
1/0and the existing strict rejection of unknown non-empty values are unchanged.Test plan
cargo test -p usage-configcargo clippy -p usage-config --all-features -- -D warningsPart of preparing the fleet settings stack for the usage v6 swap.
Summary by CodeRabbit