fix(derive): keep parsed fields live for lints - #1138
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction countsNothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does. New, nothing to compare against: Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
e6e5aae to
a0150f2
Compare
a0150f2 to
eb802eb
Compare
eb802eb to
6ba0439
Compare
6ba0439 to
6990d29
Compare
1bc38b6 to
368fd46
Compare
534269d to
532e347
Compare
532e347 to
5507725
Compare
5507725 to
60a6c59
Compare
60a6c59 to
5507725
Compare
5507725 to
15a2e99
Compare
15a2e99 to
1627dab
Compare
de624db to
e835371
Compare
e835371 to
54bce9c
Compare
54bce9c to
082ebe7
Compare
f8743cd to
e1b5ca4
Compare
e1b5ca4 to
c97e6a3
Compare
c97e6a3 to
20dba88
Compare
20dba88 to
333ae43
Compare
333ae43 to
47077c5
Compare
a49903e to
ce6f267
Compare
7a63589 to
91537cc
Compare
91537cc to
04240b0
Compare
Generated command construction now takes a shared reference to every parsed field. This preserves intentional parse-only compatibility flags under
deny(dead_code)without adding optimized runtime work.A facade regression compiles an ignored flag under
#[deny(dead_code)], and PLAN records the adopter requirement.This PR description was generated by Codex.
Note
Low Risk
Small derive codegen tweak plus a regression test; no change to parse semantics or security-sensitive paths.
Overview
Generated command construction now takes a shared reference to every parsed field so intentional parse-only compatibility flags no longer trip
deny(dead_code).The extra reads are expected to optimize away. A facade regression compiles an ignored flag under
#[deny(dead_code)], and PLAN records the adopter requirement.Reviewed by Cursor Bugbot for commit 04240b0. Bugbot is set up for automated code reviews on this repo. Configure here.