Skip to content

fix(test): compile the platform-conditional fixtures warning-free on windows #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Aug 23, 2026
Merged

fix(test): compile the platform-conditional fixtures warning-free on windows #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conformance/tests/derive_settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use std::ffi::OsStr;
use std::path::PathBuf;

use usage_config::{resolve, Const, Layers, PropMeta, Registry, Ty, Value, WarningKind};
use usage_config::{resolve, Const, Layers, PropMeta, Registry, Ty, Value};
use usage_derive::Cli;

/// A tool with settings
Expand Down Expand Up @@ -177,6 +177,7 @@ fn a_value_that_is_not_text_is_reported_rather_than_rendered() {
// still held the real bytes, and the command line's answer is the one that outranks every file
// on the machine.
use std::os::unix::ffi::OsStrExt;
use usage_config::WarningKind;

let bytes = OsStr::from_bytes(b"/etc/co\xffnfig");
let argv = [OsStr::new("--config"), bytes];
Expand Down
5 changes: 5 additions & 0 deletions usage-rs/tests/facade.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,6 +1332,11 @@ struct StrictFlatten {

#[derive(ValueEnum)]
#[usage(ignore_case)]
// `PowerShell` ends with the enum name, which `clippy::enum_variant_names` reads as a prefix
// worth hoisting. It is the shell's actual name, and the lint only fires on Windows, where the
// variant exists at all — a rename to satisfy it would leave the enum spelling something no
// user types.
#[allow(clippy::enum_variant_names)]
enum Shell {
#[usage(
aliases(["bourne-again", "bash-shell"]),
Expand Down