Repository navigation
spec(shootout): move the measured AOT baseline row out of the bench module - #13128
Merged
Merged
Conversation
…odule `bench` lexes as a keyword, so `use tri::shootout::bench::MEASURED_T27B_BASELINE;` drops `: : MEASURED_T27B_BASELINE ;` at parse in acceptance_matrix.t27 and codegen_audit.t27 (cause C of the corpus ratchet red, added by #13099). - New specs/tri/shootout/measured_aot.t27 holds LanguageResult and MEASURED_T27B_BASELINE, moved verbatim from bench.t27, plus one test. - bench.t27, codegen_audit.t27 and acceptance_matrix.t27 import the row from measured_aot. No assert changed. parse-complete on specs/tri/shootout: 2 discards (8 tokens) before, 0 after. use-edges: all three importers resolve to measured_aot.t27. Tests not run on the Mac. Refs #13113 Refs #12877 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This was referenced Nov 2, 2026
This was referenced Nov 2, 2026
Merged
Merged
This was referenced Nov 9, 2026
Co-authored-by: Dmitrii Vasilev <gHashTag@users.noreply.github.com>
This was referenced Nov 9, 2026
Contributor
PR DashboardGenerated at: 2026-11-09 21:01:41 UTC
Summary
Seal Status
|
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On #13121 the corpus ratchet names two
parse-no-discardrows that are not in that PR's scope:specs/tri/shootout/acceptance_matrix.t27specs/tri/shootout/codegen_audit.t27Both come from the same line 24,
use tri::shootout::bench::MEASURED_T27B_BASELINE;, added by #13099.benchlexes as a keyword, so the use path stops atshootout::and the parser drops: : MEASURED_T27B_BASELINE ;, 4 tokens per file (#11101, spec half #13113). No spelling of a path through a module namedbenchparses, so the row has to move.This PR does not bless, does not raise a cap and does not touch either ledger.
Change
specs/tri/shootout/measured_aot.t27. It is the one home ofLanguageResultandMEASURED_T27B_BASELINE. Both are moved verbatim frombench.t27, with their measurement comment, and one test is added: calls per second times the runtime gives back the 200M logical calls, within 0.01 percent.bench.t27,codegen_audit.t27,acceptance_matrix.t27now read the row throughuse tri::shootout::measured_aot::MEASURED_T27B_BASELINE;. No assert changed.Checked locally
t27c parse-complete --specs-dir specs/tri/shootout: before, 13 files scanned and 2 with discards, 8 tokens; after, 14 files scanned and 0 discarded.t27c use-edges: all three importers resolve tospecs/tri/shootout/measured_aot.t27.t27c checkreports Typecheck OK on all four files. It reported OK before the change too, so this is not evidence that the import resolves.Not done
measured_aot.t27andbench.t27, and the arm64 counts ofcodegen_audit.t27andacceptance_matrix.t27(FR-004 of spec(tri/shootout): baseline at a keyword use path #13113), wait for a T27 OS pane.What this PR may turn red
unlistedinspecs/tri/t27b/steward.t27). On master this check already lists 2 such rows from spec(t27b): L1 clamp gate, if-conversion conditions, noisy-row rule (Refs #12877) #13099:l1_clamp.t27andifconv_plan.t27. If the reference passes the newmeasured_aot.t27, it becomes a third row. A ledger row for it is a steward decision and is not in this PR.bench.t27keeps its t27bpassrow. Whether t27b still passes it through the new import is not measured yet.Refs #13113
Refs #12877
🤖 Generated with Claude Code
Note
Low Risk
Spec-only refactor to fix parser/import paths; no runtime, auth, or data-handling changes.
Overview
Fixes parse failures where
use tri::shootout::bench::MEASURED_T27B_BASELINEdrops tokens becausebenchis a keyword (#13113).Adds
specs/tri/shootout/measured_aot.t27as the single home forLanguageResultandMEASURED_T27B_BASELINE, moved verbatim frombench.t27, plus a test thatcalls_per_sec × runtimerecovers ~200M logical calls within 0.01%.bench.t27,codegen_audit.t27, andacceptance_matrix.t27now import the baseline viatri::shootout::measured_aot::; benchmark harness logic and existing asserts are unchanged aside from the removed duplicate type/constant definitions inbench.t27.Reviewed by Cursor Bugbot for commit 4c95a20. Bugbot is set up for automated code reviews on this repo. Configure here.