Repository navigation
scan: drop the developer-home spelling from blocker attribution (Closes #13549) - #13550
Merged
Merged
Conversation
The home-path step of secret-scan matched the comment that described an older red. The shared and unseen B-lines are now asserted too. Closes #13549 Co-authored-by: Dmitrii Vasilev <gHashTag@users.noreply.github.com>
This was referenced Nov 9, 2026
This was referenced Nov 9, 2026
Contributor
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
fix(scope): descriptionCloses #13549t27c test-report specs/claw/blocker_attribution.t27(4 pass, 0 vacuous, 12 runtime asserts)t27c seal specs/claw/blocker_attribution.t27 --savethen--verify(all hashes MATCH)Description
Master
secret-scanrun 42688287091 ondaec2cc84failed in "Block hardcoded developer-home paths". gitleaks on that run succeeded. The only non-allowlisted hit was a comment inspecs/claw/blocker_attribution.t27that named the spelling while describing an older red (#13179, introduced by #13183). The comment no longer contains that spelling. The same verdict test now also checks the shared and unseen B-lines.Closes #13549
Changes
specs/claw/blocker_attribution.t27— comment spelling removed; shared and unseen lines asserted.trinity/seals/claw_ClawBlockerAttribution.json— resealedTesting
Negative control: flipping the foreign assert to
B_OWNmadetest-reportexit 1 ona_foreign_blocker_is_a_hold_not_a_fix, then the assert was restored.Local home-path scan (the workflow's allowlist) lists no offender after this change.
Documentation
No doc change. The law stays in the spec.
Review Notes
Function coverage of this spec was already 2/2. The measured movement is runtime asserts in
the_line_names_the_verdict: 4 before, 8 after. Do not merge while required checks are pending or red.φ² + 1/φ² = 3 | TRINITY
Note
Low Risk
Comment-only secret-scan fix plus extra test assertions and seal refresh; no runtime or auth logic changes.
Reviewed by Cursor Bugbot for commit 317fdba. Bugbot is set up for automated code reviews on this repo. Configure here.