Repository navigation
spec: clear the two new Corpus ratchet regressions (sha256_round0, glass_window) - #13121
Merged
Merged
Conversation
Line 63 held a `}` with no opening partner, present since the file's first commit 26d81c7. t27c discarded it at top level, so the corpus ratchet saw sha256_round0.t27 as a new parse-no-discard failure. Before: `t27c parse-complete --show` reports 1 token DISCARDED at 63. After: "nothing discarded"; `t27c check` reports 0 errors, 0 warnings. Minimal repro of the same parser behaviour: any stray top-level `}` after a fn body (3-line module) is discarded the same way. No seal exists for this module; no ledger or threshold is changed. Refs #13055 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…imports 2c396c3 (#13062, reached master through the #13053 merge c78af5f) added `use t27os::bench::dec_digits;` and `use t27os::bench::dec_char;` at glass_window.t27:1495-1496. `bench` lexes as the keyword KwBench, so t27c stops the use path at `t27os::` and discards `: : NAME ;` on each line: 8 tokens, the whole "+8" the corpus ratchet reported (404 vs the 396 pinned). The defect is #11101; #13113 tracks the spec-side remedy. The two imports fed four digit loops. They now call put_dec, which the file already imports from t27os::session_store and which writes the same unpadded decimal digits. Before: `t27c parse-complete --show` 404 tokens across 101 lines. After: 396 across 99, and the sorted set of dropped source lines is identical to the file before #13053 (`diff` rc 0). `t27c check` gives 0 errors and the same 69 warnings as master (texts diffed, rc 0). Not done here: no seal re-save (t27os_T27osGlassWindow spec_hash goes stale, 603968db -> d81bd284), no ledger, baseline or threshold change. t27b tests of this spec were not run. Refs #13113 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
This was referenced Nov 2, 2026
This was referenced Nov 2, 2026
This was referenced Nov 2, 2026
Merged
Merged
This was referenced Nov 9, 2026
Co-authored-by: Dmitrii Vasilev <gHashTag@users.noreply.github.com>
This was referenced Nov 9, 2026
Contributor
PR DashboardGenerated at: 2026-11-09 22:05:13 UTC
Summary
Seal Status
|
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corpus ratchet (expected-failure ledger)is red on master. Run 41439759552 names two regressions:sha256_round0is a new row;glass_windowdiscards 404 tokens instead of 396.This PR fixes each one at its source. It does not bless, does not raise a cap and does not touch
docs/reports/suite_expectations.json.1.
specs/numeric/sha256_round0.t27: a new parse-no-discard row}at line 63, present since the spec's first commit 26d81c7. This is a spec error, not a parser regression: the local t27c reproduces the CI verdict.t27c parse-complete --showprints "nothing discarded", andt27c checkreports 0 errors and 0 warnings.2.
specs/t27os/glass_window.t27: discard 396 -> 404use t27os::bench::dec_digits;anduse t27os::bench::dec_char;. Each line drops: : NAME ;(4 tokens) on the bdd-block-fallback channel.benchlexes as a keyword, so the use path stops att27os::(t27c: a use path through the keyword test is dropped by the parser and counted as a discard #11101, spec half spec(tri/shootout): baseline at a keyword use path #13113).put_dec, which this file already imports from session_store.t27, and both imports are gone. 4 lines added, 17 deleted.What this PR turns red
One new red. The spec hash of
T27osGlassWindowmoves from 603968db to d81bd284, so Seal Coverage and spec-guards will name that seal. A re-save needs a master-built t27c and is not in this PR.Four reds that predate this PR. These seals are already red on master as gen-drift, with the spec hash unchanged:
This PR leaves them alone. The re-seal in seal: re-seal GlassWindow/HotReload/PtySys/Release from current master t27c #13115 changed only
sealed_at.Not done
t27b test specs/t27os/glass_window.t27andt27c test-report specs/numeric/sha256_round0.t27wait for a T27 OS pane.Note on the ledger
The ledger holds 75 of 75 rows.
specs/scratchnever appear as rows.Refs #13055
Refs #13113
🤖 Generated with Claude Code
Note
Low Risk
Single-line syntax fix in a numeric spec; no runtime, auth, or generated artifact changes in this diff.
Overview
Clears the Corpus ratchet parse regression for
specs/numeric/sha256_round0.t27by deleting a stray}afterch_ref(beforeendmodule). That brace was invalid module syntax and caused the spec to fail parse-complete / show discarded tokens in CI.No logic or test assertions change—only the erroneous closing brace is removed so the module closes correctly with
endmodule.Reviewed by Cursor Bugbot for commit ce59fb3. Bugbot is set up for automated code reviews on this repo. Configure here.