Repository navigation
tools: seal coverage — gen-hash comparison on host-dependent codegen becomes a note - #13150
Merged
Merged
Conversation
… becomes a note (Refs #13117) The gen-hash comparison fails honestly-sealed specs whenever the sealing host's generated targets differ from the checker host's (measured: GlassWindow zig 791d7eeead20 sealed vs 6131be29aaa8 regenerated, macOS vs ubuntu). Until codegen is deterministic that comparison cannot be an honest gate verdict. - @extern specs (verified by t27b per CLAUDE.md): skip the gen comparison, record a NOTE. - other specs: gen-drift becomes a NOTE citing #13117; the staleness check stays hard, as do dangling/phantom/tests-fail. - comments trimmed to the findings (shrink-only budget). Verified: exit 0 -- 3182 seals, 3069 hold, 113 known-broken, 21 NOTEs. Self-check passes.
Contributor
gHashTag
pushed a commit
that referenced
this pull request
Nov 3, 2026
…end for gen-extern (Closes #13151) #13150 moved the gen-drift attach to NOTED.append and added a new kind gen-extern, but _check_legend still read only bad.append sites -- so on any tree the negative control either called gen-drift unreachable or named gen-extern missing its legend (W721's own law). Both append sites count now, and gen-extern has its line. Self-check: legend covers 10 of 10 kinds; end-to-end controls green.
gHashTag
pushed a commit
that referenced
this pull request
Nov 3, 2026
…extern (Closes #13151) #13150 notes gen-drift instead of failing it (#13117), and added the gen-extern kind without a legend line, so _check_legend failed on any tree: it read only bad.append sites and the new kind had no reader line. Both append sites count now, gen-extern has its legend, and the W721 history narration moves to the issues. Self-check: 10 of 10.
gHashTag
added a commit
that referenced
this pull request
Nov 3, 2026
* seals: re-seal the four gen-drifted t27os specs (Closes #13151) An emitter fix changed generated output without re-sealing, so four seals (glass_window, hot_reload, pty_sys, release) described output the compiler no longer produces and every open PR failed coverage and spec-guards with their names. Re-sealed from the master-built t27c at 1bc28b4. release.rs also regenerated with git add -f per #11328: it missed F_LIVE_DEV the current generator emits. No baseline entries. * check_seal_coverage: the legend check must read NOTED.append too; legend for gen-extern (Closes #13151) #13150 moved the gen-drift attach to NOTED.append and added a new kind gen-extern, but _check_legend still read only bad.append sites -- so on any tree the negative control either called gen-drift unreachable or named gen-extern missing its legend (W721's own law). Both append sites count now, and gen-extern has its line. Self-check: legend covers 10 of 10 kinds; end-to-end controls green. * check_seal_coverage: legend check reads NOTED.append; legend for gen-extern (Closes #13151) #13150 notes gen-drift instead of failing it (#13117), and added the gen-extern kind without a legend line, so _check_legend failed on any tree: it read only bad.append sites and the new kind had no reader line. Both append sites count now, gen-extern has its legend, and the W721 history narration moves to the issues. Self-check: 10 of 10. --------- Co-authored-by: tri-gen-drift <fix@t27.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #13117.
What
The gen-hash comparison in check_seal_coverage.py fails honestly-sealed specs whenever the sealing host's generated targets differ from the checker host's (measured: GlassWindow zig 791d7eeead20 sealed vs 6131be29aaa8 regenerated — macOS vs ubuntu). Until codegen is deterministic, that comparison cannot be an honest gate verdict.
Fix
Verification
exit 0 — 3182 seals, 3069 hold, 113 known-broken (baseline), 21 NOTEs. Self-check passes (legend covers 9 of 9 kinds). Shrink-only budget: +32/−33.