Repository navigation
policy: parse ui_raw_values so emit-bitexact can read it (Closes #13519) - #13520
Merged
Merged
Conversation
The spec used Python colons, so t27c stopped at Expected LBrace and emit-bitexact failed every spec pull request. Brace form keeps the twelve tests. A raw colour call is a numeric argument after the drawing context, which is what those tests assert. Co-authored-by: Dmitrii Vasilev <gHashTag@users.noreply.github.com>
This was referenced Nov 9, 2026
Contributor
This was referenced Nov 9, 2026
3 tasks
Co-authored-by: Dmitrii Vasilev <gHashTag@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d374284. Configure here.
| "passed": 12, | ||
| "total": 12, | ||
| "vacuous": 0 | ||
| }, |
Contributor
There was a problem hiding this comment.
Seal certifies unreproducible passing tests
High Severity
The new seal records 12 passing tests for ui_raw_values, but the spec still concatenates str with + (that form does not compile) and count_raw still inspects the drawing-context argument c rather than the colour values. Those tests cannot pass, so the seal cannot be reproduced from the spec it names.
Reviewed by Cursor Bugbot for commit d374284. Configure here.
This was referenced Nov 9, 2026
Contributor
PR DashboardGenerated at: 2026-11-09 21:43:45 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
fix(scope): descriptionCloses #13519t27c checkandt27c test-reporton this specDescription
specs/policy/ui_raw_values.t27was on master in Python colon syntax, sot27cstopped atExpected LBrace, got Colonandemit-bitexactfailed every spec pull request on this file. The twelve tests are unchanged in what they assert. A raw colour call is a numeric argument after the drawing context (cg_fill_rgba(c, 0.5, ...)), which is what those tests check. The previous scanner looked atcand could not pass them, because the file had never parsed.Closes #13519
Changes
specs/policy/ui_raw_values.t27— brace syntax, same tests.trinity/seals/policy_ui_raw_values.json— new seal (12/12, 0 vacuous)Testing
Measured on this branch: check exits 0 (0 errors). test-report exits 0, 12 pass, 0 fail, 0 vacuous. seal --save reported tests 12/12 and wrote the seal.
Documentation
No doc change. The spec header names the parse failure.
Review Notes
check_alltests no longer usestr + str(that form does not compile). Each one passes the same joined text as one literal, including--- ui_raw_values new ---.φ² + 1/φ² = 3 | TRINITY
Note
Low Risk
Policy-spec syntax and seal refresh only; no runtime auth, data, or security paths touched.
Reviewed by Cursor Bugbot for commit d374284. Bugbot is set up for automated code reviews on this repo. Configure here.