Repository navigation
Deploy Checklist: New Expensify 2024-03-07 #37938
Description
Release Version: 1.4.49-4
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS migration] Migrate 'ReportActionItem.js' component to TypeScript #34487
- [TS migration] Migrate 'Task' page to TypeScript #35484
- Fix/35134: Auto select category and tag #35862
- Improve creating expenses on Collect with Instant Submit #36388
- feat: Build optimistic Edit Task actions #36768
- allow navigating back from SAML signin #37283
- fix/36045: Flag as offensive is absent #37399
- Invite user to workspace via invite link #37525
- Add delete btn to workspace profile page #37528
- Remove old pusher update format #37687
- [NO QA] Remove use of deprecated function when showing violations on a transaction #37703
- Hide engagement modal for anonymous user #37714
- #35715 workspace member details page #37715
- apply custom scrollview throughout the app #37727
- Fix/37207: Display not found page instead Tag Page #37747
- bugfix #37757: admin badge on members list not greyed out when added offline #37892
- [No QA] Update redirects.csv #37914
- [No QA] Use correct TS types #37932
- [CP Staging] Fix free policy member selection #37948
- Fix app crash when navigating to IOU when created offline #37985
- Fix multi-line for task description #37991
- [CP Staging] Revert "[New architecture] Replace
@oguzhnatly/react-native-image-manipulatorwithexpo-image-manipulator" #38024
Deploy Blockers:
- [HOLD - #374470] Thread header and LHN for task assignee system message is missing the assignee #37939
- [$500] Workspace - Member role is not highlighted for newly-invited member #37940
- Members - Back button on Members opens Members page after returning from member profile #37941
- [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-18] By clicking on highlighted WS user, the checkbox is not selected or opening the details of the member #37942
- [HOLD #374470][$500] Task system message is not translated to Spanish #37943
- [HOLD for payment 2024-03-19] [$500] IOS - Workspace-user is not redirected to all workspaces screen #37958
- [$1000] Web - Workspace - No loading indicator is shown on WS screen when navigating via invite link #37959
- Workspace-No message to accept or decline is shown on admin room unless relogin #37960
- [HOLD for payment 2024-03-19] Clicking on invite link for the second time via chat does not open All workspaces #37962
- iOS - Profile - The App crashes when saving the user's avatar #37963
- Join request - Accept and Decline button from Join request does not work in thread #37964
- [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-18] IOU - App crashes when navigate to IOU created offline #37965
- WS – Unable to invite a new user to the WS. #37970
- [HOLD for payment 2024-03-19]Task - Multi-line task descriptions are not truncated in the LHN #37976
- [HOLD 374470]Task - System message does not appear for user B when editing task until page refreshed #37994
- Task - Task preview in Search shows incorrect message owner when task is assigned to self #38000
- WS chats are not archived when Offline, delete WS on another device and go back Online #38003
- [Profile] Web - Joined workspace which is pending for approval disappears after relogin #38008
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Mar 8, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.49-0 🚀
Julesssss commentedon Mar 8, 2024
Checking off #37959 as it is a minor issue.
rlinoz commentedon Mar 8, 2024
Checking off #37964 since we can't reproduce and there is no way to access the feature in product yet.
twisterdotcom commentedon Mar 8, 2024
Checked off #37960 as I couldn't reproduce.
mountiny commentedon Mar 8, 2024
Demoting #37958 as its a new feature
kavimuru commentedon Mar 8, 2024
Regression is 16% left.
unchecked PR
#37727 failing with #37979 repro in PROD checking it off
#37525 failing with #37959 and #37958
luacmartins commentedon Mar 8, 2024
Checking off #37965. Fixed in staging!
roryabraham commentedon Mar 8, 2024
coming from https://expensify.slack.com/archives/C07J32337/p1709925305513199?thread_ts=1709923479.356119&cid=C07J32337, checking off #37976 and #37991
luacmartins commentedon Mar 8, 2024
Checked off 37942. Tested in staging and it's a pass
francoisl commentedon Mar 8, 2024
Demoted #38000 to non-blocker backend fix, checking it off.
kavimuru commentedon Mar 8, 2024
Regression is down to 7%
unchecked PR
#37525 failing with #37959 and #37958
kavimuru commentedon Mar 9, 2024
@roryabraham Regression is completed.
unchecked PR
#37525 failing with #37959 and #37958
Open blockers:
#37939
#37963
#37970
#38003
#38008
roryabraham commentedon Mar 9, 2024
Checking off #37963 because it is reproducible in production
roryabraham commentedon Mar 10, 2024
Please DO NOT ship this checklist before we fix #37963 either with a fix or with the revert. I want to CP the revert to staging before we send this out so that we can get the fix out to prod ASAP
Edit: Revert CP'd and fix verified on staging
mountiny commentedon Mar 11, 2024
demoting:
New features and / or not repro reliably
mountiny commentedon Mar 11, 2024
Demoted #37939 as its a new feature too and not so likely to reproduce
mountiny commentedon Mar 11, 2024
Demoted #37970, the error is not frontend related
mountiny commentedon Mar 11, 2024
Graphs looking good, github too and no new crashes
mountiny commentedon Mar 11, 2024